Bugs item #1983819, was opened at 2008-06-03 21:38
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1983819&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: category
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Mikko Silvonen (silvonen)
Assigned to: Nobody/Anonymous (nobody)
Summary: category.py move crashes when a talk page exists
Initial Comment:
When I tried to move the Finnish category "Luokka:Wolfin palkinnon saaneet" to "Luokka:Wolfin matematiikan palkinnon saajat" with SilvonenBot, category.py crashed after creating the new category and moving its talk page, but before moving any articles to the new category. Did the script try to move the talk page twice, or what is happening here? No time to debug this myself today...
I was using r5503 (+ my patch in bug 1983740).
>category.py move
Checked for running processes. 3 processes currently running, including the current process.
Reading dump from category.dump.bz2
Please enter the old name of the category: Wolfin palkinnon saaneet
Please enter the new name of the category: Wolfin matematiikan palkinnon saajat
Moving text from Luokka:Wolfin palkinnon saaneet to Luokka:Wolfin matematiikan palkinnon saajat.
Creating page [[fi:Luokka:Wolfin matematiikan palkinnon saajat]]
Sleeping for 9.9 seconds, 2008-06-03 20:25:42
Dumping to category.dump.bz2, please wait...
Traceback (most recent call last):
File "C:\svn\pywikipedia\category.py", line 952, in <module>
bot.run()
File "C:\svn\pywikipedia\category.py", line 425, in run
if oldTalk.move(newTalkTitle, reason):
File "c:\svn\pywikipedia\wikipedia.py", line 2095, in move
raise PageNotSaved(u'Page move failed: Target page [[%s]] already exists.' % newtitle)
wikipedia.PageNotSaved: Page move failed: Target page [[Keskustelu luokasta:Wolfin matematiikan palkinnon saajat]] already exists.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1983819&group_…
Bugs item #1983740, was opened at 2008-06-03 20:21
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1983740&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Mikko Silvonen (silvonen)
Assigned to: Nobody/Anonymous (nobody)
Summary: Correct and update the Finnish date formats
Initial Comment:
I made the following corrections and updates in the Finnish date formats in date.py, hopefully without introducing any new bugs:
* The abbreviation "eaa." (BC) should be spelled with a period. It was initially misspelled as "eaa" in Wikipedia page titles.
* Changed the millennium names to match with the existing naming convention.
* Corrected an off-by-one error in the millennium numbering.
* Corrected the "Month of the Year" value (although I am not sure if we currently have any articles of this type).
* Added the Cat_Year_MusicAlbums value.
See the attached patch. A code review would be appreciated, as this is the first modification that I have made in date.py.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1983740&group_…
Bugs item #1981416, was opened at 2008-06-01 19:49
Message generated for change (Comment added) made by srombauts
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1981416&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Sébastien Rombauts (srombauts)
Assigned to: NicDumZ — Nicolas Dumazet (nicdumz)
Summary: Add the get_redirect argument to categories() & templates()
Initial Comment:
There is a need to add the "get_redirect" argument (from the "get()" method) to the "categories()", "templates()" and "templatesWithParams()" methods.
This allow for getting categories and templates links from redirect pages, because sometimes they use some. At least do we use a lot of those "categories in redirect pages" to categories acronyms at work into our intern mediawiki installation
Please see the attached patch that I made from the last available svn revision, which currently is r5491.
It is a "svn diff" as short as possible, only 6 lines modified in "wikipedia.py" : each time the add of the argument to the method ("get_redirect=False") then its use when calling the the get() method (get_redirect=get_redirect)
Please note that :
* I added this "get_redirect" argument defaulted to "False"(ie. "get_redirect=False") because that way I am sure not to break anything elsewhere.
It is up to you whereas to default it to "True" or not.
* I added no comments about this new option, solely to reduce the "diff" file. Please let me know if its up to me to add the comment, then I will submit a new fully commented patch.
Best Regards,
SRombauts
----------------------------------------------------------------------
>Comment By: Sébastien Rombauts (srombauts)
Date: 2008-06-03 12:19
Message:
Logged In: YES
user_id=2104626
Originator: YES
Salut,
Thanks for this quick and clean fix !
I was indeed confused by the the "If nofollow_redirects is True, ignore
redirects entirely" comment.
There was in fact a hint of this dual definition : a #TODO tag was here to
ask this precise question...
I'm currently using pywikipedia for automation of links replacement in our
internal corporate wiki, so I'll come back as soon as I will need some
other functionalities or bugfix :)
Merci,
SRombauts
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-02 19:21
Message:
Logged In: YES
user_id=1963242
Originator: NO
Salut Sébastien ;)
I personally tend not to care about the size of the patch, if the size is
induced by some comments : the more comments we have, the better it is !
And, yes, the fact that the added parameters defaulted to False was indeed
appropriate here.
Something actually struck me reading your patch : Page::categories()
already had a nofollow_redirects parameter that seemed to implement the
behavior you were seeking. This lead me to some interesting findings in
wikipedia.py. Somehow we were duplicating get_redirect with
nofollow_redirects since... r2819 ! I implemented your suggestion, and
removed the duplicate arguments in r5496 (Read more about it in the
changelog here:
http://fisheye.toolserver.org/changelog/pywikipedia/?cs=5496 )
Merci pour l'idée, n'hésite pas à revenir ;)
-- Nicolas.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1981416&group_…
Bugs item #1981755, was opened at 2008-06-02 09:00
Message generated for change (Comment added) made by melancholie
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1981755&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Melancholie (melancholie)
Assigned to: Nobody/Anonymous (nobody)
Summary: login.py issues
Initial Comment:
When running "login.py -all" the following error is shown sporadically:
Logging in to wikipedia:??
Login failed. Wrong password or CAPTCHA answer?
Bot does -not- stop then, but does not login either. Also with API_login, by the way (seems to happen more often with API).
2. With API_login enabled, it isn't shown that you have new messages on a certain wiki.
3. If bot is blocked on a certain wiki, no warning message seems to be shown anymore.
----------------------------------------------------------------------
>Comment By: Melancholie (melancholie)
Date: 2008-06-03 09:56
Message:
Logged In: YES
user_id=2089773
Originator: YES
Important: With API_login enabled, a bot does not stay properly logged
in!
Thus, my bot sometimes also edits as IP when using API_login (with block
of IP that's not funny ;-)
----------------------------------------------------------------------
Comment By: Melancholie (melancholie)
Date: 2008-06-02 09:02
Message:
Logged In: YES
user_id=2089773
Originator: YES
@1.: See "??" replaced by a certain lang code, of course ;-)
@3.: Applies for both login methods.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1981755&group_…
Bugs item #1981134, was opened at 2008-06-01 08:58
Message generated for change (Settings changed) made by silvonen
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1981134&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Open
>Resolution: None
Priority: 5
Private: No
Submitted By: Mikko Silvonen (silvonen)
Assigned to: Nobody/Anonymous (nobody)
Summary: New languages not sorted correctly
Initial Comment:
Some new languages (myv, ext, hif, gan, kaa, mdf, sah, szl and srn) were added in r5440, but the codes were not added in self.alphabetic_revised and self.alphabetic_lb in the file families/wikipedia_family.py, so these languages are not always sorted correctly.
Another problem: As far as I can see, hif, kaa, sah and szl are sorted incorrectly in self.alphabetic in the file family.py. Shouldn't they be sorted as follows?
fa,
hif (Fiji Hindi),
fo (Føroyskt);
pt (Português),
kaa (Qaraqalpaqsha),
crh (Qırımtatarca);
ru (Русский),
sah (Саха тыла / Sakha tyla),
se (Sámegiella); and
sl (Slovenščina),
szl (Ślůnski),
so (Soomaaliga).
I am attaching a patch for family.py. Sorry, no patch for families/wikipedia_family yet.
----------------------------------------------------------------------
>Comment By: Mikko Silvonen (silvonen)
Date: 2008-06-03 08:27
Message:
Logged In: YES
user_id=127947
Originator: YES
Sorry, but r5500 fixed the problem only for some languages. The new
languages need to be added also in self.alphabetic_revised and
self.alphabetic_lb in families/wikipedia_family.py, where the sorting order
is different. I just didn't have time to propose a patch for this file.
----------------------------------------------------------------------
Comment By: siebrand (siebrand)
Date: 2008-06-03 01:30
Message:
Logged In: YES
user_id=1107255
Originator: NO
Fixed in r5500
----------------------------------------------------------------------
Comment By: siebrand (siebrand)
Date: 2008-06-03 01:30
Message:
Logged In: YES
user_id=1107255
Originator: NO
Fixed in r...
----------------------------------------------------------------------
Comment By: Mikko Silvonen (silvonen)
Date: 2008-06-01 09:30
Message:
Logged In: YES
user_id=127947
Originator: YES
Hmm, I wonder how many errors there are with previously added languages?
At least stq (Seeltersk) is sorted incorrectly in self.alphabetic and
missing from the other tables.
Does anyone have a sorting order test kit?
----------------------------------------------------------------------
Comment By: Mikko Silvonen (silvonen)
Date: 2008-06-01 09:09
Message:
Logged In: YES
user_id=127947
Originator: YES
Also ext is sorted incorrectly in self.alphabetic. I'll upload a corrected
patch.
File Added: family.diff
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1981134&group_…
Patches item #1918278, was opened at 2008-03-18 07:57
Message generated for change (Settings changed) made by bjweeks
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=1918278&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for 1907586 and 1903113 and other update
Initial Comment:
>speedy_delete.py:update messages for zh
>wikipedia.py: patch bug 1903113 using bug 1907586's patch into current version's wikipedia.py.
----------------------------------------------------------------------
Comment By: Rotem Liss (rotemliss)
Date: 2008-03-18 09:09
Message:
Logged In: YES
user_id=1327030
Originator: NO
Applied speedy_delete.py changes in r5140.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=1918278&group_…
Revision: 5499
Author: siebrand
Date: 2008-06-02 22:17:10 +0000 (Mon, 02 Jun 2008)
Log Message:
-----------
(bug 1974164) Move throttle.log into /logs
Modified Paths:
--------------
trunk/pywikipedia/logs/README
trunk/pywikipedia/wikipedia.py
Modified: trunk/pywikipedia/logs/README
===================================================================
--- trunk/pywikipedia/logs/README 2008-06-02 21:59:52 UTC (rev 5498)
+++ trunk/pywikipedia/logs/README 2008-06-02 22:17:10 UTC (rev 5499)
@@ -1,3 +1,2 @@
-The interwiki bot will store its logfile here.
-
-Other bots will also log here if used with the -log parameter.
+Bots can log their data here. It is used by interwiki.py and some bots will
+log here if used with the -log parameter.
Modified: trunk/pywikipedia/wikipedia.py
===================================================================
--- trunk/pywikipedia/wikipedia.py 2008-06-02 21:59:52 UTC (rev 5498)
+++ trunk/pywikipedia/wikipedia.py 2008-06-02 22:17:10 UTC (rev 5499)
@@ -2905,7 +2905,7 @@
self.setDelay(mindelay)
def logfn(self):
- return config.datafilepath('throttle.log')
+ return config.datafilepath('logs', 'throttle.log')
def checkMultiplicity(self):
self.lock.acquire()