Bugs item #1988912, was opened at 2008-06-09 06:58
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adds revision number after custom edit-summaries
Initial Comment:
Even when a custom edit-summary is provided as the second argument to
target.put(newtext,"My edit summary")
The bot will automatically add a string identifying the SVN revision to the summary
"My edit summary [r5544]"
While I can see that for some commonly used bots, some projects would like to see this information, it shouldn't be appended in the general case as it needlessly reduces the flexibility of the library.
It can be trivially fixed by changing lines 1235 and 1236 of wikipedia.py as attached but I don't have commit access.
Yours
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2008-06-09 15:13
Message:
Logged In: NO
The only reason for this seems to be that it helps with pywikipediabot
technical support. This is not (in my opinion) a good enough reason. The
wikis onto which these revision strings are being pasted have, in general,
no interest in what is running on them - otherwise we'd all have to put our
browser string into the edit-summary so we knew which browsers couldn't
handle which characters, etc.
I do not object to the appending the revision number by default, but there
has to be a way to turn it off. In many cases it is not relevant, and
possibly misleading. For example I'm using the pywiki framework as the last
stage in generating indices for Wiktionary - it is far more relevant to me
to know which version of the database-dump, the dump-cleaner, dump-parser,
index-splitter, and which sorter and formatter were used in the process,
than it is for me to know which version of pywikibot happened to do the
'page.put(file.read(),"With custom edit summary ;)")' equivalent on the
end. (Yes I know it's a lot of processes, but it makes each step quick
enough that I can re-run each time I want to change something quickly.)
There are a number of ways it can be turned off, perhaps a config variable
- an optional parameter to page.put() - a function that people can call to
say "be_annoying(False)" - or (ideally) all of the above, though I feel
that people will given the option start to use it automatically, just
another chore that must be done to get things to work nicely.
I'd be much more in favour of something that automatically generated a
warning if the "svn info -r HEAD" gave a different version number from "svn
info" (though I'd like to be able to turn that off too).
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2008-06-09 12:27
Message:
Logged In: NO
@cosoleto
You can reject a bad
reported bug within 1 minute, write to reporter to run version.py....
yes, /if/ the reporter is the bot owner, which not always is the case.
The system as it is now does not decrease flexibility (Yes, it adds a
string. That does not disable anything...), but it does make identifying
old bugs a hell of a lot easier (you *really* don't want to know how many
people are using the old 'stable' revision). I would support making it a
config option, or logging the revision information elsewhere.
If you would rather create a separate page 'Special:MyUser/PWB_log' or sth
that logs edits/bot runs, fine with me.
----------------------------------------------------------------------
Comment By: Russell Blau (russblau)
Date: 2008-06-09 12:14
Message:
Logged In: YES
user_id=855050
Originator: NO
I agree with removing the version number from the edit summary, except
possibly for the bare default string noted by rotemliss.
----------------------------------------------------------------------
Comment By: Rotem Liss (rotemliss)
Date: 2008-06-09 10:37
Message:
Logged In: YES
user_id=1327030
Originator: NO
I also think that the appending of the revision ID to the edit summary is
not necessary.
Note that the patch suggested in this bug seems to append the revision ID
only to the *default* edit summary, i.e. "Wikipedia python library". Most
scripts don't use this summary, and they shouldn't.
----------------------------------------------------------------------
Comment By: Francesco Cosoleto (cosoleto)
Date: 2008-06-09 10:29
Message:
Logged In: YES
user_id=181280
Originator: NO
I am sorry, but I don't think this commit is fine. You can reject a bad
reported bug within 1 minute, write to reporter to run version.py.... A
good edit summary uses a language intelligible by everybody, no messages
direct to us.
I added in meta instructions about how to report a bug
(http://meta.wikimedia.org/w/index.php?title=Using_the_python_wikipediabot&d…).
It can be updated, translated in other languages. That is a good beginning.
Please, think it over.
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 09:15
Message:
Logged In: YES
user_id=1963242
Originator: NO
And now I see that this patch is only meant to remove the revision number
on custom edit summaries, meaning that most of our scripts will still show
[rXXX] after this patch, iirc. If it is the case, I'm not opposed to this
patch.
Any other inputs ? valhallasw maybe ?
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 09:10
Message:
Logged In: YES
user_id=1963242
Originator: NO
That's a behavior introduced in r5523.
While I do agree that this might be sometimes inducing, it's a very, very
reliable way to know if the bot is running a decent version of the bot.
We are being reported a lot of false positives lately, and honestly,
wasting an hour trying to reproduce a reported bug, when the reporting user
simply comes a few days later "oh, finally I tried reading the manual :
updating to the last svn version fixed my problem" is annoying.
I personally think, as both a developer and a bot owner, that the induced
bot owner disagreements are minor compared to the time the developers will
save. I might be wrong on that point, and any example of a very annoying
edit summary case is welcome to prove me wrong; but until then, I don't
think that this change is going to be reverted.
Thanks...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Bugs item #1988912, was opened at 2008-06-09 06:58
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adds revision number after custom edit-summaries
Initial Comment:
Even when a custom edit-summary is provided as the second argument to
target.put(newtext,"My edit summary")
The bot will automatically add a string identifying the SVN revision to the summary
"My edit summary [r5544]"
While I can see that for some commonly used bots, some projects would like to see this information, it shouldn't be appended in the general case as it needlessly reduces the flexibility of the library.
It can be trivially fixed by changing lines 1235 and 1236 of wikipedia.py as attached but I don't have commit access.
Yours
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2008-06-09 12:27
Message:
Logged In: NO
@cosoleto
You can reject a bad
reported bug within 1 minute, write to reporter to run version.py....
yes, /if/ the reporter is the bot owner, which not always is the case.
The system as it is now does not decrease flexibility (Yes, it adds a
string. That does not disable anything...), but it does make identifying
old bugs a hell of a lot easier (you *really* don't want to know how many
people are using the old 'stable' revision). I would support making it a
config option, or logging the revision information elsewhere.
If you would rather create a separate page 'Special:MyUser/PWB_log' or sth
that logs edits/bot runs, fine with me.
----------------------------------------------------------------------
Comment By: Russell Blau (russblau)
Date: 2008-06-09 12:14
Message:
Logged In: YES
user_id=855050
Originator: NO
I agree with removing the version number from the edit summary, except
possibly for the bare default string noted by rotemliss.
----------------------------------------------------------------------
Comment By: Rotem Liss (rotemliss)
Date: 2008-06-09 10:37
Message:
Logged In: YES
user_id=1327030
Originator: NO
I also think that the appending of the revision ID to the edit summary is
not necessary.
Note that the patch suggested in this bug seems to append the revision ID
only to the *default* edit summary, i.e. "Wikipedia python library". Most
scripts don't use this summary, and they shouldn't.
----------------------------------------------------------------------
Comment By: Francesco Cosoleto (cosoleto)
Date: 2008-06-09 10:29
Message:
Logged In: YES
user_id=181280
Originator: NO
I am sorry, but I don't think this commit is fine. You can reject a bad
reported bug within 1 minute, write to reporter to run version.py.... A
good edit summary uses a language intelligible by everybody, no messages
direct to us.
I added in meta instructions about how to report a bug
(http://meta.wikimedia.org/w/index.php?title=Using_the_python_wikipediabot&d…).
It can be updated, translated in other languages. That is a good beginning.
Please, think it over.
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 09:15
Message:
Logged In: YES
user_id=1963242
Originator: NO
And now I see that this patch is only meant to remove the revision number
on custom edit summaries, meaning that most of our scripts will still show
[rXXX] after this patch, iirc. If it is the case, I'm not opposed to this
patch.
Any other inputs ? valhallasw maybe ?
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 09:10
Message:
Logged In: YES
user_id=1963242
Originator: NO
That's a behavior introduced in r5523.
While I do agree that this might be sometimes inducing, it's a very, very
reliable way to know if the bot is running a decent version of the bot.
We are being reported a lot of false positives lately, and honestly,
wasting an hour trying to reproduce a reported bug, when the reporting user
simply comes a few days later "oh, finally I tried reading the manual :
updating to the last svn version fixed my problem" is annoying.
I personally think, as both a developer and a bot owner, that the induced
bot owner disagreements are minor compared to the time the developers will
save. I might be wrong on that point, and any example of a very annoying
edit summary case is welcome to prove me wrong; but until then, I don't
think that this change is going to be reverted.
Thanks...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Bugs item #1869983, was opened at 2008-01-12 11:23
Message generated for change (Settings changed) made by russblau
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1869983&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 6
Private: No
Submitted By: Bryan (btongminh)
Assigned to: Nobody/Anonymous (nobody)
Summary: Server errors in put() not caught
Initial Comment:
Server errors in Page.put are not caught.
[16:48:05] <siebrand> [2008-01-12 15:43:18] ServerError: (145, 'Connection timed out')
[16:48:06] <siebrand> Traceback (most recent call last):
[16:48:06] <siebrand> File "commonsdelinker/image_replacer.py", line 213, in do
[16:48:06] <siebrand> File "commonsdelinker/image_replacer.py", line 254, in report
[16:48:06] <siebrand> File "/projects/delinker/cdh/wikipedia.py", line 1194, in put
[16:48:06] <siebrand> return self._putPage(newtext, comment, watchArticle, minorEdit, newPage, self.site().getToken(sysop = sysop), sysop = sysop)
[16:48:08] <siebrand> File "/projects/delinker/cdh/wikipedia.py", line 1266, in _putPage
[16:48:10] <siebrand> response, data = self.site().postForm(address, predata, sysop)
[16:48:12] <siebrand> File "/projects/delinker/cdh/wikipedia.py", line 3820, in postForm
[16:48:14] <siebrand> raise ServerError(e)
[16:48:16] <siebrand> ServerError: (145, 'Connection timed out')
----------------------------------------------------------------------
Comment By: Rotem Liss (rotemliss)
Date: 2008-01-13 13:22
Message:
Logged In: YES
user_id=1327030
Originator: NO
Catching ServerError exceptions as of r4875.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1869983&group_…
Bugs item #1988912, was opened at 2008-06-09 09:58
Message generated for change (Comment added) made by russblau
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adds revision number after custom edit-summaries
Initial Comment:
Even when a custom edit-summary is provided as the second argument to
target.put(newtext,"My edit summary")
The bot will automatically add a string identifying the SVN revision to the summary
"My edit summary [r5544]"
While I can see that for some commonly used bots, some projects would like to see this information, it shouldn't be appended in the general case as it needlessly reduces the flexibility of the library.
It can be trivially fixed by changing lines 1235 and 1236 of wikipedia.py as attached but I don't have commit access.
Yours
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
>Comment By: Russell Blau (russblau)
Date: 2008-06-09 15:14
Message:
Logged In: YES
user_id=855050
Originator: NO
I agree with removing the version number from the edit summary, except
possibly for the bare default string noted by rotemliss.
----------------------------------------------------------------------
Comment By: Rotem Liss (rotemliss)
Date: 2008-06-09 13:37
Message:
Logged In: YES
user_id=1327030
Originator: NO
I also think that the appending of the revision ID to the edit summary is
not necessary.
Note that the patch suggested in this bug seems to append the revision ID
only to the *default* edit summary, i.e. "Wikipedia python library". Most
scripts don't use this summary, and they shouldn't.
----------------------------------------------------------------------
Comment By: Francesco Cosoleto (cosoleto)
Date: 2008-06-09 13:29
Message:
Logged In: YES
user_id=181280
Originator: NO
I am sorry, but I don't think this commit is fine. You can reject a bad
reported bug within 1 minute, write to reporter to run version.py.... A
good edit summary uses a language intelligible by everybody, no messages
direct to us.
I added in meta instructions about how to report a bug
(http://meta.wikimedia.org/w/index.php?title=Using_the_python_wikipediabot&d…).
It can be updated, translated in other languages. That is a good beginning.
Please, think it over.
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 12:15
Message:
Logged In: YES
user_id=1963242
Originator: NO
And now I see that this patch is only meant to remove the revision number
on custom edit summaries, meaning that most of our scripts will still show
[rXXX] after this patch, iirc. If it is the case, I'm not opposed to this
patch.
Any other inputs ? valhallasw maybe ?
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 12:10
Message:
Logged In: YES
user_id=1963242
Originator: NO
That's a behavior introduced in r5523.
While I do agree that this might be sometimes inducing, it's a very, very
reliable way to know if the bot is running a decent version of the bot.
We are being reported a lot of false positives lately, and honestly,
wasting an hour trying to reproduce a reported bug, when the reporting user
simply comes a few days later "oh, finally I tried reading the manual :
updating to the last svn version fixed my problem" is annoying.
I personally think, as both a developer and a bot owner, that the induced
bot owner disagreements are minor compared to the time the developers will
save. I might be wrong on that point, and any example of a very annoying
edit summary case is welcome to prove me wrong; but until then, I don't
think that this change is going to be reverted.
Thanks...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Bugs item #1947526, was opened at 2008-04-21 04:56
Message generated for change (Comment added) made by cosoleto
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1947526&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Works For Me
>Priority: 4
Private: No
Submitted By: Alex S.H. Lin (lin4h)
Assigned to: Nobody/Anonymous (nobody)
Summary: speedy_delete cannot quit in Windows
Initial Comment:
OS:Windows XP SP2
Python: 2.5.2c1
When I finish to use speedy_delete.py, I type q to quit program.But it still in "Quitting program." and cannot return to command console.
----------------------------------------------------------------------
>Comment By: Francesco Cosoleto (cosoleto)
Date: 2008-06-09 20:52
Message:
Logged In: YES
user_id=181280
Originator: NO
Works for me:
Python 2.5.2 (r252:60911, Feb 21 2008, 13:11:45) [MSC v.1310 32 bit
(Intel)] on
win32 / WinXP SP2
C:\Python25>python.exe speedy_delete.py -lang:en
[...]
Getting [[Category:Candidates for speedy deletion]] starting at !...
Getting 20 pages from wikipedia:en...
[...]
Input action? ([d]elete, [S]kip, [u]pdate, [q]uit) q
Traceback (most recent call last):
File "c:\Python25\pagegenerators.py", line 763, in __iter__
yield loaded_page
GeneratorExit
Quitting program.
C:\Python25>
Please, try again and reopen the bug if error occur again. Do you use
standard console?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1947526&group_…
Bugs item #1988912, was opened at 2008-06-09 16:58
Message generated for change (Comment added) made by rotemliss
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adds revision number after custom edit-summaries
Initial Comment:
Even when a custom edit-summary is provided as the second argument to
target.put(newtext,"My edit summary")
The bot will automatically add a string identifying the SVN revision to the summary
"My edit summary [r5544]"
While I can see that for some commonly used bots, some projects would like to see this information, it shouldn't be appended in the general case as it needlessly reduces the flexibility of the library.
It can be trivially fixed by changing lines 1235 and 1236 of wikipedia.py as attached but I don't have commit access.
Yours
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
>Comment By: Rotem Liss (rotemliss)
Date: 2008-06-09 20:37
Message:
Logged In: YES
user_id=1327030
Originator: NO
I also think that the appending of the revision ID to the edit summary is
not necessary.
Note that the patch suggested in this bug seems to append the revision ID
only to the *default* edit summary, i.e. "Wikipedia python library". Most
scripts don't use this summary, and they shouldn't.
----------------------------------------------------------------------
Comment By: Francesco Cosoleto (cosoleto)
Date: 2008-06-09 20:29
Message:
Logged In: YES
user_id=181280
Originator: NO
I am sorry, but I don't think this commit is fine. You can reject a bad
reported bug within 1 minute, write to reporter to run version.py.... A
good edit summary uses a language intelligible by everybody, no messages
direct to us.
I added in meta instructions about how to report a bug
(http://meta.wikimedia.org/w/index.php?title=Using_the_python_wikipediabot&d…).
It can be updated, translated in other languages. That is a good beginning.
Please, think it over.
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 19:15
Message:
Logged In: YES
user_id=1963242
Originator: NO
And now I see that this patch is only meant to remove the revision number
on custom edit summaries, meaning that most of our scripts will still show
[rXXX] after this patch, iirc. If it is the case, I'm not opposed to this
patch.
Any other inputs ? valhallasw maybe ?
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 19:10
Message:
Logged In: YES
user_id=1963242
Originator: NO
That's a behavior introduced in r5523.
While I do agree that this might be sometimes inducing, it's a very, very
reliable way to know if the bot is running a decent version of the bot.
We are being reported a lot of false positives lately, and honestly,
wasting an hour trying to reproduce a reported bug, when the reporting user
simply comes a few days later "oh, finally I tried reading the manual :
updating to the last svn version fixed my problem" is annoying.
I personally think, as both a developer and a bot owner, that the induced
bot owner disagreements are minor compared to the time the developers will
save. I might be wrong on that point, and any example of a very annoying
edit summary case is welcome to prove me wrong; but until then, I don't
think that this change is going to be reverted.
Thanks...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Bugs item #1988912, was opened at 2008-06-09 15:58
Message generated for change (Comment added) made by cosoleto
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adds revision number after custom edit-summaries
Initial Comment:
Even when a custom edit-summary is provided as the second argument to
target.put(newtext,"My edit summary")
The bot will automatically add a string identifying the SVN revision to the summary
"My edit summary [r5544]"
While I can see that for some commonly used bots, some projects would like to see this information, it shouldn't be appended in the general case as it needlessly reduces the flexibility of the library.
It can be trivially fixed by changing lines 1235 and 1236 of wikipedia.py as attached but I don't have commit access.
Yours
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
>Comment By: Francesco Cosoleto (cosoleto)
Date: 2008-06-09 19:29
Message:
Logged In: YES
user_id=181280
Originator: NO
I am sorry, but I don't think this commit is fine. You can reject a bad
reported bug within 1 minute, write to reporter to run version.py.... A
good edit summary uses a language intelligible by everybody, no messages
direct to us.
I added in meta instructions about how to report a bug
(http://meta.wikimedia.org/w/index.php?title=Using_the_python_wikipediabot&d…).
It can be updated, translated in other languages. That is a good beginning.
Please, think it over.
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 18:15
Message:
Logged In: YES
user_id=1963242
Originator: NO
And now I see that this patch is only meant to remove the revision number
on custom edit summaries, meaning that most of our scripts will still show
[rXXX] after this patch, iirc. If it is the case, I'm not opposed to this
patch.
Any other inputs ? valhallasw maybe ?
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 18:10
Message:
Logged In: YES
user_id=1963242
Originator: NO
That's a behavior introduced in r5523.
While I do agree that this might be sometimes inducing, it's a very, very
reliable way to know if the bot is running a decent version of the bot.
We are being reported a lot of false positives lately, and honestly,
wasting an hour trying to reproduce a reported bug, when the reporting user
simply comes a few days later "oh, finally I tried reading the manual :
updating to the last svn version fixed my problem" is annoying.
I personally think, as both a developer and a bot owner, that the induced
bot owner disagreements are minor compared to the time the developers will
save. I might be wrong on that point, and any example of a very annoying
edit summary case is welcome to prove me wrong; but until then, I don't
think that this change is going to be reverted.
Thanks...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Bugs item #1988912, was opened at 2008-06-09 15:58
Message generated for change (Comment added) made by nicdumz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adds revision number after custom edit-summaries
Initial Comment:
Even when a custom edit-summary is provided as the second argument to
target.put(newtext,"My edit summary")
The bot will automatically add a string identifying the SVN revision to the summary
"My edit summary [r5544]"
While I can see that for some commonly used bots, some projects would like to see this information, it shouldn't be appended in the general case as it needlessly reduces the flexibility of the library.
It can be trivially fixed by changing lines 1235 and 1236 of wikipedia.py as attached but I don't have commit access.
Yours
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
>Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 18:15
Message:
Logged In: YES
user_id=1963242
Originator: NO
And now I see that this patch is only meant to remove the revision number
on custom edit summaries, meaning that most of our scripts will still show
[rXXX] after this patch, iirc. If it is the case, I'm not opposed to this
patch.
Any other inputs ? valhallasw maybe ?
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 18:10
Message:
Logged In: YES
user_id=1963242
Originator: NO
That's a behavior introduced in r5523.
While I do agree that this might be sometimes inducing, it's a very, very
reliable way to know if the bot is running a decent version of the bot.
We are being reported a lot of false positives lately, and honestly,
wasting an hour trying to reproduce a reported bug, when the reporting user
simply comes a few days later "oh, finally I tried reading the manual :
updating to the last svn version fixed my problem" is annoying.
I personally think, as both a developer and a bot owner, that the induced
bot owner disagreements are minor compared to the time the developers will
save. I might be wrong on that point, and any example of a very annoying
edit summary case is welcome to prove me wrong; but until then, I don't
think that this change is going to be reverted.
Thanks...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Bugs item #1988912, was opened at 2008-06-09 15:58
Message generated for change (Comment added) made by nicdumz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adds revision number after custom edit-summaries
Initial Comment:
Even when a custom edit-summary is provided as the second argument to
target.put(newtext,"My edit summary")
The bot will automatically add a string identifying the SVN revision to the summary
"My edit summary [r5544]"
While I can see that for some commonly used bots, some projects would like to see this information, it shouldn't be appended in the general case as it needlessly reduces the flexibility of the library.
It can be trivially fixed by changing lines 1235 and 1236 of wikipedia.py as attached but I don't have commit access.
Yours
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
>Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2008-06-09 18:10
Message:
Logged In: YES
user_id=1963242
Originator: NO
That's a behavior introduced in r5523.
While I do agree that this might be sometimes inducing, it's a very, very
reliable way to know if the bot is running a decent version of the bot.
We are being reported a lot of false positives lately, and honestly,
wasting an hour trying to reproduce a reported bug, when the reporting user
simply comes a few days later "oh, finally I tried reading the manual :
updating to the last svn version fixed my problem" is annoying.
I personally think, as both a developer and a bot owner, that the induced
bot owner disagreements are minor compared to the time the developers will
save. I might be wrong on that point, and any example of a very annoying
edit summary case is welcome to prove me wrong; but until then, I don't
think that this change is going to be reverted.
Thanks...
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Bugs item #1988912, was opened at 2008-06-09 06:58
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Adds revision number after custom edit-summaries
Initial Comment:
Even when a custom edit-summary is provided as the second argument to
target.put(newtext,"My edit summary")
The bot will automatically add a string identifying the SVN revision to the summary
"My edit summary [r5544]"
While I can see that for some commonly used bots, some projects would like to see this information, it shouldn't be appended in the general case as it needlessly reduces the flexibility of the library.
It can be trivially fixed by changing lines 1235 and 1236 of wikipedia.py as attached but I don't have commit access.
Yours
en:wikt:Conrad.Irwin
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1988912&group_…