Bugs item #1999895, was opened at 2008-06-22 09:41
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999895&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: interwiki
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: iw bot doesn't detect edit conflict
Initial Comment:
interwiki bots read several pages at once and if the bot is delayed for some reason while processing these pages (network connection error or whatever other reason), it happens that the bot works on an outdated copy of the page (e.g. http://de.wikipedia.org/w/index.php?title=National_Basketball_Association&d…) and doesn't detect edit conflict when putting the updated page. This results in edits like this (http://de.wikipedia.org/w/index.php?title=National_Basketball_Association&d…) that definitely should be avoided.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999895&group_…
Patches item #1999637, was opened at 2008-06-22 01:12
Message generated for change (Settings changed) made by cosoleto
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=1999637&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Melancholie (melancholie)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add hsb and sk summary translation for featured.py
Initial Comment:
Add the following line to the summary array:
'sk': u'Bot: [[%s:%s]] je najlepší článok',
See
http://de.wikipedia.org/wiki/Benutzer_Diskussion:Melancholie#sk_wiki
----------------------------------------------------------------------
Comment By: Melancholie (melancholie)
Date: 2008-06-22 02:13
Message:
Logged In: YES
user_id=2089773
Originator: YES
Also add the summary for hsb:
'hsb': u'Bot: [[%s:%s]] je wuběrny nastawk',
See
http://hsb.wikipedia.org/wiki/Diskusija_z_wu%C5%BEiwarjom:MelancholieBot#Te…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=1999637&group_…
Bugs item #1999787, was opened at 2008-06-22 12:27
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999787&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alex S.H. Lin (lin4h)
Assigned to: Nobody/Anonymous (nobody)
Summary: InvocationException in interwiki_graph.py
Initial Comment:
Version:
Microsoft Windows XP Professional with SP3
Pywikipedia [http] trunk/pywikipedia (r5604, Jun 21 2008, 20:20:16)
Python 2.5.2 (r252:60911, Feb 21 2008, 13:11:45) [MSC v.1310 32 bit (Intel)]
installed Modules and softwares:pydot,graphviz.
command:interwiki.py -lang:zh -family:wikipedia "" -autonomous
It cannot write pictures and return these error:
======Aborted processing [[zh:]]======
Exception in thread Thread-2:
Traceback (most recent call last):
File "C:\Python25\lib\threading.py", line 486, in __bootstrap_inner
self.run()
File "D:\My Documents\SOURCE\pybot\trunk\pywikipedia\interwiki_graph.py", line
36, in run
if self.graph.write(filename, prog = 'dot', format = format):
File "build\bdist.win32\egg\pydot.py", line 1696, in write
dot_fd.write(self.create(prog, format))
File "build\bdist.win32\egg\pydot.py", line 1796, in create
status, stderr_output) )
InvocationException: Program terminated with status: 69. stderr follows: Error:
c:\docume~1\admini~1\locals~1\temp\tmpyfxn5k:2: syntax error near line 2
context: "he:??? ???" >>> [URL=http: <<< //he.wikipedia.org/w/index.php
?useskin=monobook&title=D70X1.370093P-10191D7%D7%D7%D70X1.2F7000P-10228_D70X1.32
BA07P-10194D70X1.01DEF0P+6848D7%D7%D7D&redirect=no, shape=rectangle, fontsize=11
, style=filled, fillcolor=white];
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999787&group_…
Bugs item #1999637, was opened at 2008-06-22 01:12
Message generated for change (Comment added) made by melancholie
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999637&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: other
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Melancholie (melancholie)
Assigned to: Nobody/Anonymous (nobody)
>Summary: Add hsb and sk summary translation for featured.py
Initial Comment:
Add the following line to the summary array:
'sk': u'Bot: [[%s:%s]] je najlep lnok',
See
http://de.wikipedia.org/wiki/Benutzer_Diskussion:Melancholie#sk_wiki
----------------------------------------------------------------------
>Comment By: Melancholie (melancholie)
Date: 2008-06-22 02:13
Message:
Logged In: YES
user_id=2089773
Originator: YES
Also add the summary for hsb:
'hsb': u'Bot: [[%s:%s]] je wubrny nastawk',
See
http://hsb.wikipedia.org/wiki/Diskusija_z_wu%C5%BEiwarjom:MelancholieBot#Te…
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999637&group_…
Bugs item #1999637, was opened at 2008-06-22 01:12
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999637&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: other
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Melancholie (melancholie)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add sk summary for featured.py
Initial Comment:
Add the following line to the summary array:
'sk': u'Bot: [[%s:%s]] je najlep lnok',
See
http://de.wikipedia.org/wiki/Benutzer_Diskussion:Melancholie#sk_wiki
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999637&group_…
Bugs item #1999239, was opened at 2008-06-21 02:32
Message generated for change (Comment added) made by wikipedian
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999239&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Closed
Resolution: Fixed
Priority: 9
Private: No
Submitted By: Daniel Herding (wikipedian)
Assigned to: Nobody/Anonymous (nobody)
Summary: Blocking bot account doesn't stop the bot run
Initial Comment:
There is a very serious bug in the current version. If someone blocks your bot account, the bot just keeps on running. It prints this message:
WARNING: Your account on wikipedia:de is blocked. Editing using this account will stop the run.
But then it doesn't stop. Instead, it will try to save the page, fail, and happily continue using the sysop account. Sooner or later, someone will also block your sysop account for a few minutes. PyWikipedia then shows this warning:
WARNING: Your sysop account on wikipedia:de is blocked. Editing using this account will stop the run.
Again, it will happily continue, of course failing on each page. After a few minutes, the block will run out, and the bot will continue to make changes.
As far as I can tell, the problem is this: In _getEditPage(), there is this code, which would be responsible for stopping the bot:
if self.site().isBlocked():
raise UserBlocked(self.site(), self.aslink(forceInterwiki = True))
But it looks like _getEditPage() isn't even called, so this check doesn't even happen.
I don't know who is responsible for this, but this is a real pain in the ass, and it needs to be fixed ASAP.
----
Pywikipedia [svn+ssh] wikipedian@trunk/pywikipedia (r5595, Jun 20 2008, 18:30:58)
Python 2.5.1 (r251:54863, Mar 7 2008, 04:10:12)
[GCC 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)]
----------------------------------------------------------------------
>Comment By: Daniel Herding (wikipedian)
Date: 2008-06-21 11:48
Message:
Logged In: YES
user_id=880694
Originator: YES
Thanks for the prompt reaction.
----------------------------------------------------------------------
Comment By: Rotem Liss (rotemliss)
Date: 2008-06-21 11:29
Message:
Logged In: YES
user_id=1327030
Originator: NO
Fixed in r5602 by adding block checks for each action.
----------------------------------------------------------------------
Comment By: NicDumZ Nicolas Dumazet (nicdumz)
Date: 2008-06-21 08:59
Message:
Logged In: YES
user_id=1963242
Originator: NO
Yes, I had suffered the same bug in november (no sysop account was
involved, though), and even with the commit access, I forgot to fix it :(
Now, every action (move, delete, edit, and so on), call _getActionUser,
which itself calls isAllowed. What about raising an error here
if(self._isBlocked[index]) ?
----------------------------------------------------------------------
Comment By: Daniel Herding (wikipedian)
Date: 2008-06-21 02:42
Message:
Logged In: YES
user_id=880694
Originator: YES
Please note that Nicolas Dumazet already written about this on the mailing
list on 2007-11-12: "[Pywikipedia-l] Shouldn't bots stop trying to edit
when blocked ??!"
I don't know if he already suffered from the same bug that I described,
but if he did, then it's a real shame that it hasn't been fixed for more
than a half year.
----------------------------------------------------------------------
Comment By: Daniel Herding (wikipedian)
Date: 2008-06-21 02:38
Message:
Logged In: YES
user_id=880694
Originator: YES
I have now committed a workaround for this bug; it raises a UserBlocked
exception already in _getUserData(), not only in _getEditPage(). This is
not a nice solution, but we cannot tolerate bots which ignore being
blocked.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1999239&group_…
Revision: 5603
Author: rotem
Date: 2008-06-21 09:36:08 +0000 (Sat, 21 Jun 2008)
Log Message:
-----------
Check blocks in more places.
Modified Paths:
--------------
trunk/pywikipedia/wikipedia.py
Modified: trunk/pywikipedia/wikipedia.py
===================================================================
--- trunk/pywikipedia/wikipedia.py 2008-06-21 09:29:09 UTC (rev 5602)
+++ trunk/pywikipedia/wikipedia.py 2008-06-21 09:36:08 UTC (rev 5603)
@@ -1343,6 +1343,8 @@
continue
# If it has gotten this far then we should reset dblagged
dblagged = False
+ # Check blocks
+ self.site().checkBlocks(sysop = sysop)
# A second text area means that an edit conflict has occured.
if 'id=\'wpTextbox2\' name="wpTextbox2"' in data:
raise EditConflict(u'An edit conflict has occured.')
@@ -2070,6 +2072,7 @@
output(u'Page %s moved to %s' % (self.title(), newtitle))
return True
else:
+ self.site().checkBlocks(sysop = sysop)
if self.site().mediawiki_message('articleexists') in data or self.site().mediawiki_message('delete_and_move') in data:
if safe:
output(u'Page move failed: Target page [[%s]] already exists.' % newtitle)
@@ -2160,6 +2163,7 @@
else:
response, data = self.site().postForm(address, predata, sysop = True)
if data:
+ self.site().checkBlocks(sysop = sysop)
if self.site().mediawiki_message('actioncomplete') in data:
output(u'Page %s deleted' % self.aslink(forceInterwiki = True))
return True
@@ -2392,6 +2396,7 @@
return True
else:
#Normally, we expect a 302 with no data, so this means an error
+ self.site().checkBlocks(sysop = sysop)
output(u'Failed to change protection level of page %s:'
% self.aslink())
output(u"HTTP response code %s" % response.status)