Pywikipedia-l February 2008

pywikipedia-l@lists.wikimedia.org

22 participants
382 discussions

[ pywikipediabot-Bugs-1870511 ] interwiki in <noinclude> in tempaltes
by SourceForge.net 07 Feb '08

07 Feb '08

Bugs item #1870511, was opened at 2008-01-13 12:48 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1870511&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: interwiki Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: JAn (jandudik) Assigned to: Nobody/Anonymous (nobody) Summary: interwiki in <noinclude> in tempaltes Initial Comment: There is one BIG BUG: in templates interwiki must be in <noinclude> tags, otherwise is in all articles the template is in. If there exists at least one interwiki ling in this tags, is it OK. But if there is no interwiki link yet, interwiki links are added to the end of template. I have many messages from upsetted users, tat my bot added interwiki to some template. Now the only solution is to run bot with -localonly ... ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-02-07 01:13 Message: Logged In: NO This is an ever-lasting and annoying bug, see "[ 1710764 ] interwiki's on template", "[ 1729765 ] interwiki.py: templates with <noinclude>" May somebody finally fix it? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1870511&group_…

1 0

SVN: [4985] trunk/pywikipedia/noreferences.py
by siebrand＠svn.wikimedia.org 06 Feb '08

06 Feb '08

Revision: 4985 Author: siebrand Date: 2008-02-06 19:07:39 +0000 (Wed, 06 Feb 2008) Log Message: ----------- Update by Betacommand * reconfigured the template detection * added more en.wp templates Modified Paths: -------------- trunk/pywikipedia/noreferences.py Modified: trunk/pywikipedia/noreferences.py =================================================================== --- trunk/pywikipedia/noreferences.py 2008-02-06 16:21:18 UTC (rev 4984) +++ trunk/pywikipedia/noreferences.py 2008-02-06 19:07:39 UTC (rev 4985) @@ -36,6 +36,8 @@ import wikipedia, pagegenerators, catlib import editarticle import re, sys +global mysite +mysite =wikipedia.getSite() # This is required for the text that is shown when you run this script # with the parameter -help. @@ -141,7 +143,9 @@ # on your wiki, you don't have to enter anything here. referencesTemplates = { 'wikipedia': { - 'en': [u'Reflist'], + 'en': [u'Reflist',u'Refs',u'FootnotesSmall',u'Reference', + u'Ref-list',u'Reference list',u'References-small',u'Reflink', + u'Footnotes',u'FootnotesSmall'], 'ja': [u'Reflist'], 'lt': [u'Reflist', u'Ref', u'Litref'], 'zh': [u'Reflist'], @@ -177,7 +181,7 @@ def __init__(self, generator, always = False): self.generator = generator self.always = always - + mysite = wikipedia.getSite() self.refR = re.compile('</ref>', re.IGNORECASE) self.referencesR = re.compile('<references */>', re.IGNORECASE) try: @@ -202,10 +206,15 @@ wikipedia.output(u'No changes necessary: references tag found.') return False else: - for template in page.templates(): - if template in self.referencesTemplates: - wikipedia.output(u'No changes necessary: references template found.') - return False + templateR ='' + part = '\{\{(' + for template in self.referencesTemplates: + templateR += part + template + part = '|' + templateR+=')' + if re.search(templateR,oldTextCleaned,re.I): + wikipedia.output(u'No changes necessary: references template found.') + return False wikipedia.output(u'Found ref without references.') return True except wikipedia.NoPage: @@ -236,7 +245,7 @@ index = match.end() else: wikipedia.output(u'Adding references tag to existing %s section...\n' % section) - newText = oldText[:match.end()] + u'\n<references />\n' + oldText[match.end():] + newText = oldText[:match.end()] + u'\n<references/>\n' + oldText[match.end():] self.save(page, newText) return else: @@ -289,7 +298,7 @@ def createReferenceSection(self, page, index): oldText = page.get() - newSection = u'\n== %s ==\n\n<references />\n' % wikipedia.translate(page.site(), referencesSections)[0] + newSection = u'\n== %s ==\n\n<references/>\n' % wikipedia.translate(page.site(), referencesSections)[0] newText = oldText[:index] + newSection + oldText[index:] self.save(page, newText) @@ -299,7 +308,7 @@ """ wikipedia.showDiff(page.get(), newText) if not self.always: - choice = wikipedia.inputChoice(u'Do you want to accept these changes?', ['Yes', 'No', 'Always yes'], ['y', 'N', 'a'], 'N') + choice = wikipedia.inputChoice(u'Do you want to accept these changes?', ['Yes', 'No', 'Always yes'], ['y', 'N', 'a'], 'Y') if choice == 'n': return elif choice == 'a': @@ -307,7 +316,9 @@ if self.always: try: - page.put(newText) + page.put_async(newText) + if mysite.messages: + wikipedia.crash() except wikipedia.EditConflict: wikipedia.output(u'Skipping %s because of edit conflict' % (page.title(),)) except wikipedia.SpamfilterError, e: @@ -317,15 +328,26 @@ else: # Save the page in the background. No need to catch exceptions. page.put_async(newText) + path = mysite.put_address('Non-existing_page') + text = mysite.getUrl(path) + if '<div class="usermessage">' in text: + output(u'NOTE: You have unread messages on %s' % self) + wikipedia.crash() return def run(self): + mysite =wikipedia.getSite() comment = wikipedia.translate(wikipedia.getSite(), msg) wikipedia.setAction(comment) for page in self.generator: if self.lacksReferences(page): self.addReferences(page) + path = mysite.put_address('Non-existing_page') + text = mysite.getUrl(path) + if '<div class="usermessage">' in text: + output(u'NOTE: You have unread messages on %s' % self) + wikipedia.crash() def main(): #page generator @@ -372,7 +394,7 @@ else: if namespaces != []: gen = pagegenerators.NamespaceFilterPageGenerator(gen, namespaces) - preloadingGen = pagegenerators.PreloadingGenerator(gen) + preloadingGen = pagegenerators.PreloadingGenerator(gen,pageNumber=500) bot = NoReferencesBot(preloadingGen, always = always) bot.run()

1 0

SVN: [4984] branches/rewrite/pywikibot
by russblau＠svn.wikimedia.org 06 Feb '08

06 Feb '08

Revision: 4984 Author: russblau Date: 2008-02-06 16:21:18 +0000 (Wed, 06 Feb 2008) Log Message: ----------- Update docu and tests; add PageGenerator object in api.py Modified Paths: -------------- branches/rewrite/pywikibot/data/api.py branches/rewrite/pywikibot/data/http.py branches/rewrite/pywikibot/data/threadedhttp.py branches/rewrite/pywikibot/tests/api_tests.py branches/rewrite/pywikibot/tests/dummy.py Removed Paths: ------------- branches/rewrite/pywikibot/data/test.py Modified: branches/rewrite/pywikibot/data/api.py =================================================================== --- branches/rewrite/pywikibot/data/api.py 2008-02-06 14:09:28 UTC (rev 4983) +++ branches/rewrite/pywikibot/data/api.py 2008-02-06 16:21:18 UTC (rev 4984) @@ -3,7 +3,7 @@ Interface functions to Mediawiki's api.php """ # -# (C) Pywikipedia bot team, 2007 +# (C) Pywikipedia bot team, 2007-08 # # Distributed under the terms of the MIT license. # @@ -17,10 +17,13 @@ import traceback import time import urllib +# TODO - replace when Page object is written +from pywikibot.tests.dummy import TestPage as Page lagpattern = re.compile(r"Waiting for [\d.]+: (?P<lag>\d+) seconds? lagged") + class APIError(Exception): """The wiki site returned an error message.""" def __init__(self, code, info, **kwargs): @@ -43,36 +46,45 @@ Attributes of this object (except for the special parameters listed below) get passed as commands to api.php, and can be get or set using - the dict interface. All attributes must be strings (unicode). - Attributes supplied without values are passed to the API as keys. + the dict interface. All attributes must be strings (or unicode). Use + an empty string for parameters that don't require a value (e.g., + "action=query&...&redirects"). @param site: The Site to which the request will be submitted. If not supplied, uses the user's configured default Site. - @param format: (optional) Defaults to "json" @param max_retries: (optional) Maximum number of times to retry after errors, defaults to 25 @param retry_wait: (optional) Minimum time to wait after an error, defaults to 5 seconds (doubles each retry until max of 120 is reached) + @param format: (optional) Defaults to "json" Example: >>> r = Request(site=mysite, action="query", meta="userinfo") >>> # This is equivalent to >>> # http://[path]/api.php?action=query&meta=userinfo&format=json + >>> # r.data is undefined until request is submitted + >>> print r.data + Traceback (most recent call last): + ... + AttributeError: Request instance has no attribute 'data' >>> # change a parameter >>> r['meta'] = "userinfo|siteinfo" >>> # add a new parameter >>> r['siprop'] = "namespaces" >>> r.params - {'action': 'query', 'meta': 'userinfo|siteinfo', 'siprop': 'namespaces', - 'format': 'json'} + {'action': 'query', 'meta': 'userinfo|siteinfo', 'maxlag': '5', 'siprop': 'namespaces', 'format': 'json'} >>> data = r.submit() >>> type(data) - <type 'dict'> + <type 'dict'> + >>> data.keys() + [u'query'] + >>> data[u'query'].keys() + [u'userinfo', u'namespaces'] """ - def __init__(self, *args, **kwargs): + def __init__(self, **kwargs): self.site = kwargs.pop("site", None) # else use defaultSite() ... when written self.max_retries = kwargs.pop("max_retries", 25) @@ -81,8 +93,8 @@ if "format" not in kwargs: self.params["format"] = "json" if "maxlag" not in kwargs: - self.params["maxlag"] = "5" - self.update(*args, **kwargs) + self.params["maxlag"] = "5" # replace with configurable constant? + self.update(**kwargs) # implement dict interface def __getitem__(self, key): @@ -106,13 +118,6 @@ def iteritems(self): return self.params.iteritems() - def update(self, *args, **kwargs): - """Update the request parameters""" - self.params.update(kwargs) - for arg in args: - if arg not in self.params: - self.params[arg] = "" - def submit(self): """Submit a query and parse the response. @@ -163,6 +168,9 @@ {'data': result}) if "error" not in result: return result + if "*" in result["error"]: + # help text returned + result['error']['help'] = result['error'].pop("*") code = result["error"].pop("code", "Unknown") info = result["error"].pop("info", None) if code == "maxlag": @@ -172,25 +180,90 @@ "Pausing due to database lag: " + info) self.wait(int(lag.group("lag"))) continue + if code in (u'internal_api_error_DBConnectionError', ): + self.wait() + continue # raise error - raise APIError(code, info, **result["error"]) + try: + raise APIError(code, info, **result["error"]) + except TypeError: + raise RuntimeError(result) - def wait(self, lag=None): """Determine how long to wait after a failed request.""" self.max_retries -= 1 if self.max_retries < 0: raise TimeoutError("Maximum retries attempted without success.") - + + wait = self.retry_wait if lag is not None: if lag > 2 * self.retry_wait: - self.retry_wait = min(120, lag // 2) + wait = min(120, lag // 2) logging.warn("Waiting %s seconds before retrying." % self.retry_wait) - time.sleep(self.retry_wait) + time.sleep(wait) self.retry_wait = min(120, self.retry_wait * 2) + + +class PageGenerator(object): + """Iterator for response to a request of type action=query&generator=foo.""" + def __init__(self, generator="", **kwargs): + """ + Required and optional parameters are as for C{Request}, except that + action=query is assumed and generator is required. + @param generator: the "generator=" type from api.php + @type generator: str + """ + if not generator: + raise ValueError("generator argument is required.") + self.request = Request(action="query", generator=generator, **kwargs) + self.generator = generator + self.site = self.request.site + + def __iter__(self): + """Iterate Page objects for pages found in response.""" + while True: + # following "if" is used for testing with plugged-in data; it wouldn't + # be needed for actual usage + if not hasattr(self, "data"): + self.data = self.request.submit() + if not self.data or not isinstance(self.data, dict): + raise StopIteration + if not "query" in self.data: + raise StopIteration + query = self.data["query"] + if not "pages" in query: + raise StopIteration + # TODO: instead of "yield Page", yield a Page returned by a + # method that converts the dict info to a Page object + if isinstance(query["pages"], dict): + for v in query["pages"].itervalues(): + yield Page(self.site, v['title']) + elif isinstance(query["pages"], list): + for v in query["pages"]: + yield Page(self.site, v['title']) + else: + raise APIError("Unknown", + "Unknown format in ['query']['pages'] value.", + data=query["pages"]) + if not "query-continue" in self.data: + return + if not self.generator in self.data["query-continue"]: + raise APIError("Unknown", + "Missing '%s' key in ['query-continue'] value.", + data=self.data["query-continue"]) + self.request.update(self.data["query-continue"][self.generator]) + del self.data + + if __name__ == "__main__": - from pywikibot.tests.dummy import TestSite as Site + from pywikibot.tests.dummy import TestSite as Site, TestPage as Page mysite = Site("en.wikipedia.org") logging.getLogger().setLevel(logging.DEBUG) + def _test(): + import doctest + doctest.testmod() + _test() + + Modified: branches/rewrite/pywikibot/data/http.py =================================================================== --- branches/rewrite/pywikibot/data/http.py 2008-02-06 14:09:28 UTC (rev 4983) +++ branches/rewrite/pywikibot/data/http.py 2008-02-06 16:21:18 UTC (rev 4984) @@ -5,12 +5,11 @@ This module handles communication between the bot and the HTTP threads. This module is responsible for - -- Setting up a connection pool -- Providing a (blocking) interface for HTTP requests -- Translate site objects with query strings into urls -- Urlencoding all data -- Basic HTTP error handling + - Setting up a connection pool + - Providing a (blocking) interface for HTTP requests + - Translate site objects with query strings into urls + - Urlencoding all data + - Basic HTTP error handling """ # @@ -58,10 +57,13 @@ atexit.register(_flush) def request(site, uri, *args, **kwargs): - """ @param site The Site to connect to - All other parameters are the same as L{httplib2.Http.request}, but - the uri is relative - @return The received data (a unicode string). + """Queue a request to be submitted to Site. + + All parameters not listed below are the same as + L{httplib2.Http.request}, but the uri is relative + + @param site: The Site to connect to + @return: The received data (a unicode string). """ baseuri = "%s://%s/" % (site.protocol(), site.hostname()) uri = urlparse.urljoin(baseuri, uri) Deleted: branches/rewrite/pywikibot/data/test.py =================================================================== --- branches/rewrite/pywikibot/data/test.py 2008-02-06 14:09:28 UTC (rev 4983) +++ branches/rewrite/pywikibot/data/test.py 2008-02-06 16:21:18 UTC (rev 4984) @@ -1,41 +0,0 @@ -# -*- coding: utf-8 -*- -""" -Set of test suites for the data module. -""" -# -# (C) Pywikipedia bot team, 2007 -# -# Distributed under the terms of the MIT license. -# -__version__ = '$Id: $' - - -import unittest -import http, api - - -class HTTPTest(unittest.TestCase): - - def setUp(self): - self.HTTP = http.HTTP(None) #TODO: Replace None with an actual Site object once implemented - - def testGETMainPage(self): - """GETting the Main Page should give a HTTP 200 response.""" - status, data = self.HTTP.GET('/w/index.php', {'title' : 'Main_Page'}) - self.assertEqual(status, 200) - - -class APITest(unittest.TestCase): - - def setUp(self): - self.API = api.API(None) #TODO: Replace None with an actual Site object once implemented - - def testEmptyQuery(self): - """Querying for nothing should return an empty list.""" - status, data = self.API.query() - self.assertEqual(status, 200) - self.assertEqual(data, '[]') - - -if __name__ == '__main__': - unittest.main() Modified: branches/rewrite/pywikibot/data/threadedhttp.py =================================================================== --- branches/rewrite/pywikibot/data/threadedhttp.py 2008-02-06 14:09:28 UTC (rev 4983) +++ branches/rewrite/pywikibot/data/threadedhttp.py 2008-02-06 16:21:18 UTC (rev 4984) @@ -1,11 +1,11 @@ # -*- coding: utf-8 -*- """ Httplib2 threaded cookie layer -This class extends Httplib2, adding support for: -- Cookies, guarded for cross-site redirects -- Thread safe ConnectionPool and LockableCookieJar classes -- HttpProcessor thread class -- HttpRequest object +This class extends httplib2, adding support for: + - Cookies, guarded for cross-site redirects + - Thread safe ConnectionPool and LockableCookieJar classes + - HttpProcessor thread class + - HttpRequest object """ @@ -36,13 +36,14 @@ class ConnectionPool(object): - """A thread-safe connection pool. + """A thread-safe connection pool.""" + + def __init__(self, maxnum=5): + """ + @param maxnum: Maximum number of connections per identifier. + The pool drops excessive connections added. - @param maxnum: Maximum number of connections per identifier. - The pool drops excessive connections added. - - """ - def __init__(self, maxnum=5): + """ self.connections = {} self.lock = threading.Lock() self.maxnum = maxnum @@ -98,7 +99,7 @@ self.lock.release() class LockableCookieJar(cookielib.CookieJar): - """ CookieJar with integrated Lock object """ + """CookieJar with integrated Lock object.""" def __init__(self, *args, **kwargs): cookielib.CookieJar.__init__(self, *args, **kwargs) self.lock = threading.Lock() @@ -109,15 +110,17 @@ Overrides httplib2's internal redirect support to prevent cookies being eaten by the wrong sites. - @param cookiejar: (optional) CookieJar to use. A new one will be used - when not supplied. - @param connection_pool: (optional) Connection pool to use. A new one - will be used when not supplied. - @param max_redirects: (optional) The maximum number of redirects to - follow. 5 is default. - """ def __init__(self, *args, **kwargs): + """ + @param cookiejar: (optional) CookieJar to use. A new one will be + used when not supplied. + @param connection_pool: (optional) Connection pool to use. A new one + will be used when not supplied. + @param max_redirects: (optional) The maximum number of redirects to + follow. 5 is default. + + """ self.cookiejar = kwargs.pop('cookiejar', LockableCookieJar()) self.connection_pool = kwargs.pop('connection_pool', ConnectionPool()) self.max_redirects = kwargs.pop('max_redirects', 5) @@ -268,6 +271,7 @@ """ def __init__(self, *args, **kwargs): + """See C{Http.request} for parameters.""" self.args = args self.kwargs = kwargs self.data = None @@ -275,17 +279,17 @@ class HttpProcessor(threading.Thread): - """ Thread object to spawn multiple HTTP connection threads. + """Thread object to spawn multiple HTTP connection threads.""" + def __init__(self, queue, cookiejar, connection_pool): + """ + @param queue: The C{Queue.Queue} object that contains L{HttpRequest} + objects. + @param cookiejar: The C{LockableCookieJar} cookie object to share among + requests. + @param connection_pool: The C{ConnectionPool} object which contains + connections to share among requests. - @param queue: The C{Queue.Queue} object that contains L{HttpRequest} - objects. - @param cookiejar: The C{LockableCookieJar} cookie object to share among - requests. - @param connection_pool: The C{ConnectionPool} object which contains - connections to share among requests. - - """ - def __init__(self, queue, cookiejar, connection_pool): + """ threading.Thread.__init__(self) self.queue = queue self.http = Http(cookiejar=cookiejar, connection_pool=connection_pool) @@ -305,7 +309,7 @@ if item.lock: item.lock.release() - + # Metaweb Technologies, Inc. License: # ======================================================================== # The following dummy classes are: Modified: branches/rewrite/pywikibot/tests/api_tests.py =================================================================== --- branches/rewrite/pywikibot/tests/api_tests.py 2008-02-06 14:09:28 UTC (rev 4983) +++ branches/rewrite/pywikibot/tests/api_tests.py 2008-02-06 16:21:18 UTC (rev 4984) @@ -1,7 +1,7 @@ import unittest import pywikibot.data.api as api -from pywikibot.tests.dummy import TestSite as Site +from pywikibot.tests.dummy import TestSite as Site, TestPage as Page mysite = Site('en.wikipedia.org') @@ -9,7 +9,7 @@ def testObjectCreation(self): """Test that api.Request() creates an object with desired attributes""" - req = api.Request(mysite, "foo", bar="test") + req = api.Request(site=mysite, foo="", bar="test") self.assert_(req) self.assertEqual(req.site, mysite) self.assert_("foo" in req.params) @@ -18,7 +18,52 @@ # test item assignment req["one"] = "1" self.assertEqual(req.params['one'], "1") + # test compliance with dict interface + # req.keys() should contain "foo", "bar", "format", "maxlag", "one" + self.assertEqual(len(req.keys()), 5) + self.assert_("test" in req.values()) + self.assert_(all(len(item) == 2 for item in req.items())) + +class TestListGenerator(unittest.TestCase): + def setUp(self): + self.gen = api.PageGenerator(site=mysite, + generator="links", + titles="User:R'n'B") + # following test data is copied from an actual api.php response + self.gen.data = { + "query": {"pages": {"296589": {"pageid": 296589, + "ns": 0, + "title": "Broadcaster.com" + }, + "13918157": {"pageid": 13918157, + "ns": 0, + "title": "Broadcaster (definition)" + }, + "156658": {"pageid": 156658, + "ns": 0, + "title": "Wiktionary" + }, + "47757": {"pageid": 47757, + "ns": 4, + "title": "Wikipedia:Disambiguation" + } + } + } + } + + def testGeneratorResults(self): + """Test that PageGenerator yields pages with expected attributes.""" + titles = ["Broadcaster.com", "Broadcaster (definition)", + "Wiktionary", "Wikipedia:Disambiguation"] + results = [p for p in self.gen] + self.assertEqual(len(results), 4) + for page in results: + self.assertEqual(type(page), Page) + self.assertEqual(page.site(), mysite) + self.assert_(page.title() in titles) + + if __name__ == '__main__': try: unittest.main() Modified: branches/rewrite/pywikibot/tests/dummy.py =================================================================== --- branches/rewrite/pywikibot/tests/dummy.py 2008-02-06 14:09:28 UTC (rev 4983) +++ branches/rewrite/pywikibot/tests/dummy.py 2008-02-06 16:21:18 UTC (rev 4984) @@ -32,7 +32,6 @@ def __init__(self, site, title): self._site = site self._title = title - def site(self): return self._site def title(self):

1 0

[ pywikipediabot-Bugs-1887935 ] wikipedia.templatesWithParams
by SourceForge.net 06 Feb '08

06 Feb '08

Bugs item #1887935, was opened at 2008-02-06 15:34 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887935&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: giurrero (giurrero) Assigned to: Nobody/Anonymous (nobody) Summary: wikipedia.templatesWithParams Initial Comment: bug in function wikipedia.templatesWithParams ==== page.get() === {{MyTemplate |field1 = value1 |field2 = [[value2|two]] }} ============= page.templatesWithParams() expected: [(u'MyTemplate', [u'field1 = value1\n', u'field2 = [[value2|two]]\n'])] got: [(u'MyTemplate', [u'field1 = value1\n', u'field2 = [[value2', u'two]]\n'])] ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887935&group_…

1 0

[ pywikipediabot-Bugs-1887631 ] All codes down by wikipedia.py
by SourceForge.net 06 Feb '08

06 Feb '08

Bugs item #1887631, was opened at 2008-02-06 01:25 Message generated for change (Comment added) made by russblau You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887631&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex S.H. Lin (lin4h) Assigned to: Nobody/Anonymous (nobody) Summary: All codes down by wikipedia.py Initial Comment: Traceback (most recent call last): File "redirect.py", line 38, in <module> import wikipedia, config File "D:\My Documents\SOURCE\mwbot\pywikipedia\wikipedia.py", line 5528, in <m odule> writeToCommandLogFile() File "D:\My Documents\SOURCE\mwbot\pywikipedia\wikipedia.py", line 5507, in wr iteToCommandLogFile s = u' '.join(args) TypeError: sequence item 0: expected string or Unicode, NoneType found OS:WinXP SP2 ---------------------------------------------------------------------- >Comment By: Russell Blau (russblau) Date: 2008-02-06 09:12 Message: Logged In: YES user_id=855050 Originator: NO Fixed in r4983; this bug was introduced by r4980 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887631&group_…

1 0

SVN: [4983] trunk/pywikipedia/wikipedia.py
by russblau＠svn.wikimedia.org 06 Feb '08

06 Feb '08

Revision: 4983 Author: russblau Date: 2008-02-06 14:09:28 +0000 (Wed, 06 Feb 2008) Log Message: ----------- Fix critical bug #1887631 Modified Paths: -------------- trunk/pywikipedia/wikipedia.py Modified: trunk/pywikipedia/wikipedia.py =================================================================== --- trunk/pywikipedia/wikipedia.py 2008-02-05 18:13:45 UTC (rev 4982) +++ trunk/pywikipedia/wikipedia.py 2008-02-06 14:09:28 UTC (rev 4983) @@ -444,6 +444,7 @@ """ title = self._title if savetitle: # Ensure there's no wiki syntax in the title + # FIXME: this makes no sense if title.find("''") > -1: try: title = urllib.quote(title).replace('%20',' ') @@ -5208,6 +5209,8 @@ # Central/Eastern European Windows versions give parameters encoded # as windows-1250 even though the console encoding is cp852. return unicode(arg, 'windows-1250') + else: + return unicode(arg, config.console_encoding) else: # Linux uses the same encoding for both. # I don't know how non-Western Windows versions behave.

1 0

[ pywikipediabot-Bugs-1887631 ] All codes down by wikipedia.py
by SourceForge.net 06 Feb '08

06 Feb '08

Bugs item #1887631, was opened at 2008-02-06 14:25 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887631&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex S.H. Lin (lin4h) Assigned to: Nobody/Anonymous (nobody) Summary: All codes down by wikipedia.py Initial Comment: Traceback (most recent call last): File "redirect.py", line 38, in <module> import wikipedia, config File "D:\My Documents\SOURCE\mwbot\pywikipedia\wikipedia.py", line 5528, in <m odule> writeToCommandLogFile() File "D:\My Documents\SOURCE\mwbot\pywikipedia\wikipedia.py", line 5507, in wr iteToCommandLogFile s = u' '.join(args) TypeError: sequence item 0: expected string or Unicode, NoneType found OS:WinXP SP2 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887631&group_…

1 0

[ pywikipediabot-Bugs-1887151 ] getUrl crashes when lent(text) does not match content-length
by SourceForge.net 05 Feb '08

05 Feb '08

Bugs item #1887151, was opened at 2008-02-05 19:54 Message generated for change (Settings changed) made by rotemliss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887151&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: NicDumZ — Nicolas Dumazet (nicdumz) Assigned to: Nobody/Anonymous (nobody) Summary: getUrl crashes when lent(text) does not match content-length Initial Comment: I was running my script in a virtual console, so I can't copy/paste the stack dump here. However, it was, roughly : Warning! len(text) does not match content-length: 9789 != 13259 Traceback: page.get() in my script -> wikipedia.py:607 -> wikipedia.py:656 -> wikipedia.py:4038 : "self.conn.close()" AttributeError: 'Site' object has no attribute 'conn' This came from the old persistant_http config, a patch is included. Cheers ! Nicolas Dumazet — NicDumZ. ---------------------------------------------------------------------- >Comment By: Rotem Liss (rotemliss) Date: 2008-02-05 20:20 Message: Logged In: YES user_id=1327030 Originator: NO Fixed in r4982. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887151&group_…

1 0

SVN: [4982] trunk/pywikipedia/wikipedia.py
by rotem＠svn.wikimedia.org 05 Feb '08

05 Feb '08

Revision: 4982 Author: rotem Date: 2008-02-05 18:13:45 +0000 (Tue, 05 Feb 2008) Log Message: ----------- (bug 1887151) getUrl crashes when len(text) does not match content-length Modified Paths: -------------- trunk/pywikipedia/wikipedia.py Modified: trunk/pywikipedia/wikipedia.py =================================================================== --- trunk/pywikipedia/wikipedia.py 2008-02-05 17:43:16 UTC (rev 4981) +++ trunk/pywikipedia/wikipedia.py 2008-02-05 18:13:45 UTC (rev 4982) @@ -4030,11 +4030,12 @@ # Ensure that all sent data is received if int(headers.get('content-length', '0')) != len(text) and 'content-length' in headers: - output(u'Warning! len(text) does not match content-length: %s != %s' % \ - (len(text), headers.get('content-length'))) + output(u'Warning! len(text) does not match content-length: %s != %s' % \ + (len(text), headers.get('content-length'))) + if False: #self.persistent_http self.conn.close() self.conn.connect() - return self.getUrl(path, retry, sysop, data, compress) + return self.getUrl(path, retry, sysop, data, compress) if compress and contentEncoding == 'gzip': text = decompress_gzip(text)

1 0

[ pywikipediabot-Bugs-1887151 ] getUrl crashes when lent(text) does not match content-length
by SourceForge.net 05 Feb '08

05 Feb '08

Bugs item #1887151, was opened at 2008-02-05 18:54 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887151&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: NicDumZ — Nicolas Dumazet (nicdumz) Assigned to: Nobody/Anonymous (nobody) Summary: getUrl crashes when lent(text) does not match content-length Initial Comment: I was running my script in a virtual console, so I can't copy/paste the stack dump here. However, it was, roughly : Warning! len(text) does not match content-length: 9789 != 13259 Traceback: page.get() in my script -> wikipedia.py:607 -> wikipedia.py:656 -> wikipedia.py:4038 : "self.conn.close()" AttributeError: 'Site' object has no attribute 'conn' This came from the old persistant_http config, a patch is included. Cheers ! Nicolas Dumazet — NicDumZ. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1887151&group_…

1 0

← Newer
1
...
30
31
32
33
34
35
36
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

Pywikipedia-l February 2008