Pywikipedia-l October 2008

pywikipedia-l@lists.wikimedia.org

25 participants
195 discussions

SVN: [5927] trunk/pywikipedia/category.py

by cydeweys＠svn.wikimedia.org

Revision: 5927 Author: cydeweys Date: 2008-10-02 02:37:56 +0000 (Thu, 02 Oct 2008) Log Message: ----------- Fixing the Remove robot so that it also deletes a talk page, if one exists. The default behavior of the Removal robot has been altered so that it uses a custom edit summary (if one is given) in preference to the default edit summary when performing a deletion of the category page. This behavior is most likely preferred because a custom edit summary is almost guaranteed to contain information that is more helpful than "Category was disbanded". Modified Paths: -------------- trunk/pywikipedia/category.py Modified: trunk/pywikipedia/category.py =================================================================== --- trunk/pywikipedia/category.py 2008-10-01 21:00:43 UTC (rev 5926) +++ trunk/pywikipedia/category.py 2008-10-02 02:37:56 UTC (rev 5927) @@ -31,9 +31,10 @@ * -summary: - Pick a custom edit summary for the bot. * -inplace - Use this flag to change categories in place rather than rearranging them. - * -delsum - An option for remove, this specifies to use the custom edit - summary as the deletion reason (rather than a canned - deletion reason) + * -nodelsum - An option for remove, this specifies not to use the custom + edit summary as the deletion reason. Instead, it uses the + default deletion reason for the language, which is "Category + was disbanded" in English. * -overwrite - An option for listify, this overwrites the current page with the list even if something is already there. * -showimages - An option for listify, this displays images rather than @@ -575,7 +576,7 @@ 'zh':u'機器人:移除目錄%s', } - def __init__(self, catTitle, batchMode = False, editSummary = '', useSummaryForDeletion = False, titleRegex = None, inPlace = False): + def __init__(self, catTitle, batchMode = False, editSummary = '', useSummaryForDeletion = True, titleRegex = None, inPlace = False): self.editSummary = editSummary self.cat = catlib.Category(wikipedia.getSite(), 'Category:' + catTitle) # get edit summary message @@ -603,12 +604,16 @@ else: for subcategory in subcategories: catlib.change_category(subcategory, self.cat, None, inPlace = self.inPlace) + # Deletes the category page if self.cat.exists() and self.cat.isEmpty(): - if self.useSummaryForDeletion: + if self.useSummaryForDeletion and self.editSummary: reason = self.editSummary else: reason = wikipedia.translate(wikipedia.getSite(), self.deletion_reason_remove) + talkPage = self.cat.toggleTalkPage() self.cat.delete(reason, not self.batchMode) + if (talkPage.exists()): + talkPage.delete(reason=reason, prompt=not self.batchMode) class CategoryTidyRobot: """ @@ -889,7 +894,7 @@ #If this is set to true then the custom edit summary given for removing #categories from articles will also be used as the deletion reason. - useSummaryForDeletion = False + useSummaryForDeletion = True try: catDB = CategoryDatabase() action = None @@ -923,7 +928,10 @@ elif arg == '-inplace': inPlace = True elif arg == '-delsum': - useSummaryForDeletion = True + # This parameter is kept for historical reasons, as it was not previously the default option. + pass + elif arg == '-nodelsum': + useSummaryForDeletion = False elif arg == '-overwrite': overwrite = True elif arg == '-showimages':

15 years, 7 months

SVN: [5926] branches/rewrite/pywikibot

by russblau＠svn.wikimedia.org

Revision: 5926 Author: russblau Date: 2008-10-01 21:00:43 +0000 (Wed, 01 Oct 2008) Log Message: ----------- more site tests; add handy decorator for methods with deprecated arguments Modified Paths: -------------- branches/rewrite/pywikibot/site.py branches/rewrite/pywikibot/tests/site_tests.py Modified: branches/rewrite/pywikibot/site.py =================================================================== --- branches/rewrite/pywikibot/site.py 2008-10-01 13:36:59 UTC (rev 5925) +++ branches/rewrite/pywikibot/site.py 2008-10-01 21:00:43 UTC (rev 5926) @@ -30,6 +30,32 @@ logger = logging.getLogger("wiki") +def deprecate_arg(old_arg, new_arg): + """Decorator to declare old_arg deprecated and replace it with new_arg""" + def decorator(method): + def wrapper(*__args, **__kw): + meth_name = method.__name__ + if old_arg in __kw: + if new_arg: + if new_arg in __kw: + logger.warn( +"%(new_arg)s argument of %(meth_name)s replaces %(old_arg)s; cannot use both." + % locals()) + else: + logger.debug( +"%(old_arg)s argument of %(meth_name)s is deprecated; use %(new_arg)s instead." + % locals()) + __kw[new_arg] = __kw[old_arg] + else: + logger.debug( + "%(old_arg)s argument of %(meth_name)s is deprecated." + % locals()) + del __kw[old_arg] + return method(*__args, **__kw) + return wrapper + return decorator + + class PageInUse(pywikibot.Error): """Page cannot be reserved for writing due to existing lock.""" @@ -527,8 +553,9 @@ return 'blockinfo' in self._userinfo def isBlocked(self, sysop=False): - """Deprecated; retained for backwards-compatibility""" - logger.debug("Site.isBlocked() method is deprecated; use is_blocked()") + """Deprecated synonym for is_blocked""" + logger.debug( + "Site method 'isBlocked' should be changed to 'is_blocked'") return self.is_blocked(sysop) def has_right(self, right, sysop=False): @@ -917,7 +944,8 @@ namespaces=namespaces) ) - def pagelinks(self, page, namespaces=None, follow_redirects=False): + def pagelinks(self, page, namespaces=None, follow_redirects=False, + limit=None): """Iterate internal wikilinks contained (or transcluded) on page. @param namespaces: Only iterate pages in these namespaces (default: all) @@ -927,6 +955,8 @@ """ plgen = api.PageGenerator("links", site=self) + if isinstance(limit, int): + plgen.limit = limit if hasattr(page, "_pageid"): plgen.request['pageids'] = str(page._pageid) else: @@ -939,13 +969,10 @@ for ns in namespaces) return plgen + @deprecate_arg("withSortKey", None) # Sortkey doesn't work with generator def pagecategories(self, page, withSortKey=None): """Iterate categories to which page belongs.""" - # Sortkey doesn't work with generator; deprecate - if withSortKey is not None: - logger.debug( - "site.pagecategories(): withSortKey option is deprecated") clgen = api.CategoryPageGenerator("categories", site=self) if hasattr(page, "_pageid"): clgen.request['pageids'] = str(page._pageid) @@ -1157,12 +1184,11 @@ for linkdata in pageitem['extlinks']: yield linkdata['*'] - def allpages(self, start="!", prefix="", namespace=0, - filterredir=None, filterlanglinks=None, - minsize=None, maxsize=None, - protect_type=None, protect_level=None, - limit=None, reverse=False, includeRedirects=None, - throttle=None): + @deprecate_arg("throttle", None) + def allpages(self, start="!", prefix="", namespace=0, filterredir=None, + filterlanglinks=None, minsize=None, maxsize=None, + protect_type=None, protect_level=None, limit=None, + reverse=False, includeRedirects=None): """Iterate pages in a single namespace. Note: parameters includeRedirects and throttle are deprecated and @@ -1194,11 +1220,9 @@ """ if not isinstance(namespace, int): raise Error("allpages: only one namespace permitted.") - if throttle is not None: - logger.debug("allpages: the 'throttle' parameter is deprecated.") if includeRedirects is not None: logger.debug( - "allpages: the 'includeRedirects' parameter is deprecated.") +"allpages: 'includeRedirects' argument is deprecated; use 'filterredirs'.") if includeRedirects: if includeRedirects == "only": filterredirs = True @@ -1261,7 +1285,7 @@ @param limit: maximum number of pages to iterate (default: iterate all pages in namespace) @param fromids: if True, include the pageid of the page containing - each link (default: False) as the 'fromid' attribute of the Page; + each link (default: False) as the '_fromid' attribute of the Page; cannot be combined with unique """ @@ -1282,7 +1306,7 @@ for link in algen: p = pywikibot.Page(self, link['title'], link['ns']) if fromids: - p.fromid = link['fromid'] + p._fromid = link['fromid'] yield p def allcategories(self, start="!", prefix="", limit=None, @@ -1585,7 +1609,8 @@ rcgen.request["rcshow"] = "|".join(rcshow) return rcgen - def search(self, searchstring, number=None, namespaces=[0], where="text", + @deprecate_arg("number", "limit") + def search(self, searchstring, namespaces=[0], where="text", getredirects=False, limit=None): """Iterate Pages that contain the searchstring. @@ -1603,9 +1628,6 @@ @param number: deprecated, synonym for 'limit' """ - if number is not None: - logger.debug("search: number parameter is deprecated; use limit") - limit = number if not searchstring: raise Error("search: searchstring cannot be empty") if where not in ("text", "titles"): Modified: branches/rewrite/pywikibot/tests/site_tests.py =================================================================== --- branches/rewrite/pywikibot/tests/site_tests.py 2008-10-01 13:36:59 UTC (rev 5925) +++ branches/rewrite/pywikibot/tests/site_tests.py 2008-10-01 21:00:43 UTC (rev 5926) @@ -165,7 +165,7 @@ """Test that preloading works""" count = 0 - for page in mysite.preloadpages(mysite.pagelinks(mainpage)): + for page in mysite.preloadpages(mysite.pagelinks(mainpage, limit=10)): self.assertType(page, pywikibot.Page) self.assertType(page.exists(), bool) if page.exists(): @@ -219,7 +219,8 @@ self.assertTrue(links.issuperset( set(mysite.pagelinks(mainpage, namespaces=[0, 1])))) for target in mysite.preloadpages( - mysite.pagelinks(mainpage, follow_redirects=True)): + mysite.pagelinks(mainpage, follow_redirects=True, + limit=10)): self.assertType(target, pywikibot.Page) self.assertFalse(target.isRedirectPage()) # test pagecategories @@ -254,71 +255,95 @@ def testAllPages(self): """Test the site.allpages() method""" - global ap, ap6, ap7 - ap = list(mysite.allpages(limit=10)) - self.assertTrue(len(ap) <= 10) - for page in ap: + fwd = list(mysite.allpages(limit=10)) + self.assertTrue(len(fwd) <= 10) + for page in fwd: self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertEqual(page.namespace(), 0) - # TODO: test various optional arguments to allpages - ap1 = mysite.allpages(start="Py", limit=10) - for page in ap1: + rev = list(mysite.allpages(reverse=True, start="Aa", limit=12)) + self.assertTrue(len(rev) <= 12) + for page in rev: self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertEqual(page.namespace(), 0) + self.assertTrue(page.title() <= "Aa") + for page in mysite.allpages(start="Py", limit=10): + self.assertType(page, pywikibot.Page) + self.assertTrue(mysite.page_exists(page)) + self.assertEqual(page.namespace(), 0) self.assertTrue(page.title() >= "Py") - ap2 = mysite.allpages(prefix="Pre", limit=10) - for page in ap2: + for page in mysite.allpages(prefix="Pre", limit=10): self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertEqual(page.namespace(), 0) self.assertTrue(page.title().startswith("Pre")) - ap3 = mysite.allpages(namespace=1, limit=10) - for page in ap3: + for page in mysite.allpages(namespace=1, limit=10): self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertEqual(page.namespace(), 1) - ap4= mysite.allpages(filterredir=True, limit=10) - for page in ap4: + for page in mysite.allpages(filterredir=True, limit=10): self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertEqual(page.namespace(), 0) self.assertTrue(page.isRedirectPage()) - ap5= mysite.allpages(filterredir=False, limit=10) - for page in ap5: + for page in mysite.allpages(filterredir=False, limit=10): self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertEqual(page.namespace(), 0) self.assertFalse(page.isRedirectPage()) - ap6= list(mysite.allpages(filterlanglinks=True, limit=10)) - for page in ap6: + for page in mysite.allpages(filterlanglinks=True, limit=10): self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertEqual(page.namespace(), 0) - ap7= list(mysite.allpages(filterlanglinks=False, limit=10)) - for page in ap7: + for page in mysite.allpages(filterlanglinks=False, limit=10): self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertEqual(page.namespace(), 0) - ap8 = mysite.allpages(minsize=100, limit=10) - for page in ap8: + for page in mysite.allpages(minsize=100, limit=10): self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertTrue(len(page.text) >= 100) - ap9 = mysite.allpages(maxsize=200, limit=10) - for page in ap9: + for page in mysite.allpages(maxsize=200, limit=10): self.assertType(page, pywikibot.Page) self.assertTrue(mysite.page_exists(page)) self.assertTrue(len(page.text) <= 200) + for page in mysite.allpages(protect_type="edit", limit=5): + self.assertType(page, pywikibot.Page) + self.assertTrue(mysite.page_exists(page)) + self.assertTrue("edit" in page._protection) + for page in mysite.allpages(protect_type="edit", + protect_level="sysop", limit=5): + self.assertType(page, pywikibot.Page) + self.assertTrue(mysite.page_exists(page)) + self.assertTrue("edit" in page._protection) + self.assertTrue("sysop" in page._protection["edit"]) def testAllLinks(self): """Test the site.alllinks() method""" - al = list(mysite.alllinks(limit=10)) - self.assertTrue(len(al) <= 10) - self.assertTrue(all(isinstance(link, pywikibot.Page) for link in al)) + fwd = list(mysite.alllinks(limit=10)) + self.assertTrue(len(fwd) <= 10) + self.assertTrue(all(isinstance(link, pywikibot.Page) for link in fwd)) + uniq = list(mysite.alllinks(limit=10, unique=True)) + self.assertTrue(all(link in uniq for link in fwd)) # TODO: test various optional arguments to alllinks + for page in mysite.alllinks(start="Link", limit=10): + self.assertType(page, pywikibot.Page) + self.assertEqual(page.namespace(), 0) + self.assertTrue(page.title() >= "Link") + for page in mysite.alllinks(prefix="Fix", limit=10): + self.assertType(page, pywikibot.Page) + self.assertEqual(page.namespace(), 0) + self.assertTrue(page.title().startswith("Fix")) + for page in mysite.alllinks(namespace=1, limit=10): + self.assertType(page, pywikibot.Page) + self.assertEqual(page.namespace(), 1) + for page in mysite.alllinks(start="From", namespace=4, fromids=True, + limit=10): + self.assertType(page, pywikibot.Page) + self.assertTrue(page.title(withNamespace=False) >= "From") + self.assertTrue(hasattr(page, "_fromid")) def testAllCategories(self): """Test the site.allcategories() method"""

15 years, 7 months

[ pywikipediabot-Bugs-2119685 ] interwiki.py does reverts

by SourceForge.net

Bugs item #2119685, was opened at 2008-09-19 18:53 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2119685&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: interwiki Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: interwiki.py does reverts Initial Comment: I got this message. As far as I know is this an old feature, that should be solved a long time ago. At this moment I'm working with revision 5909. But I don't know with which version I did the reverts. For the description of the feature see the message send by someones else that detected this feature. Hello Carsrac, I would like to draw your attention to these edits made by your bot: [http://de.wikipedia.org/w/index.php?title=Auge&diff=48157069&oldid=48020013 article de:Auge] and [http://la.wikipedia.org/w/index.php?title=The_Beatles&diff=562763&oldid=562… article la:The Beatles]. Obviously, the bot didn't edit the version that was at that time the current one, but an older one. That's equivalent to doing a revert. It seems that the bot edited the second last version that had been created by a bot. In these cases that meant a revert of [http://de.wikipedia.org/w/index.php?title=Auge&diff=48157069&oldid=47723213 two versions] of de:Auge and of [http://la.wikipedia.org/w/index.php?title=The_Beatles&diff=562763&oldid=551… 24 versions] of la:The Beatles. How could that happen? Is there any reason to believe this didn't happen more often? I believe these are questions to be well considered since the bot seems to have done several thousand, if not tens of thousands of edits during that time. And it would be very assuring to know that the possibility that this still can or will happen can be ruled out. --[[de:user:Lax]] - [[Gebruiker:88.65.169.226|88.65.169.226]] 19 sep 2008 10:15 (CEST) ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-10-01 20:41 Message: This more likely seems to be the same as [ 1790473 ] Interwiki bot overwrites changes, no edit conflict. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-10-01 20:22 Message: I don't know whether this and "[ 1999895 ] iw bot doesn't detect edit conflict" are the same bug, but here it does not really seem to be an edit conflict. We are talking about 11 and 19 days, repeat DAYS, old versions here. ---------------------------------------------------------------------- Comment By: Carsrac (carsrac) Date: 2008-09-20 01:16 Message: It is the same problem as [ 1999895 ] iw bot doesn't detect edit conflict ---------------------------------------------------------------------- Comment By: NicDumZ Nicolas Dumazet (nicdumz) Date: 2008-09-20 01:07 Message: rciw.py for example *will* trigger this behavior quite often, sometimes working on a version more than 10 hours old. I am not however, able to confirm this on the standard interwiki.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2119685&group_…

15 years, 7 months

[ pywikipediabot-Bugs-2119685 ] interwiki.py does reverts

by SourceForge.net

Bugs item #2119685, was opened at 2008-09-19 18:53 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2119685&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: interwiki Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: interwiki.py does reverts Initial Comment: I got this message. As far as I know is this an old feature, that should be solved a long time ago. At this moment I'm working with revision 5909. But I don't know with which version I did the reverts. For the description of the feature see the message send by someones else that detected this feature. Hello Carsrac, I would like to draw your attention to these edits made by your bot: [http://de.wikipedia.org/w/index.php?title=Auge&diff=48157069&oldid=48020013 article de:Auge] and [http://la.wikipedia.org/w/index.php?title=The_Beatles&diff=562763&oldid=562… article la:The Beatles]. Obviously, the bot didn't edit the version that was at that time the current one, but an older one. That's equivalent to doing a revert. It seems that the bot edited the second last version that had been created by a bot. In these cases that meant a revert of [http://de.wikipedia.org/w/index.php?title=Auge&diff=48157069&oldid=47723213 two versions] of de:Auge and of [http://la.wikipedia.org/w/index.php?title=The_Beatles&diff=562763&oldid=551… 24 versions] of la:The Beatles. How could that happen? Is there any reason to believe this didn't happen more often? I believe these are questions to be well considered since the bot seems to have done several thousand, if not tens of thousands of edits during that time. And it would be very assuring to know that the possibility that this still can or will happen can be ruled out. --[[de:user:Lax]] - [[Gebruiker:88.65.169.226|88.65.169.226]] 19 sep 2008 10:15 (CEST) ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-10-01 20:22 Message: I don't know whether this and "[ 1999895 ] iw bot doesn't detect edit conflict" are the same bug, but here it does not really seem to be an edit conflict. We are talking about 11 and 19 days, repeat DAYS, old versions here. ---------------------------------------------------------------------- Comment By: Carsrac (carsrac) Date: 2008-09-20 01:16 Message: It is the same problem as [ 1999895 ] iw bot doesn't detect edit conflict ---------------------------------------------------------------------- Comment By: NicDumZ Nicolas Dumazet (nicdumz) Date: 2008-09-20 01:07 Message: rciw.py for example *will* trigger this behavior quite often, sometimes working on a version more than 10 hours old. I am not however, able to confirm this on the standard interwiki.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2119685&group_…

15 years, 7 months

SVN: [5925] trunk/pywikipedia/welcome.py

by filnik＠svn.wikimedia.org

Revision: 5925 Author: filnik Date: 2008-10-01 13:36:59 +0000 (Wed, 01 Oct 2008) Log Message: ----------- Applying patch by FiloSottile Modified Paths: -------------- trunk/pywikipedia/welcome.py Modified: trunk/pywikipedia/welcome.py =================================================================== --- trunk/pywikipedia/welcome.py 2008-09-29 21:00:54 UTC (rev 5924) +++ trunk/pywikipedia/welcome.py 2008-10-01 13:36:59 UTC (rev 5925) @@ -85,6 +85,8 @@ -savedata This feature saves the random signature index to allow to continue to welcome with the last signature used. + -sul Welcome the auto-created users (default: False) + ********************************* GUIDE *********************************** Report, Bad and white list guide: @@ -408,7 +410,7 @@ wikipedia.output(u'\nReal-time list loaded.') return list_loaded -def parselog(wsite, raw, talk, number): +def parselog(wsite, raw, talk, number, sul): """ The function to load the users (only users who have a certain number of edits) """ someone_found = False autocreated = wsite.mediawiki_message('newuserlog-autocreate-entry') @@ -427,7 +429,7 @@ someone_found = True username = x.group('user') #skip autocreated users (SUL) - if autocreated in x.group('reason'): + if autocreated in x.group('reason') and not sul: wikipedia.output(u'%s has been created automatically, skipping...' % username) continue userpage = wikipedia.Page(wsite, username) @@ -585,6 +587,7 @@ time_variable = 3600 # how much time (sec.) the bot sleeps before restart log_variable = True # create the welcome log or not ask = False # should bot ask to add username to bad-username list + sul = False # should bot welcome auto-created users filter_wp = False # check if the username is ok or not sign = ' --~~~~' # default signature random = False # should signature be random or not @@ -636,6 +639,8 @@ savedata = True elif arg == '-random': random = True + elif arg == '-sul': + sul = True elif arg.startswith('-limit'): if len(arg) == 6: limit = int(wikipedia.input(u'How many of the latest new users would you like to load?')) @@ -653,7 +658,7 @@ wikipedia.output('WARING: both -offset and -timeoffset were provided, ignoring -offset') offset_variable = 0 return (None, ask, filename, fileOption, fileSignName, filter_wp, limit, log_variable, number, numberlog, offset_variable, random, recursive, - savedata, sign, time_variable, timeoffset_variable) + savedata, sign, time_variable, timeoffset_variable, sul) def main(settingsBot): # Taking the messages inside the function namespace. @@ -683,6 +688,7 @@ sign = settingsBot[14] time_variable = settingsBot[15] timeoffset_variable = settingsBot[16] + sul = settingsBot[17] # The site wsite = wikipedia.getSite() @@ -814,7 +820,7 @@ except wikipedia.NoPage: wikipedia.output(u'The list with signatures is not available... Using default signature...') random = False - for found_result in parselog(wsite, log, talk, number): + for found_result in parselog(wsite, log, talk, number, sul): # Compiling the signature to be used. if random: if number_user + 1 > len(signList):

15 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

Pywikipedia-l October 2008