Multichill created this task. Multichill added a subscriber: Multichill. Multichill added projects: pywikibot-core, Pywikibot-login.py, Pywikibot-compat-to-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION Couldn't figure out why core didn't work on my wiki with LDAP login. After some debugging I found out that lgdomain doesn't seem to be set anywhere at all. See https://www.mediawiki.org/w/api.php?action=help&modules=login%7Cquery+in...
If I just hardcode login_request["lgdomain"] = "mydomain" in api.py, it magically works. The login logic should look in the family file if self.ldapDomain is set and if that's the case include it in the request. Compat doesn't have this problem.
TASK DETAIL https://phabricator.wikimedia.org/T90149
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Multichill Cc: pywikipedia-bugs, Aklapper, Multichill, jayvdb, droid
XZise added a subscriber: XZise. XZise added a comment.
Can we set lgdomain even without LDAP login?
TASK DETAIL https://phabricator.wikimedia.org/T90149
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, Aklapper, Multichill, jayvdb, droid, pywikipedia-bugs
Dumindux claimed this task. Dumindux set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T90149
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Dumindux Cc: XZise, Aklapper, Multichill, jayvdb, droid, pywikipedia-bugs
Dumindux placed this task up for grabs.
TASK DETAIL https://phabricator.wikimedia.org/T90149
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Dumindux Cc: XZise, Aklapper, Multichill, jayvdb, droid, pywikipedia-bugs
jayvdb added a subscriber: jayvdb. jayvdb added a comment.
This is pretty https://phabricator.wikimedia.org/tag/easy/, as it needs to be backwards compatible with compat, so no bikeshedding on names, etc. and it should be two lines of code in core.
compat$ git grep ldapDomain families/README-family.txt: #self.ldapDomain = 'domain here' family.py: self.ldapDomain = () login.py: if self.site.family.ldapDomain: login.py: predata['lgdomain'] = self.site.family.ldapDomain login.py: if self.site.family.ldapDomain: # VistaPrint fix login.py: predata["wpDomain"] = self.site.family.ldapDomain
TASK DETAIL https://phabricator.wikimedia.org/T90149
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, XZise, Aklapper, Multichill, droid, pywikipedia-bugs
jayvdb added a project: Easy.
TASK DETAIL https://phabricator.wikimedia.org/T90149
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, XZise, Aklapper, Multichill, droid, 01tonythomas, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org