jayvdb created this task. jayvdb added a subscriber: jayvdb. jayvdb added a project: pywikibot-core.
TASK DESCRIPTION There is an open pull request for a py3 problem, but our unit tests must not hit this section of code, or something
https://github.com/invisibleroads/socketIO-client/pull/60
However our unit tests fail on py 2.6
https://travis-ci.org/wikimedia/pywikibot-core/jobs/45687549
``` test_RC_pagegenerator_result (tests.pagegenerators_tests.LiveRCPageGeneratorTestCase) ... /home/travis/build/wikimedia/pywikibot-core/websocket_client-0.23.0-py2.6.egg/websocket/_core.py:223: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6 message = getattr(exception, 'message', '') No handlers could be found for logger "socketIO_client" No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated ```
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
jayvdb changed the title from "LiveRCPageGenerator fails on py 2.6" to "LiveRCPageGenerator upstream issues". jayvdb edited the task description. jayvdb set Security to none.
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
jayvdb changed the title from "LiveRCPageGenerator upstream issues" to "LiveRCPageGenerator socketIO_client upstream issues".
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
jayvdb moved this task to Upstream issues on the pywikibot-core workboard.
TASK DETAIL https://phabricator.wikimedia.org/T85716
WORKBOARD https://phabricator.wikimedia.org/project/board/87/
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
jayvdb added a project: Pywikibot-pagegenerators.
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
XZise added a subscriber: XZise. XZise added a comment.
@jayvdb obviously the only common factor is that it fails on ar.wp because otherwise that isn't tested (because socketIO_client is not installed).
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: Aklapper, jayvdb, XZise, pywikipedia-bugs
valhallasw added a subscriber: valhallasw. valhallasw added a comment.
The only obvious reason I can think of is a lack of changes, but that's not very likely. The warning 'No handlers could be found for logger "socketIO_client"' should not be related (it's juts a message when something gets logged with socketIO_client as logger).
Is there a way to run tests with -debug, and to view the debug log?
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
valhallasw added a comment.
It seems that on Python 3, pagegenerator_tests are not run at all: T86455: Pagegenerator_tests not run on Python 3 https://phabricator.wikimedia.org/T86455
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
valhallasw added a comment.
Okay, never mind. It's just skipped:
skipped 'socketIO_client not available'
https://travis-ci.org/wikimedia/pywikibot-core/jobs/45743556#L1031
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
XZise added a comment.
@valhallasw: Afaik there were tests for Travis but because of security reasons that was removed again.
Would be interested if someone has that problem locally. I never had a stalled test because of it (although I test a lot on Python 3 where that test is skipped so I'm probably not testing it enough).
But it happens quite often on Travis so it should've affected others locally already (at least a few times). Isn't it multithreading? Maybe a deadlock?
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
jayvdb added a comment.
In https://phabricator.wikimedia.org/T85716#968702, @XZise wrote:
@jayvdb obviously the only common factor is that it fails on ar.wp because otherwise that isn't tested (because socketIO_client is not installed).
I think this test is also run on all setup.py tests (i.e. enwp and arwp.) It isnt using same flags as the script tests. It is just:
test_deps.extend(extra_deps['rcstream'])
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
XZise added a comment.
Ah right I confused the `script_deps` as them because those are only installed on arwp.
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
jayvdb added a comment.
Note that https://phabricator.wikimedia.org/T85717 is about our undiagnosed test stalling problem; https://phabricator.wikimedia.org/T85716 is about any diagnosed upstream bugs.
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
XZise edited the task description.
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
jayvdb added a comment.
py3 builds skip this test because the released version doesnt import in py3
$ python3.4 Python 3.4.0 (default, Apr 11 2014, 13:05:18) [GCC 4.8.2] on linux Type "help", "copyright", "credits" or "license" for more information.
import socketIO_client
Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/local/lib/python3.4/dist-packages/socketIO_client/__init__.py", line 6, in <module> from urlparse import urlparse ImportError: No module named 'urlparse'
The fix has been pulled three days ago:
https://github.com/invisibleroads/socketIO-client/pull/60
But that fix hasnt been released onto pypi:
https://pypi.python.org/pypi/socketIO-client
I believe they are gearing up to release a new version on pypi.
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, XZise, valhallasw, pywikipedia-bugs
jayvdb added a comment.
I couldnt see any open ticket about the remaining issue which hasnt disappeared, being that it is not yielding the expected number of items. e.g. https://travis-ci.org/jayvdb/pywikibot-core/jobs/50748333 It has been doing that intermittently since https://phabricator.wikimedia.org/T85717 was fixed.
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 190719 had a related patch set uploaded (by Merlijn van Deen): RCStream: Ignore changes after total is reached
https://gerrit.wikimedia.org/r/190719
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
gerritbot added a comment.
Change 190719 merged by jenkins-bot: RCStream: Ignore changes after total is reached
https://gerrit.wikimedia.org/r/190719
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
jayvdb added a comment.
py2.6 is broken by websocket-client
https://github.com/liris/websocket-client/issues/151
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
jayvdb added a comment.
In https://phabricator.wikimedia.org/T85716#1058115, @jayvdb wrote:
py2.6 is broken by websocket-client
and fixed!
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
jayvdb added a comment.
Probably an upstream issue: https://phabricator.wikimedia.org/T91961
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
XZise added a comment.
It is sort of an upstream issue but with the requests dependency https://phabricator.wikimedia.org/T91394. There is also another problem because since socketIO_client version 0.6.1 it (apparently) only supports socket.io protocol 1.0 while stream.wikimedia.org is using 0.9. That causes the 404 errors in the recent builds. When you install 0.5.5 (the version before that) it works. See also https://phabricator.wikimedia.org/T91393.
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
gerritbot added a comment.
Change 195537 had a related patch set uploaded (by XZise): [FIX] socketIO: Use older version to support WMF
https://gerrit.wikimedia.org/r/195537
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
gerritbot added a comment.
Change 195537 merged by jenkins-bot: [FIX] socketIO: Use older version to support WMF
https://gerrit.wikimedia.org/r/195537
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
gerritbot added a comment.
Change 203625 had a related patch set uploaded (by John Vandenberg): test: skip test if socketIO-version >= 0.6.1
https://gerrit.wikimedia.org/r/203625
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
gerritbot added a comment.
Change 203625 merged by jenkins-bot: test: skip test if socketIO-version >= 0.6.1
https://gerrit.wikimedia.org/r/203625
TASK DETAIL https://phabricator.wikimedia.org/T85716
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, valhallasw, Aklapper, XZise, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org