https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
Bug ID: 71454 Summary: Some test runs are verbose Product: Pywikibot Version: core (2.0) Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: tests Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: jayvdb@gmail.com Web browser: --- Mobile Platform: ---
Some test runs become verbose, without a user config setting for verbosity. This previously occurred for travis builds against ar.wikipedia.
https://travis-ci.org/wikimedia/pywikibot-core/jobs/34230160
Current travis builds do not exhibit this behaviour, however it still occurs on my ar.wikipedia test runs.
https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
--- Comment #1 from John Mark Vandenberg jayvdb@gmail.com --- The cause of the problem appears to be flickrapi 1.4.4 which calls logging.basicConfig(), which is not appropriate for a library.
https://bitbucket.org/sybren/flickrapi/src/e91ab5c64c7ed036a7397474ec31f9b16...
The bug stopped happening on travis because script_tests first checks for ImageTk, which fails for travis builds, so flickrapi isnt loaded
https://travis-ci.org/wikimedia/pywikibot-core/jobs/37419168
"flickrripper depends on ImageTk, which isnt available: No module named ImageTk"
https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |upstream
--- Comment #2 from John Mark Vandenberg jayvdb@gmail.com --- Bug raised: https://bitbucket.org/sybren/flickrapi/issue/51/loggingbasicconfig
https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.wikimedia. | |org/show_bug.cgi?id=71864
https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
--- Comment #3 from John Mark Vandenberg jayvdb@gmail.com --- Now that we've fixed all the other issues with flickrripper, this is now causing builds to fail.
Some options: 1. use a custom build of flickrapi 1.4.4 for tests 2. use the hg master build of flickrapi for tests 3. somehow detect what flickrapi 1.4.4 has done and undo it
The simplest fix is option 2
https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
--- Comment #4 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 171479 had a related patch set uploaded by John Vandenberg: Use flickrapi master for tests
https://gerrit.wikimedia.org/r/171479
https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
--- Comment #5 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 171491 had a related patch set uploaded by John Vandenberg: Use custom flickrapi 1.4
https://gerrit.wikimedia.org/r/171491
pywikipedia-bugs@lists.wikimedia.org