[Maniphest] [Created] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

List overview All Threads
Download

newer

older

[Maniphest] [Created] T94687:...

[Maniphest] [Created] T78390: Load...

jayvdb

27 Dec 2014 27 Dec '14

5:04 a.m.

jayvdb created this task. jayvdb assigned this task to Omegat. jayvdb added subscribers: pywikipedia-bugs, jayvdb, XZise, Omegat. jayvdb added projects: PyWikiBot-Interwiki-Map, pywikibot-core, Pywikibot-tests. TASK DESCRIPTION The following tests depend on the user having certain token site_tests.TestSiteTokens.* site_tests.TestSiteObjectDeprecatedFunctions.test_token site_tests.SiteUserTestCase2.testPatrol If the test depends on having a token, the test is non-functional if the test user doesnt have that token, and the test should be marked as skipped. TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, jayvdb Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

Show replies by date

gerritbot

27 Dec 27 Dec

10:13 a.m.

New subject: [Maniphest] [Updated] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

gerritbot added a project: Patch-For-Review. gerritbot added a comment. Change 181883 had a related patch set uploaded (by Maverick): Skip Token tests if user doesn't have rights https://gerrit.wikimedia.org/r/181883 https://phabricator.wikimedia.org/tag/patch-for-review/ TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, gerritbot Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

gerritbot

30 Dec 30 Dec

4:52 a.m.

New subject: [Maniphest] [Commented On] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

gerritbot added a comment. Change 181883 merged by jenkins-bot: Skip Token tests if user doesn't have rights https://gerrit.wikimedia.org/r/181883 TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, gerritbot Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

Omegat

2 Jan 2 Jan

2:20 p.m.

New subject: [Maniphest] [Commented On] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

Omegat added a comment. This changeset was reverted by xzise in https://gerrit.wikimedia.org/r/#/c/182168/ As pointed out by xzise, test_token passed for a particular case before merging the change 181883. https://travis-ci.org/wikimedia/pywikibot-core/jobs/45416313#L801 While test_token was skipped when it was run on the change 181883. https://travis-ci.org/wikimedia/pywikibot-core/jobs/45420743#L800 This happened so because TokenWallet.__contains__ (key in site.tokens; gets underlined due to double underscore) only returns token value of a cached token. While TokenWallet.__getitem__ (token = site.tokens[key]) requests for the required token (if the token is not available in cache). TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

jayvdb

3 Jan 3 Jan

12:19 p.m.

New subject: [Maniphest] [Updated] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

jayvdb added a comment. More analysis has shown that the patrol token problem on Wikia is that the patrol token doesnt exist on Wikia - i.e. it isnt user-specific; the site havent enabled patrol functionality. That issue is now tracked in https://phabricator.wikimedia.org/T85725. TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, jayvdb Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

jayvdb

12:30 p.m.

New subject: [Maniphest] [Updated] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

jayvdb added a blocking task: T85725: token methods should use the list of tokens in paraminfo. TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, jayvdb Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

jayvdb

12:36 p.m.

New subject: [Maniphest] [Commented On] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

jayvdb added a comment. As patrol is a separate problem, the change for this task should focus only on the edit tokens. TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, jayvdb Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

gerritbot

3:24 p.m.

New subject: [Maniphest] [Commented On] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

gerritbot added a comment. Change 182575 had a related patch set uploaded (by Maverick): Detect if user doesn't have rights https://gerrit.wikimedia.org/r/182575 https://phabricator.wikimedia.org/tag/patch-for-review/ TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, gerritbot Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

gerritbot

6 Jan 6 Jan

4:04 p.m.

New subject: [Maniphest] [Commented On] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

gerritbot added a comment. Change 182575 merged by jenkins-bot: Detect if user doesn't have rights https://gerrit.wikimedia.org/r/182575 TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, gerritbot Cc: Aklapper, jayvdb, XZise, Omegat, pywikipedia-bugs

jayvdb

1 Apr 1 Apr

12:41 a.m.

New subject: [Maniphest] [Unblock] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

jayvdb closed blocking task T85725: token methods should use the list of tokens in paraminfo as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, jayvdb Cc: jayvdb, Aklapper, XZise, Omegat, pywikipedia-bugs

jayvdb

12:53 a.m.

New subject: [Maniphest] [Commented On] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

jayvdb added a comment. Is this resolved completely? TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, jayvdb Cc: jayvdb, Aklapper, XZise, Omegat, pywikipedia-bugs

XZise

11:39 a.m.

New subject: [Maniphest] [Commented On] T85353: Skip tests when the user does not have necessary tokens on the wiki being tested

XZise added a comment. Well you're the author but as I see it this has been resolved. TASK DETAIL https://phabricator.wikimedia.org/T85353 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Omegat, XZise Cc: jayvdb, Aklapper, XZise, Omegat, pywikipedia-bugs

3322

days inactive

3417

days old

pywikipedia-bugs@lists.wikimedia.org

Manage subscription

11 comments

4 participants

tags (0)

participants (4)

gerritbot
jayvdb
Omegat
XZise