Bugs item #2970264, was opened at 2010-03-14 15:37
Message generated for change (Settings changed) made by xqt
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=297026…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Merlijn S. van Deen (valhallasw)
Summary: Unable to check blocks on IP
Initial Comment:
I have code to check blocks on users or IPs using userlib.py
Since r7979, userlib raises an exception when I try to check blocks on IPs.
Please allow this behavior again.
----------------------------------------------------------------------
Comment By: Merlijn S. van Deen (valhallasw)
Date: 2010-03-15 14:11
Message:
No problem at all, and thanks for the report anyway :-). For future
reference, the change was as follows:
valhallasw@dorthonion:~/tmp$ svn diff -r 98:112
https://svn.toolserver.org/svnroot/nakor/almabot/unblock.py
Index: unblock.py
===================================================================
--- unblock.py (revision 98)
+++ unblock.py (revision 112)
@@ -66,7 +66,7 @@
user=userlib.User(site,username)
try:
blocked=user.isBlocked()
- except KeyError:
+ except userlib.InvalidUser:
params = {
'action' :'query',
'list' :'blocks',
Closing as invalid.
----------------------------------------------------------------------
Comment By: Nakor Wikipedia (nakor-wikipedia)
Date: 2010-03-15 04:09
Message:
Nevermind. I was tired. It is just the exception type that changed. You can
close.
----------------------------------------------------------------------
Comment By: Nakor Wikipedia (nakor-wikipedia)
Date: 2010-03-15 03:59
Message:
The script at
https://svn.toolserver.org/svnroot/nakor/almabot/unblock.py
is broken since tat change.
Please either revert that change or provide a way to check blocks on IP
adresses.
----------------------------------------------------------------------
Comment By: Merlijn S. van Deen (valhallasw)
Date: 2010-03-14 23:05
Message:
if u'invalid' in user:
raise InvalidUser("User name '%s' is invalid. IP addresses
are not supported." % user['name'])
This is not a bug, this is correct behaviour. Could the reporter please
show how sensible data is found?
Closing as 'invalid' in two weeks.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=297026…