saper created this task. saper added a subscriber: saper. saper added a project: Pywikibot-General. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION Having configured pywikibot with python `logging` module there is little need for this feature. This feature insists on checking pywikibot version which may cause problems like inability to locate `git` or lack of SSL certificate for tools.wmflabs.org {T98104}.
It should be optional (config entry?)
TASK DETAIL https://phabricator.wikimedia.org/T98106
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: saper Cc: pywikipedia-bugs, saper, Aklapper
jayvdb added a subscriber: jayvdb. jayvdb added a comment.
Yes, we could make it optional based on config variable log_pywiki_repo_version , which defaults to False in core.
TASK DETAIL https://phabricator.wikimedia.org/T98106
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, saper, Aklapper, pywikipedia-bugs
saper added a comment.
Isn't `log_pywiki_repo_version` used only once, to log the version during logging initialization but is not respected by `writeToCommandLogFile()` (both in core and compat)
What about adding `command` value to the `config.log` and making the default:
log = ['interwiki', 'command']
and then adding something like
if `command` in config.log: writeToCommandLogFile()
to `bot.py`/`wikipedia.py`
TASK DETAIL https://phabricator.wikimedia.org/T98106
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: saper Cc: jayvdb, saper, Aklapper, pywikipedia-bugs
jayvdb added a comment.
writeToCommandLogFile in core is very new port from compat, and it should have respected `log_pywiki_repo_version`.
In https://phabricator.wikimedia.org/T98106#1259884, @saper wrote:
Isn't `log_pywiki_repo_version` used only once, to log the version during logging initialization but is not respected by `writeToCommandLogFile()` (both in core and compat)
What about adding `command` value to the `config.log` and making the default:
log = ['interwiki', 'command']
and then adding something like
if `command` in config.log: writeToCommandLogFile()
to `bot.py`/`wikipedia.py`
This also sounds like a good approach to me.
TASK DETAIL https://phabricator.wikimedia.org/T98106
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, saper, Aklapper, pywikipedia-bugs
jayvdb edited projects, added Pywikibot-network; removed Pywikibot-General. jayvdb set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T98106
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, saper, Aklapper, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org