XZise created this task. XZise added subscribers: XZise, jayvdb. XZise added projects: pywikibot-core, Pywikibot-compat-to-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION Hi, the code should use `unicode_literals` throughout to avoid using `u'…'` which is one the reasons why Python 3 versions before 3.3 aren't supported. @jayvdb said somewhere (determine), that he'd prefer to do that in one go. I suggest to atleast do it in all new code, so that changing `u'…'` into `'…'` won't break git blame for those files when it's introduced later. It is possible to use `u'…'` on conjunction with `unicode_literals`, but that could confuse newcomers into thinking that `u'…'` is necessary.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
jayvdb added a comment.
I think it makes sense to add unicode_literals everywhere in a big bang before 2.0 RC1, and wait for the screams. This was discussed a little on https://gerrit.wikimedia.org/r/#/c/189914/2/scripts/cosmetic_changes.py
We can then remove u'...' over time, as part of regular code modifications. I dont see that removing them particularly helps newcomers; writing a style guide for new developers is a better approach.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
XZise edited the task description. XZise set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
XZise added a comment.
Regarding changing `u'…'`: Obviously that doesn't need to happen independently. But (especially after unicode_literals have been imported) it's possible to change it when the line is changed anyway.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
Ricordisamoa added a subscriber: Ricordisamoa.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 186962 had a related patch set uploaded (by XZise): [IMPROV] Use unicode_literals in fixes
https://gerrit.wikimedia.org/r/186962
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
gerritbot added a comment.
Change 202373 had a related patch set uploaded (by XZise): [IMPROV] Use unicode_literals
https://gerrit.wikimedia.org/r/202373
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
gerritbot added a comment.
Change 202373 merged by jenkins-bot: [IMPROV] Use unicode_literals
https://gerrit.wikimedia.org/r/202373
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
XZise added blocking tasks: T95803: UnicodeDecodeError when using pywikibot delete.py, T95671: UnicodeDecodeError when using pywikibot category.py.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
Ricordisamoa added a comment.
Hmm... it seems to be causing even more harm than benefits, doesn't it?
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
XZise added a comment.
Well it discovered some flaws and afaik all patches after that fix the original patch work independently. So if it's really unusable we can still just revert that one patch.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
XZise added a comment.
But just for good measure I'll list all patches which are unicode_literals specific in the first post so that if we want to abandon that project we could revert everything of that (but leave the useful stuff).
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
XZise edited the task description.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
XZise edited the task description.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
jayvdb closed blocking task T95803: UnicodeDecodeError when using pywikibot delete.py as "Resolved".
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
Rubin16 added a subscriber: Rubin16.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Rubin16 Cc: Rubin16, gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
Rubin16 added a blocked task: T94688: reflinks.py doesn't save changes to articles.
TASK DETAIL https://phabricator.wikimedia.org/T89589
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Rubin16 Cc: Rubin16, gerritbot, Ricordisamoa, jayvdb, Aklapper, XZise, droid, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org