https://bugzilla.wikimedia.org/show_bug.cgi?id=61816

Bug ID: 61816 Summary: No git doesn't mean it is Windows Product: Pywikibot Version: core (2.0) Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: nullzero.free@gmail.com Web browser: --- Mobile Platform: ---

I tried to run pywikibot in tools web server and got an error:

File "/shared/pywikipedia/core/pywikibot/version.py", line 134, in getversion_git except WindowsError: NameError: global name 'WindowsError' is not defined

The problem comes from:

cmd = 'git' try: subprocess.Popen([cmd], stdout=subprocess.PIPE).communicate() except WindowsError:

The framework tries to call git, but /usr/bin is not in $PATH in tools web server; consequently, the calling fails. The error falls to except block, and obviously, tools server is not Windows; WindowsError is not defined, making NameError.