[ pywikipediabot-Patches-2835479 ] Allowing xmlreader to read from stdin - Pywikipedia-bugs

30 Nov 2009


      Patches item #2835479, was opened at 2009-08-11 12:12
Message generated for change (Comment added) made by siebrand
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2835479...
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: rewrite
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jean-Daniel Fekete (jdfekte)
Assigned to: Nobody/Anonymous (nobody)
Summary: Allowing xmlreader to read from stdin
Initial Comment:
XML dumps are huge and distributed in 7zip format now. This very small patch allows dumps to be read from the standard input using '-' as file name.
----------------------------------------------------------------------
...
Comment By: siebrand (siebrand)
Date: 2009-11-30 12:48
Message:
@valhallasw: Do you suggest that the patch should be rejected based on your
reasoning?
----------------------------------------------------------------------
Comment By: Jean-Daniel Fekete (jdfekte)
Date: 2009-10-08 12:12
Message:
Decompressing on the fly is important to avoid creating huge files. I need
to process the full dump with revisions of the French wikipedia (for now)
and decompressing it is unreasonable. Using pipes is a standard practice
and they are not slow compared to the parsing and processing time of
Python.
I understand the aesthetic objection but pragmatically, the "-" syntax is
quite convenient and the changes are quite minimal.
----------------------------------------------------------------------
Comment By: siebrand (siebrand)
Date: 2009-10-02 11:43
Message:
Submitter, please address comment dated 2009-08-11 13:45 by valhallasw.
Otherwise this patch will be rejected for certain after 2 weeks.
----------------------------------------------------------------------
Comment By: Merlijn S. van Deen (valhallasw)
Date: 2009-08-11 13:45
Message:
I never see the point of programs adding '-' as magic filename. Unix has
/dev/stdin, dos/windows have CON. Secondly, it is probably better to use an
internal 7zip decompressor, as pipes tend to be slow.
----------------------------------------------------------------------
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2835479...