Bugs item #3002650, was opened at 2010-05-17 06:51 Message generated for change (Comment added) made by russblau You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=3002650...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: rewrite Group: None

Status: Closed Resolution: Fixed

Priority: 5 Private: No Submitted By: stanlekub (stanlekub) Assigned to: Russell Blau (russblau) Summary: .nice_get_address() used but not implemented

Initial Comment: In the rewrite branch, the Site.nice_get_address() method is marked as 'NotImplemented' but is used in various scripts, namely : * pagegenerators.py (to set the 'site:' attribute of Google and Yahoo search queries) * replace.py and interwiki.py for the 'open in browser' options.

As I'm unsure if the NotImplemented status means "not implemented yet" or "will not implement", I propose two patches: * The first one wich works around using Family.nicepath() * The second one which implements nice_get_address() "the old way", removing it from the NotImplemented pool.

----------------------------------------------------------------------

Comment By: Russell Blau (russblau)

Date: 2010-05-19 15:11

Message: Fixed in r8198: I applied your second patch, but added a more API-aware override in APISite.

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=3002650...