jayvdb created this task. jayvdb claimed this task. jayvdb added subscribers: jayvdb, Ladsgroup. jayvdb added projects: Pywikibot-tests, Continuous-Integration-Config. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION `.travis.yml` checks whether the github username is wikimedia, in order to preset the username "Pywikibot-test" for the tests. However the secret password for Pywikibot-test is not available for pull requests, so the build halts requesting a password.
This doesnt look good to potential contributors.
https://travis-ci.org/wikimedia/pywikibot-core/jobs/61128398
Could someone with access to 'wikimedia' travis-ci set the username and password in the Travis CI settings as described in https://github.com/wikimedia/pywikibot-core/tree/master/tests#travis-ci , so we can remove the wikimedia special case from `.travis.yml`.
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ladsgroup, jayvdb, Aklapper, hashar, greg, pywikipedia-bugs
XZise added a subscriber: XZise.
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, XZise Cc: XZise, Ladsgroup, jayvdb, Aklapper, hashar, greg, pywikipedia-bugs
greg removed a project: Continuous-Integration-Config. greg set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, greg Cc: XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
greg added a subscriber: greg. greg added a comment.
The continuous integrations projects in Phab do not manage Travis/Github issues.
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, greg Cc: greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
hashar added a project: pywikibot-core. hashar added a subscriber: hashar.
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, hashar Cc: hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
hashar added a comment.
@jayvdb most people at https://github.com/orgs/wikimedia/people should have appropriate access rights. I do for sure, so feel free to poke me on IRC on Wednesday (or later) and I will be happy to help.
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, hashar Cc: hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a comment.
Change 209139 had a related patch set uploaded (by John Vandenberg): wikimedia username moved into Travis-CI settings
https://gerrit.wikimedia.org/r/209139
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
gerritbot added a project: Patch-For-Review.
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
hashar added a comment.
Looking at Travis https://travis-ci.org/wikimedia/pywikibot-core/settings/env_vars we have a PYWIKIBOT2_USER variable there. I guess we need to add USER_PASSWORD as well isn't it ? I don't have the password though.
TASK DETAIL https://phabricator.wikimedia.org/T98189
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, hashar Cc: gerritbot, hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
XZise added a comment.
As I've commented in the changeset uploaded by @jayvdb: The password is in the .travis.yml as an encrypted string.
TASK DETAIL https://phabricator.wikimedia.org/T98189
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, XZise Cc: gerritbot, hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
hashar added a comment.
I would need the raw password to set USER_PASSWORD though :}
TASK DETAIL https://phabricator.wikimedia.org/T98189
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, hashar Cc: gerritbot, hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
XZise added a comment.
But that is not so important for the issue though (although I don't have a problem when this is changed too). Currently (because the patch isn't merged) it used the username //Pywikibot-test// because the travis build is done with the //wikimedia// account but when it's a test initiated by a pull request it won't get access to the password so it can't login (but it tries to login because the username is set). Now when the patch is merged it shouldn't get access to neither the password nor the username so it never tries to do anything where the password is used.
TASK DETAIL https://phabricator.wikimedia.org/T98189
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, XZise Cc: gerritbot, hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
gerritbot added a comment.
Change 209139 merged by jenkins-bot: wikimedia username moved into Travis-CI settings
https://gerrit.wikimedia.org/r/209139
TASK DETAIL https://phabricator.wikimedia.org/T98189
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
jayvdb closed this task as "Resolved".
TASK DETAIL https://phabricator.wikimedia.org/T98189
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, hashar, greg, XZise, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org