valhallasw created this task. valhallasw added a subscriber: valhallasw. valhallasw added projects: pywikibot-core, Pywikibot-General. valhallasw changed Security from none to none.
TASK DESCRIPTION Introduced in https://github.com/wikimedia/pywikibot-core/commit/3adef7c6a7e41c2e35d1d0c08...
TASK DETAIL https://phabricator.wikimedia.org/T76238
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: valhallasw Cc: pywikipedia-bugs, valhallasw, jayvdb
jayvdb added a subscriber: jayvdb. jayvdb added a comment.
I dont mind if this sys.exit is removed (I've been getting rid of them everywhere in the library), but (for the record) the use of sys.exit if importing httplib2 failed was introduced in 2011 over in threadedhttp.py http://git.wikimedia.org/blobdiff/pywikibot%2Fcore.git/30c2ed6f542cb3674fa98... (prior to that it only used sys.exit if import pkg_resources failed)
Removing it does mean the users are more likely to see nasty backtraces (and may not notice the nice error message that we emit) if they are not using pwb. But IMO we should only be supporting pwb and library mode.
TASK DETAIL https://phabricator.wikimedia.org/T76238
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: pywikipedia-bugs, valhallasw, jayvdb
valhallasw added a comment.
*nod* it's even older. Let's kill it in any case -- just raising an ImportError is much more sensible.
TASK DETAIL https://phabricator.wikimedia.org/T76238
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: valhallasw Cc: pywikipedia-bugs, valhallasw, jayvdb
jayvdb moved this task to Ready to go on the pywikibot-core workboard.
TASK DETAIL https://phabricator.wikimedia.org/T76238
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: pywikipedia-bugs, valhallasw, jayvdb
jayvdb moved this task to Probably core only on the Pywikibot-General workboard.
TASK DETAIL https://phabricator.wikimedia.org/T76238
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: pywikipedia-bugs, valhallasw, jayvdb
pywikipedia-bugs@lists.wikimedia.org