https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
Web browser: --- Bug ID: 55152 Summary: Recentchanges misbehave? Product: Pywikibot Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: legoktm.wikipedia@gmail.com Classification: Unclassified Mobile Platform: ---
Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1579/ Reported by: Anonymous user Created on: 2013-02-13 09:41:03 Subject: Recentchanges misbehave? Original description: There are two bugs I found in recentchanges() from wikipedia.py.
First, I think that the function should return every revision. However, now it returns only pages that haven't seen before.
Should
if i['pageid'] not in seen: seen.add(i['pageid'])
be replaced with
if i['revid'] not in seen: seen.add(i['revid'])
?
Second, what does parameter 'includeredirects' stand for? It is useless becaue it isn't used anywhere in the function.
Pywikipedia trunk/pywikipedia/ (r11072, 2013/02/10, 16:52:07, ok) Python 2.7.3 (default, Sep 26 2012, 21:53:58) [GCC 4.7.2] config-settings: use_api = True use_api_login = True unicode test: ok
https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://sourceforge.net/p/p | |ywikipediabot/bugs/1579
https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
--- Comment #1 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 111832 had a related patch set uploaded by Nullzero: Make Recentchanges return all revisions
https://gerrit.wikimedia.org/r/111832
https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
--- Comment #2 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 111832 had a related patch set uploaded by Nullzero: Make Recentchanges return all revisions
https://gerrit.wikimedia.org/r/111832
https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
--- Comment #3 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 116218 had a related patch set uploaded by Nullzero: Make Recentchanges be able to return all revisions
https://gerrit.wikimedia.org/r/116218
https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
--- Comment #4 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 111832 abandoned by Nullzero: Make Recentchanges return all revisions
Reason: Can't rebase -- create a new one instead
https://gerrit.wikimedia.org/r/111832
https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
--- Comment #5 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 116218 merged by jenkins-bot: Make Recentchanges be able to return all revisions
https://gerrit.wikimedia.org/r/116218
https://bugzilla.wikimedia.org/show_bug.cgi?id=55152
xqt info@gno.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|PATCH_TO_REVIEW |RESOLVED CC| |info@gno.de Resolution|--- |FIXED
pywikipedia-bugs@lists.wikimedia.org