jayvdb created this task. jayvdb added a subscriber: jayvdb. jayvdb added a project: pywikibot-core. jayvdb changed Security from none to none.
TASK DESCRIPTION I can reliably produce a badtoken by running the entire test suite on ar.wp or test.wd on this change:
https://gerrit.wikimedia.org/r/178453
TASK DETAIL https://phabricator.wikimedia.org/T77965
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
jayvdb added a comment.
I've narrowed it down on ar.wp to:
``` PYSETUP_TEST_EXTRAS=1 python -m unittest -v tests.site_tests tests.link_tests tests.interwiki_link_tests tests.page_tests ... test_watch (tests.page_tests.TestPageUserAction) ... WARNING: API warning (watch): The title parameter has been deprecated. ERROR: APIError: badtoken: Invalid token Traceback (most recent call last): File "tests/utils.py", line 54, in wrapper func(*args, **kwargs) File "tests/page_tests.py", line 610, in test_watch rv = userpage.watch() File "pywikibot/page.py", line 1113, in watch return self.site.watchpage(self, unwatch) File "pywikibot/site.py", line 4353, in watchpage result = req.submit() File "pywikibot/data/api.py", line 1071, in submit raise APIError(code, info, **result["error"]) APIError: badtoken: Invalid tokenskipped '' ```
Note that just running site_tests page_tests does not cause this bug.
TASK DETAIL https://phabricator.wikimedia.org/T77965
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
jayvdb added a blocking task: T61678: Implement badtoken detection and recovery.
TASK DETAIL https://phabricator.wikimedia.org/T77965
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
jayvdb added a comment.
there is also a related problem with script watchlist.py , where it emits names of watched pages (user page and user talk) on fr.wikt and test.wd when using nosetests-3.3
https://travis-ci.org/wikimedia/pywikibot-core/builds/43492552
this test is skipped under setup.py test, but we dont know why it doesnt occur with nosetests-2
TASK DETAIL https://phabricator.wikimedia.org/T77965
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 178735 had a related patch set uploaded (by John Vandenberg): Ignore output of script test 'watchlist' -simulate
[[https://gerrit.wikimedia.org/r/178735]]
#patch-for-review
TASK DETAIL https://phabricator.wikimedia.org/T77965
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: gerritbot Cc: Aklapper, jayvdb, pywikipedia-bugs
gerritbot added a comment.
Change 178735 merged by jenkins-bot: Ignore output of script test 'watchlist' -simulate
[[https://gerrit.wikimedia.org/r/178735]]
TASK DETAIL https://phabricator.wikimedia.org/T77965
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: gerritbot Cc: Aklapper, jayvdb, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a comment.
Change 180713 had a related patch set uploaded (by John Vandenberg): Replace @must_be with @need_right
https://gerrit.wikimedia.org/r/180713
TASK DETAIL https://phabricator.wikimedia.org/T77965
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, Aklapper, pywikipedia-bugs
gerritbot added a comment.
Change 209467 had a related patch set uploaded (by John Vandenberg): Request: warn if site not provided
https://gerrit.wikimedia.org/r/209467
TASK DETAIL https://phabricator.wikimedia.org/T77965
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, Aklapper, pywikipedia-bugs
gerritbot added a comment.
Change 209467 merged by jenkins-bot: Request: warn if site not provided
https://gerrit.wikimedia.org/r/209467
TASK DETAIL https://phabricator.wikimedia.org/T77965
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, Aklapper, pywikipedia-bugs
jayvdb closed this task as "Resolved". jayvdb claimed this task.
TASK DETAIL https://phabricator.wikimedia.org/T77965
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, jayvdb, Aklapper, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org