https://bugzilla.wikimedia.org/show_bug.cgi?id=65013
Bug ID: 65013 Summary: Test QueryGenerator.limit Product: Pywikibot Version: core (2.0) Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: valhallasw@arctus.nl Blocks: 58941 Web browser: --- Mobile Platform: ---
Test various values, including:
0,1,many, -1, -somethingelse, None (should probably throw a warning given it's not actually an allowed value)
See https://gerrit.wikimedia.org/r/#/c/131991/ for more details.
https://bugzilla.wikimedia.org/show_bug.cgi?id=65013
xqt info@gno.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |info@gno.de
--- Comment #1 from xqt info@gno.de --- Some additional hints
Look at Site.preloadpages() method at site.py line 1381 QueryGenerator.limit is set to -1:
rvgen.set_maximum_items(-1) # suppress use of "rvlimit" parameter
Documentation of QueryGenerator.set_maximum_items() Shows """ If set to -1 (or any negative value), the "limit" parameter will be omitted from the request. For some request types (such as prop=revisions), this is necessary to signal that only current revision is to be returned. """
https://bugzilla.wikimedia.org/show_bug.cgi?id=65013
xqt info@gno.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |64489
https://bugzilla.wikimedia.org/show_bug.cgi?id=65013
--- Comment #2 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 132387 had a related patch set uploaded by Xqt: (bug 65013) Test QueryGenerator.limit
https://gerrit.wikimedia.org/r/132387
https://bugzilla.wikimedia.org/show_bug.cgi?id=65013
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
pywikipedia-bugs@lists.wikimedia.org