Xqt created this task. Xqt added a subscriber: Xqt. Xqt added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION bot tags a HiddenTemplateNotification for ko-wiki on user talk pages of de-wiki.
see: https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Metal_Guru&am... or https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Metal_Guru&am...
TASK DETAIL https://phabricator.wikimedia.org/T97291
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt Cc: pywikipedia-bugs, Xqt, Aklapper, jayvdb
XZise added a subscriber: XZise. XZise added a comment.
Both links are the same?
TASK DETAIL https://phabricator.wikimedia.org/T97291
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, Xqt, Aklapper, jayvdb, pywikipedia-bugs
XZise added a comment.
Okay I'm not sure what the problem is (I guess the English template text). In `checkimages.py` only one entry has that format:
HiddenTemplateNotification = { 'commons': (u"\n{{subst:User:Filnik/whitetemplate|File:%s}}\n\n''This " u"message was added automatically by __botnick__, if you need " u"some help about it please read the text above again and " u"follow the links in it, if you still need help ask at the " u"[[File:Human-help-browser.svg|18px|link=Commons:Help desk|?]]" u" '''[[Commons:Help desk|→]] [[Commons:Help desk]]''' in any " u"language you like to use.'' --__botnick__ ~~~~~"), 'it': u"{{subst:Progetto:Coordinamento/Immagini/Bot/Messaggi/Template_insufficiente|%s|__botnick__}} --~~~~", 'ko': u"\n{{subst:User:Kwj2772/whitetemplates|%s}} --~~~~", }
And I don't see how would interfere there. This dictionary is used there:
HiddenTN = i18n.translate(self.site, HiddenTemplateNotification)
And that doesn't set fallback (so it's False). So the only problem with that patch COULD be the else block of the for loop.
TASK DETAIL https://phabricator.wikimedia.org/T97291
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, Xqt, Aklapper, jayvdb, pywikipedia-bugs
XZise claimed this task.
TASK DETAIL https://phabricator.wikimedia.org/T97291
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, Xqt, Aklapper, jayvdb, pywikipedia-bugs
XZise closed this task as "Resolved". XZise added a comment.
Well this has been resolved with reverting the patch. https://gerrit.wikimedia.org/r/#/c/206812/ does it properly.
TASK DETAIL https://phabricator.wikimedia.org/T97291
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, Xqt, Aklapper, jayvdb, pywikipedia-bugs
XZise reassigned this task from XZise to Xqt. XZise set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T97291
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt, XZise Cc: XZise, Xqt, Aklapper, jayvdb, pywikipedia-bugs
Xqt added a comment.
HiddenTN becomes u"\n{{subst:User:Kwj2772/whitetemplates|%s}} --~~~~", for Site('de'). I didn't investigate in this matter but it worked correctly before this patch
TASK DETAIL https://phabricator.wikimedia.org/T97291
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt Cc: XZise, Xqt, Aklapper, jayvdb, pywikipedia-bugs
XZise added a comment.
Okay it was a mistake in the original patch: Previously when fallback wasn't True it didn't choose any other code than the selected one. But now it iterated through the alternative codes even if fallback is False. Now even if no fallback code was valid too it previously has chosen a “random” (it's in Python's hand to choose one; not truly random) one but that only happened when fallback was not False. And when I rewrote that I overlooked that it didn't choose a random one when fallback was False.
So in your case the code is `de` and there is neither a translation for fallback languages of `de` nor one for `_default` and `en` so if fallback was True it should've selected a “random” one. But as fallback is False it didn't but not accidentally did. I hope this description clears things up.
TASK DETAIL https://phabricator.wikimedia.org/T97291
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt, XZise Cc: XZise, Xqt, Aklapper, jayvdb, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org