jayvdb created this task. jayvdb added subscribers: pywikipedia-bugs, jayvdb. jayvdb added projects: pywikibot-core, easy, Pywikibot-tests.
TASK DESCRIPTION BaseSite.urlEncode is deprecated, and uses urlencode(query) as its implementation. This doesnt appear to be backwards compatible, as the compat code would re-order the args, and do utg8 encoding.
Ideally we build some unit tests that pass on compat, but fail on core, and find an implementation that is backwards compatible, or copy the code from compat.
TASK DETAIL https://phabricator.wikimedia.org/T85321
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
XZise edited the task description. XZise set Security to none.
TASK DETAIL https://phabricator.wikimedia.org/T85321
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: Aklapper, jayvdb, pywikipedia-bugs
XZise added a subscriber: XZise. XZise added a comment.
I'm not sure, but applying UTF8 encoding on a url-encoded string?
TASK DETAIL https://phabricator.wikimedia.org/T85321
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: Aklapper, jayvdb, XZise, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org