jayvdb created this task. jayvdb claimed this task. jayvdb added subscribers: jayvdb, Legoktm, hashar. jayvdb added projects: Continuous-Integration, pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION As jenkins will no longer automatically run rules in tox.ini, we need to hardwire pep8 and pep257 into jenkins, like the mediawiki lint tests.
pep8 runs without arguments, using the config in tox.ini for the exclude and ignore list.
pep257 doesn't have an exclude parameter (yet), but looks like they are interested in that feature: https://github.com/GreenSteam/pep257/pull/22#issuecomment-70471875
While waiting for feedback on adding exclude to pep257, it would be nice if we didnt need an exclude list .. ;-)
date.py is being ignored by flake8, but is processed by pep257, so I've tackled that. https://gerrit.wikimedia.org/r/#/c/185815/
pep257 is validating ez_setup.py , which I've tried to fix at the source of the problem: https://bitbucket.org/pypa/setuptools/pull-request/117/pep8-and-pep257-compl...
pep257 doesnt ignore items with '# noqa' , so it is emitting errors for interwiki.py (easy) and pywikibot/exceptions.py (messy).
Also if the job is hardwired into jenkins, and we can only maintain one match list in tox.ini , we cant reimplement the 'mandatory docstring' list without some serious cleanup first.
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: hashar, Legoktm, jayvdb, Aklapper, greg, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 185815 had a related patch set uploaded (by John Vandenberg): PEP8 and PEP257 fixes
https://gerrit.wikimedia.org/r/185815
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, hashar, Legoktm, jayvdb, Aklapper, greg, pywikipedia-bugs
gerritbot added a comment.
Change 185815 merged by jenkins-bot: PEP8 and PEP257 fixes
https://gerrit.wikimedia.org/r/185815
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, hashar, Legoktm, jayvdb, Aklapper, greg, pywikipedia-bugs
jayvdb added a comment.
@legoktm pointed me towards this as where the mediawiki linter is hardwired into jenkins https://github.com/wikimedia/integration-config/blob/master/jjb/job-template...
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, hashar, Legoktm, jayvdb, Aklapper, greg, pywikipedia-bugs
jayvdb triaged this task as "Unbreak Now!" priority. jayvdb added a comment.
It looks like there will not be a quick resolution with the pep257 project ( https://github.com/GreenSteam/pep257/issues/97) , and I had no luck fixing the pep issues in ez_setup in setuptools.
So I request that flake8 with docstrings plugin is run on patch upload by *anyone*. No other plugins should be run, of course.
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, hashar, Legoktm, jayvdb, Aklapper, greg, pywikipedia-bugs
Ricordisamoa added a subscriber: Ricordisamoa.
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Ricordisamoa Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, greg, pywikipedia-bugs
jayvdb added a blocked task: T85328: PEP-8 compliance.
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, greg, pywikipedia-bugs
Aklapper added a comment.
@jayvdb: This task has "Unbreak now" priority since January 2015 which seems unrealistic https://www.mediawiki.org/wiki/Phabricator/Project_management#Priority_levels. Are you working on this, or should the priority value be corrected?
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Aklapper Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, pywikipedia-bugs
jayvdb added a comment.
@aklapper, I was hoping the CI team might fix this regression created by @hashar. https://lists.wikimedia.org/pipermail/pywikipedia-l/2015-January/009214.html
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, pywikipedia-bugs
Legoktm added a comment.
My hacky idea is to have a pywikibot-core-tox-flake8 job that only runs if "tox.ini" is *not* touched for non-whitelisted users. Whitelisted users (and on gate-and-submit) we would run the normal tox-flake8 job.
Is pep257 part of `flake8`? or is that `flake8-docstrings`?
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Legoktm Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, pywikipedia-bugs
jayvdb added a comment.
@legoktm, that sounds much better than the current situation - tox.ini changes are very rare by non-whitelisted users.
package `flake8-docstrings` is the wrapper around `pep257`.
tox.ini entry `flake8-docstrings` is non-voting, so ignore that one.
`flake8` , `flake8-py3` and `flake8-docstrings-mandatory` (pep257) are the important entries in tox.ini
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, pywikipedia-bugs
Krinkle moved this task to Backlog on the Continuous-Integration workboard.
TASK DETAIL https://phabricator.wikimedia.org/T87169
WORKBOARD https://phabricator.wikimedia.org/project/board/401/
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Krinkle Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, pywikipedia-bugs
Aklapper added a comment.
Any decision / movement is welcome here (I repeat myself by saying that this task has "Unbreak now" priority since January 2015 so if this is not "drop anything else and fix this", please decrease the Priority value!).
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Aklapper Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, pywikipedia-bugs
Ricordisamoa lowered the priority of this task from "Unbreak Now!" to "High". Ricordisamoa removed a project: Patch-For-Review. Ricordisamoa set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T87169
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Ricordisamoa Cc: Ricordisamoa, gerritbot, hashar, Legoktm, jayvdb, Aklapper, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org