https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
Web browser: --- Bug ID: 56035 Summary: It's unclear what the default values for RecentChangesPageGenerators arguments do Product: Pywikibot Version: core (2.0) Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: themineo+wikibz@gmail.com Classification: Unclassified Mobile Platform: ---
RecentChangesPageGenerator takes a few arguments like showMinor, showAnon, ... that are supposed to be boolean. However, they all have a default value of None, but the documentation only covers the case where they're either True or False. (The same is true for the recentchanges method in site.py that the generator uses.)
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |legoktm.wikipedia@gmail.com
--- Comment #1 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- In this case if the parameter is None, it doesn't specify a preference, so it uses the API default, which can be seen at [[mw:API:Recentchanges]]
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
--- Comment #2 from Wieland Hoffmann themineo+wikibz@gmail.com --- That page doesn't tell me if '!minor' or 'minor' is the default either.
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
--- Comment #3 from Wieland Hoffmann themineo+wikibz@gmail.com --- Ah, sorry, that page does actually make it more clear that the default is 'just list all edits'.
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
Merlijn van Deen valhallasw@arctus.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |valhallasw@arctus.nl
--- Comment #4 from Merlijn van Deen valhallasw@arctus.nl --- Hrm. Then we still have an issue, as showMinor=True does not imply *only* minor edits are shown, which is what passing 'minor' to the API means.
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
Merlijn van Deen valhallasw@arctus.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |56190
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
Merlijn van Deen valhallasw@arctus.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|Unprioritized |Normal
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
Mpaa mpaa.wiki@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mpaa.wiki@gmail.com
--- Comment #5 from Mpaa mpaa.wiki@gmail.com --- showMinor=True shows *only* minor edits. Docstring looks OK to me: @param showMinor: if True, only list minor edits; if False (and not None), only list non-minor edits
To be really picky, it should be specified that None shows all ... Anyhow, I added to Pagegenerators additional args present in site.recentchanges() and updated doc string.
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
--- Comment #6 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 106122 had a related patch set uploaded by Mpaa: (bug 56035) RecentChangesPageGenerators arguments do
https://gerrit.wikimedia.org/r/106122
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |PATCH_TO_REVIEW Ever confirmed|0 |1
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
--- Comment #7 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 106122 merged by jenkins-bot: (bug 56035) RecentChangesPageGenerators arguments do
https://gerrit.wikimedia.org/r/106122
https://bugzilla.wikimedia.org/show_bug.cgi?id=56035
xqt info@gno.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|PATCH_TO_REVIEW |RESOLVED CC| |info@gno.de Resolution|--- |FIXED
pywikipedia-bugs@lists.wikimedia.org