https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
Bug ID: 70969 Summary: xmlreader test errors on win32 py3 Product: Pywikibot Version: core (2.0) Hardware: All OS: Windows XP Status: NEW Severity: normal Priority: Unprioritized Component: tests Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: jayvdb@gmail.com Web browser: --- Mobile Platform: ---
test_XmlDumpAllRevs (tests.xmlreader_tests.XmlReaderTestCase) ... c:\pywiki\core\tests\xmlreader_tests.py:25: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\pywiki\core\tests\data\article-pear.xml' mode='r' encoding='cp 1252'> pages = [r for r in ok test_XmlDumpFirstRev (tests.xmlreader_tests.XmlReaderTestCase) ... c:\pywiki\core\tests\xmlreader_tests.py:38: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\pywiki\core\tests\data\article-pear.xml' mode='r' encoding='c p1252'> pages = [r for r in ok test_XmlDumpRedirect (tests.xmlreader_tests.XmlReaderTestCase) ... ERROR c:\Python34\lib\unittest\case.py:605: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\pywiki\core\tests\data\article-pyrus.xml' mode='r' encod ing='cp1252'> outcome.errors.clear()
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|xmlreader test errors on |ResourceWarning unclosed |win32 py3 |files on win32 py3
--- Comment #1 from John Mark Vandenberg jayvdb@gmail.com --- Another unclosed file in
test_user_agent (tests.dry_site_tests.TestDrySite) ... c:\Python34\lib\subprocess.py:754: ResourceWarning: unclosed file <_io.BufferedReader name=3> _cleanup() ok
c:\Python34\lib\unittest\suite.py:110: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\pywiki\core\tests\data\csv_ingestion.csv' mode='r' encoding='cp1252'> for index, test in enumerate(self): test_getDescription (tests.data_ingestion_tests.TestCSVReader) ... ok test_getTitle (tests.data_ingestion_tests.TestCSVReader) ... ok c:\Python34\lib\unittest\suite.py:87: ResourceWarning: unclosed file <_io.TextIOWrapper name='c:\pywiki\core\tests\data\csv_ingestion.csv' mode='r' encoding='cp1252'> return self.run(*args, **kwds)
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|ResourceWarning unclosed |ResourceWarning unclosed |files on win32 py3 |files py3 OS|Windows XP |All
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |58053
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
--- Comment #2 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 161195 had a related patch set uploaded by XZise: [FIX] Close opened files
https://gerrit.wikimedia.org/r/161195
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
--- Comment #3 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 161195 merged by jenkins-bot: [FIX] Close opened files and open XMLs in binary mode
https://gerrit.wikimedia.org/r/161195
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
--- Comment #4 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 161227 had a related patch set uploaded by XZise: [FIX] Close csv file and subprocess stdout streams
https://gerrit.wikimedia.org/r/161227
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
--- Comment #5 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 161227 merged by jenkins-bot: [FIX] Close subprocess stdout streams
https://gerrit.wikimedia.org/r/161227
https://bugzilla.wikimedia.org/show_bug.cgi?id=70969
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED
pywikipedia-bugs@lists.wikimedia.org