jayvdb created this task. jayvdb claimed this task. jayvdb added a subscriber: jayvdb. jayvdb added projects: pywikibot-core, Pywikibot-Cosmetic-changes. jayvdb changed Security from none to none.
TASK DESCRIPTION Page save uses the cosmetic changes script, which is not packaged in the core library. In T76320, the hard dependency was broken, but the functionality is missing if the script is not packaged as part of the library.
cosmetic_changes.py needs to be split, moving the toolkit into pywikibot, and leaving a script in the scripts package for adhoc usage of the toolkit (or maybe integrated as an option in touch.py?).
TASK DETAIL https://phabricator.wikimedia.org/T76324
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: pywikipedia-bugs, jayvdb
jayvdb added a comment.
Also related: T76323 - moving the algorithms into fixes.py , that is a very simple task for a few of the cosmetic changes - others may require fixes to support the transform being a python function.
TASK DETAIL https://phabricator.wikimedia.org/T76324
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb Cc: pywikipedia-bugs, jayvdb
jayvdb added a blocked task: T60942: [tracking] features to move from scripts to framework.
TASK DETAIL https://phabricator.wikimedia.org/T76324
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, pywikipedia-bugs
Liuxinyu970226 added a subscriber: Liuxinyu970226.
TASK DETAIL https://phabricator.wikimedia.org/T76324
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Liuxinyu970226 Cc: Liuxinyu970226, jayvdb, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 190715 had a related patch set uploaded (by Ladsgroup): Move cosmetic_changes from scripts to pywikibot
https://gerrit.wikimedia.org/r/190715
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T76324
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, Liuxinyu970226, jayvdb, pywikipedia-bugs
gerritbot added a comment.
Change 190715 merged by jenkins-bot: Move cosmetic_changes from scripts to pywikibot
https://gerrit.wikimedia.org/r/190715
TASK DETAIL https://phabricator.wikimedia.org/T76324
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, Liuxinyu970226, jayvdb, pywikipedia-bugs
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup removed a project: Patch-For-Review.
TASK DETAIL https://phabricator.wikimedia.org/T76324
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup Cc: gerritbot, Liuxinyu970226, jayvdb, pywikipedia-bugs
Liuxinyu970226 removed a subscriber: Liuxinyu970226.
TASK DETAIL https://phabricator.wikimedia.org/T76324
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, Liuxinyu970226 Cc: gerritbot, jayvdb, pywikipedia-bugs
jayvdb closed blocking task T89993: remove isbn script dependency in cosmetic_changes as "Resolved".
TASK DETAIL https://phabricator.wikimedia.org/T76324
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, jayvdb Cc: gerritbot, jayvdb, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org