Bugs item #3610818, was opened at 2013-04-14 02:25 Message generated for change (Comment added) made by xqt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=3610818...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: weblinkchecker Group: trunk

Status: Open

Resolution: Fixed Priority: 5 Private: No Submitted By: Harmen (harmenhuizinga) Assigned to: Amir (amird) Summary: urls ending on a ) incorrectly parsed

Initial Comment: $ python version.pyPywikipedia [http] trunk/pywikipedia (r11368, 2013/04/13, 08:16:45, ok) Python 2.7.3 (v2.7.3:70274d53c1dd, Apr 9 2012, 20:52:43) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] config-settings: use_api = True use_api_login = True unicode test: ok

Weblinks with an ) at the end of the url are handled incorrect by weblinkchecker. That means that the ) is stripped from the url. See example:

$ python weblinkchecker.py -lang:nl -page:Gebruiker:Smile4ever/test Getting 1 page from wikipedia:nl... Waiting for remaining 1 threads to finish, please wait... *[[Gebruiker:Smile4ever/test]] links to http://nl.wikipedia.org/wiki/Koe_(rund - 404 Not Found. Saving history...

----------------------------------------------------------------------

Comment By: xqt (xqt)

Date: 2013-04-20 10:39

Message: reopened due to patch # 3455789, committed code r9797

----------------------------------------------------------------------

Comment By: Harmen (harmenhuizinga) Date: 2013-04-17 09:54

Message: Now it works for me. Thanks.

----------------------------------------------------------------------

Comment By: Amir (amird) Date: 2013-04-17 08:53

Message: I made r11378 to fix it, please test it again I removed parenthesis per http://www.ietf.org/rfc/rfc2396.txt which has considered ")" as a unreserved character (means using ")" at end of the URL causes no harm and It's possible) but maybe I'm wrong which means we should do another way (percent-encoding urls before sending it this URL compiler)

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=3610818...