jayvdb created this task. jayvdb assigned this task to valhallasw. jayvdb added a subscriber: jayvdb. jayvdb added projects: pywikibot-core, Pywikibot-pagegenerators.
TASK DESCRIPTION In the event of a problem in socketio_client, the log messages are discarded, with the logging layer emitting one notice to indicate that this has happened: ``` No handlers could be found for logger "socketIO_client" ```
When a logger was added for T85717 , we see that the problem was a critical disconnection, with an informative message: ``` WARNING:socketIO_client:[connection error] connection closed () ```
I'm not sure that adding a socketIO_client" logger is the right thing to do. Ideally, pywikibot is catching exceptions and these messages are logged using the "pywiki-rcstream" logger. But we need logging soon, if we're to diagnose problems that occur.
As pywikibot is not currently catching this exception (which I believe is coming from websocket), we need to investigate that. Communication of important connection status changes might be happening via other mechanisms, like the generic handlers or by callbacks.
TASK DETAIL https://phabricator.wikimedia.org/T86506
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw, jayvdb Cc: Aklapper, jayvdb, pywikipedia-bugs
valhallasw added a comment.
Yeah, it's being handled within SocketIO, just not the way we'd like it to be (no Exceptions are thrown!). We probably just want to re-log those messages as pywikibot.rcstream messages.
TASK DETAIL https://phabricator.wikimedia.org/T86506
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Aklapper, jayvdb, pywikipedia-bugs
valhallasw added a comment.
https://gerrit.wikimedia.org/r/#/c/184414/ should give a temporary logging solution so we can see what's going on.
TASK DETAIL https://phabricator.wikimedia.org/T86506
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Aklapper, jayvdb, pywikipedia-bugs
valhallasw placed this task up for grabs. valhallasw set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T86506
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: jayvdb, valhallasw, Aklapper, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org