https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
Web browser: --- Bug ID: 58188 Summary: fixing_redirects.py crashes on [[../]] Product: Pywikibot Version: compat (1.0) Hardware: All OS: All Status: NEW Severity: major Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: jan.dudik@gmail.com Classification: Unclassified Mobile Platform: ---
E:\py>fixing_redirects.py -start:! -family:wikiversity
Acer Aspire One <<<
Getting 6 pages from wikiversity:cs... Sleeping for 4.6 seconds, 2013-12-08 21:47:35
Acer Aspire One/Kychot <<<
Getting 13 pages from wikiversity:cs... Sleeping for 5.8 seconds, 2013-12-08 21:47:43 Bad title value '../' Traceback (most recent call last): File "E:\py\fixing_redirects.py", line 231, in <module> main() File "E:\py\fixing_redirects.py", line 225, in main workon(page) File "E:\py\fixing_redirects.py", line 176, in workon target = page2.getMovedTarget() File "E:\py\wikipedia.py", line 3126, in getMovedTarget lastmove = gen.next()['move'] File "E:\py\wikipedia.py", line 7813, in logpages raise BadTitle pywikibot.exceptions.BadTitle
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
JAn Dudík jan.dudik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|Unprioritized |Normal
--- Comment #1 from JAn Dudík jan.dudik@gmail.com --- another crash (unknown reason):
Biofyzika: Úvod <<<
Getting 11 pages from wikiversity:cs... Traceback (most recent call last): File "E:\py\fixing_redirects.py", line 231, in <module> main() File "E:\py\fixing_redirects.py", line 225, in main workon(page) File "E:\py\fixing_redirects.py", line 179, in workon target = pywikibot.Page(mysite, lastmove['new_title']) NameError: global name 'lastmove' is not defined
E:\py>
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #2 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 100391 had a related patch set uploaded by Xqt: (bug 58188) global name 'lastmove' is not defined but obsolete
https://gerrit.wikimedia.org/r/100391
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
xqt info@gno.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |info@gno.de
--- Comment #3 from xqt info@gno.de --- I fixed the second failure in gerrit:100391
Indeed "../" is a relative path and not a valid page title. We may keep this bug open for further enhencements to enable relative paths.
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #4 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 100391 merged by jenkins-bot: (bug 58188) global name 'lastmove' is not defined but obsolete
https://gerrit.wikimedia.org/r/100391
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
Amir Ladsgroup ladsgroup@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ladsgroup@gmail.com
--- Comment #5 from Amir Ladsgroup ladsgroup@gmail.com --- Can you check that again and confirm that the problem got solved?
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #6 from xqt info@gno.de --- It is not solved for a relative path like "../" because it is not a valid title and pywikibot cannot solve it (yet). Maybe it's an enhancement.
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #7 from JAn Dudík jan.dudik@gmail.com --- For the secound cause it works fine. But with crashes on [[../]] is this script still less usefull. What about hack - ignoring this titles until there is any better patch?
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #8 from xqt info@gno.de --- Just ignoring pages with bad titles instead of raising the exception would be possible.
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #9 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 101899 had a related patch set uploaded by Xqt: (bug 58188) Ignore BadTitle Error
https://gerrit.wikimedia.org/r/101899
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #10 from xqt info@gno.de --- JAn, could you try my last patch in gerrit 101899?
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #11 from JAn Dudík jan.dudik@gmail.com --- It took me several minutes to find right link to diff (damned git, why is diff hidden under small (gitblit) link and not under big M fixing_redirects.py +1, -1 *Side-by-Side* ?) and few seconds to modify my local file.
It seems good, bot skips ../ and no more crashes.
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
--- Comment #12 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 101899 merged by jenkins-bot: (bug 58188) Ignore BadTitle Error
https://gerrit.wikimedia.org/r/101899
https://bugzilla.wikimedia.org/show_bug.cgi?id=58188
xqt info@gno.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED
pywikipedia-bugs@lists.wikimedia.org