https://bugzilla.wikimedia.org/show_bug.cgi?id=55583
Web browser: --- Bug ID: 55583 Summary: Generate user config files at runtime, not install time Product: Pywikibot Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED Severity: normal Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: yardenack@gmail.com Classification: Unclassified Mobile Platform: ---
I'm packaging pywikibot for Arch Linux here: https://aur.archlinux.org/packages/python2-pywikibot-git/
Packing software for distribution means that install scripts might be run by a different person than the user. Install scripts are not the place for user config, and it's also bad practice to force ANY interactive configs at that stage.
Please don't run generate_user_files.py from setup.py. Find some way to do this at runtime.
Or, ideally, to behave sanely with no configs at all.
At the moment we are just providing a sample config for users to edit, and doing: sed -i /generate_user_files.py/Id setup.py
https://bugzilla.wikimedia.org/show_bug.cgi?id=55583
Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|Unprioritized |High Status|UNCONFIRMED |NEW CC| |legoktm.wikipedia@gmail.com Version|unspecified |core (2.0) Ever confirmed|0 |1 Severity|normal |major
--- Comment #1 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- This also blocking packaging for pypi as well.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55583
--- Comment #2 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 101662 had a related patch set uploaded by Merlijn van Deen: (bug 55583) Do not create user-config if stdin is not a tty
https://gerrit.wikimedia.org/r/101662
https://bugzilla.wikimedia.org/show_bug.cgi?id=55583
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=55583
--- Comment #3 from Merlijn van Deen valhallasw@arctus.nl --- yar, does this solve the issue on your end? Rewriting the user-config stuff to behave more sanely (which includes not requiring a user-config to begin with) is a longer-term project.
https://bugzilla.wikimedia.org/show_bug.cgi?id=55583
--- Comment #4 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 101662 merged by jenkins-bot: (bug 55583) Do not create user-config if stdin is not a tty
https://gerrit.wikimedia.org/r/101662
https://bugzilla.wikimedia.org/show_bug.cgi?id=55583
xqt info@gno.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|PATCH_TO_REVIEW |RESOLVED CC| |info@gno.de Resolution|--- |FIXED
https://bugzilla.wikimedia.org/show_bug.cgi?id=55583
--- Comment #5 from yardenack@gmail.com --- This works, thanks!
pywikipedia-bugs@lists.wikimedia.org