Benjavalero created this task. Benjavalero added a subscriber: Benjavalero. Benjavalero added a project: pywikibot-core. Benjavalero changed Security from none to none.
TASK DESCRIPTION I am proposing in this issue a patch to improve the algorithm to replace text with exceptions. I have found that the current algorithm process the exception regexes many times, and this can be avoided. In my tests, with my patch in long text pages I obtain significant performance improvements.
I understand this patch touches a critical part of the pywikibot code, so unit tests should be provided, but I am Python newbie and I am afraid that testing in Python is a little out of my knowledge without a bit of guidance.
I hope you could test the patch and confirm my results.
TASK DETAIL https://phabricator.wikimedia.org/T85037
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Benjavalero Cc: Aklapper, Benjavalero, jayvdb, pywikipedia-bugs
Benjavalero added a comment.
The patch:
F22650: new_replace_algorithm.patch https://phabricator.wikimedia.org/F22650
TASK DETAIL https://phabricator.wikimedia.org/T85037
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Benjavalero Cc: Aklapper, Benjavalero, jayvdb, pywikipedia-bugs
XZise added a subscriber: XZise. XZise added a comment.
We use Gerrit https://gerrit.wikimedia.org/r/#/projects/pywikibot/core,dashboards/default to provide patches so it'd be appreciated if you could upload it there. This would allow us to easily test it and discuss the changes directly on the file(s).
TASK DETAIL https://phabricator.wikimedia.org/T85037
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: Aklapper, Benjavalero, XZise, jayvdb, pywikipedia-bugs
Ricordisamoa added a subscriber: Ricordisamoa.
TASK DETAIL https://phabricator.wikimedia.org/T85037
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Aklapper, Benjavalero, XZise, Ricordisamoa, jayvdb, pywikipedia-bugs
gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 181360 had a related patch set uploaded (by Mpaa): textlib: Improve replace algorithm
https://gerrit.wikimedia.org/r/181360
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T85037
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: Aklapper, Benjavalero, XZise, Ricordisamoa, jayvdb, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org