jayvdb created this task. jayvdb added subscribers: jayvdb, pywikipedia-bugs. jayvdb added projects: Pywikibot-Cosmetic-changes, pywikibot-core. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION before cosmetic changes script can be moved to the pywikibot library, its dependency on the isbn script needs to be decoupled.
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: pywikipedia-bugs, jayvdb, Aklapper
Ladsgroup added a subscriber: Ladsgroup. Ladsgroup added a comment.
I think the isbn.py should be moved to the pywikibot as a whole and then we make a wrapper to in scripts folder so people would be able to run it as a script.
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
Ladsgroup added a comment.
like the cosmetic_changes.py
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
jayvdb added a comment.
We do not need all of the deprecated stuff from isbn.py . We need to pick one of the isbn libraries added in https://phabricator.wikimedia.org/T85240, which will become a formal dependency in setup.py and requirements.txt , and possible copy the wrapper around it from isbn.py into the pywikibot library.
Are any of the ISBN libraries already available / in use on https://phabricator.wikimedia.org/tag/tool-labs/ ?
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
Ladsgroup added a comment.
Deprecated stuff should be removed honestly. so I suggest that at first make stdnum a required dependency and then remove all of unneeded stuff from scripts/isbn.py and them move it to the pywikibot directory
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
jayvdb added a comment.
In https://phabricator.wikimedia.org/T89993#1051089, @Ladsgroup wrote:
Deprecated stuff should be removed honestly. so I suggest that at first make stdnum a required dependency and then remove all of unneeded stuff from scripts/isbn.py and them move it to the pywikibot directory
Well, it isnt even @deprecated yet. It is easy to leave it where it is, deprecate it, and remove it after pywikibot is released onto pypi and we can start work on a new version of pywikibot.
I am not seeing anything in isbn.py that would be desirable in the pywikibot library. When we pick an isbn library and make it a dependency, cosmetic changes can use that library directly, or if we want to support multiple isbn libraries we can create a much neater wrapper in pywikibot.tools.isbn .
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
Ladsgroup added a comment.
It's @deprecated because it's not a part of the pywikibot library and except cosmetic_changes no script uses it (specially the internal methods) and I highly doubt that people are using these methods in their self-written codes (again since it's not a part of the library yet) so I think this step is unnecessary.
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup Cc: Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a comment.
Change 205837 had a related patch set uploaded (by John Vandenberg): Remove cosmetic changes dependency on isbn script
https://gerrit.wikimedia.org/r/205837
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
gerritbot added a project: Patch-For-Review.
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
gerritbot added a comment.
Change 205837 merged by jenkins-bot: Remove cosmetic changes dependency on isbn script
https://gerrit.wikimedia.org/r/205837
TASK DETAIL https://phabricator.wikimedia.org/T89993
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
Liuxinyu970226 added a subscriber: Liuxinyu970226.
TASK DETAIL https://phabricator.wikimedia.org/T89993
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Liuxinyu970226 Cc: Liuxinyu970226, gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
jayvdb closed blocking task T89996: Add isbn package dependency as "Resolved".
TASK DETAIL https://phabricator.wikimedia.org/T89993
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Liuxinyu970226, gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
jayvdb closed this task as "Resolved". jayvdb claimed this task.
TASK DETAIL https://phabricator.wikimedia.org/T89993
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Liuxinyu970226, gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
Liuxinyu970226 removed a subscriber: Liuxinyu970226.
TASK DETAIL https://phabricator.wikimedia.org/T89993
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Liuxinyu970226 Cc: gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
Xqt closed blocking task T89998: cosmetic changes has no tests as "Resolved".
TASK DETAIL https://phabricator.wikimedia.org/T89993
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Xqt Cc: gerritbot, Ladsgroup, jayvdb, Aklapper, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org