Strainu created this task. Strainu added a subscriber: Strainu. Strainu added a project: pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION The protocol used by pywikibot (http or https) should be retrieved from user preferences. Right now it is hardcoded to https for Wikimedia Sites.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Strainu Cc: pywikipedia-bugs, Aklapper, Strainu, jayvdb
XZise added a subscriber: XZise. XZise triaged this task as "Low" priority. XZise added a comment.
In a pinch you could change the protocol for each family (see 'def protocol' in the `WikimediaFamily` class in family.py). Are you behind a firewall which blocks HTTPS requests? Because I think if that is added, it should be an option to switch off HTTPS (if those requests are blocked). But I don't see a reason why a specific site shouldn't be contacted via HTTPS but the rest are (or HTTPS is for everyone unavailable).
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, Aklapper, Strainu, jayvdb, pywikipedia-bugs
Strainu added a comment.
I agree that this option should apply to all sites - feel free to ignore the part about Wikimedia.
The use-case that led me to log this bug is that i'm having trouble with a specific HTTPS request and I wanted to debug the issue by checking if HTTP works.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Strainu Cc: XZise, Aklapper, Strainu, jayvdb, pywikipedia-bugs
XZise added a comment.
Okay… can you try it by changing the value that `protocol()` returns in the `WikimediaFamily` in `pywikibot/family.py` https://git.wikimedia.org/blob/pywikibot%2Fcore.git/cc9e368d74375168a4ea17ebb0b2e362963daa24/pywikibot%2Ffamily.py#L1263 to `HTTP`?
I'm not sure if adding that option just for debugging is “worth the trouble”.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, Aklapper, Strainu, jayvdb, pywikipedia-bugs
Strainu added a comment.
It worked, but it is irrelevant IMO. Like I said several times on the mailing list, pywikibot needs to be usable by people with no programming skills. Making them edit a source file might lead to corrupted - thus unusable code.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Strainu Cc: XZise, Aklapper, Strainu, jayvdb, pywikipedia-bugs
XZise added a comment.
Hmpf and? This is a workaround… bug is still open and for anyone to take and implement.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, Aklapper, Strainu, jayvdb, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 186954 had a related patch set uploaded (by XZise): [FEAT] Disable HTTPS option
https://gerrit.wikimedia.org/r/186954
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, XZise, Aklapper, Strainu, jayvdb, pywikipedia-bugs
jayvdb added a subscriber: jayvdb. jayvdb added a comment.
I dont think we should be providing a way for regular users to downgrade from https to http for all families. If a user sets this config var to solve a problem, they may not change it after the problem has been fixed. Also, in order to honour the bot preferences on this matter, we need to first login, so it can only be 'downgrade to http after login'. Family files are the interface for defining how to access each wiki.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, gerritbot, XZise, Aklapper, Strainu, pywikipedia-bugs
Strainu added a comment.
If you believe leaving the option enabled by mistake is an issue, we can throw a warning, like we do for unknown config options.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Strainu Cc: jayvdb, gerritbot, XZise, Aklapper, Strainu, pywikipedia-bugs
valhallasw added a subscriber: valhallasw. valhallasw closed this task as "Declined". valhallasw claimed this task. valhallasw added a comment.
I agree with Jayvdb. There is no obvious gain for normal users (who also wouldn't be debugging whether there's a difference between http and https -- they would just report 'it's not connecting'), and we do increase our code base complexity, which also increases the risk of bugs causing accidental connections over http.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: valhallasw, jayvdb, gerritbot, XZise, Aklapper, Strainu, pywikipedia-bugs
gerritbot added a comment.
Change 186954 abandoned by XZise: [FEAT] Disable HTTPS option
Reason: As the bug was also declined this probably shouldn't get merged.
https://gerrit.wikimedia.org/r/186954
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw, gerritbot Cc: valhallasw, jayvdb, gerritbot, XZise, Aklapper, Strainu, pywikipedia-bugs
Ricordisamoa added a subscriber: Ricordisamoa.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw, Ricordisamoa Cc: Ricordisamoa, valhallasw, jayvdb, gerritbot, XZise, Aklapper, Strainu, pywikipedia-bugs
Ricordisamoa removed a project: Patch-For-Review. Ricordisamoa set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T87461
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw, Ricordisamoa Cc: Ricordisamoa, valhallasw, jayvdb, gerritbot, XZise, Aklapper, Strainu, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org