https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
Bug ID: 73120 Summary: test_image_usage_no_redirect_filter failure Product: Pywikibot Version: core (2.0) Hardware: All OS: All Status: NEW Severity: minor Priority: Unprioritized Component: tests Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: jayvdb@gmail.com Web browser: --- Mobile Platform: ---
First notices in bug 71971 comment 8
https://travis-ci.org/wikimedia/pywikibot-core/jobs/37948029
Then comment 14
https://travis-ci.org/wikimedia/pywikibot-core/jobs/38570786
And now another case
https://travis-ci.org/wikimedia/pywikibot-core/jobs/40263130
FAIL: test_image_usage_no_redirect_filter (tests.site_tests.TestImageUsage) Test the site.imageusage() method with redirects. ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/build/wikimedia/pywikibot-core/tests/site_tests.py", line 698, in test_image_usage_no_redirect_filter self.assertFalse(using.isRedirectPage()) AssertionError: True is not false
The three builds have all been en.wikipedia.
One potential possibility is that the page stops being a redirect during the test run, in which case the 'bug' is in the test case, and not in pywikibot.
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #1 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 171814 had a related patch set uploaded by XZise: Identify which page is no redirect
https://gerrit.wikimedia.org/r/171814
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #2 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 171814 merged by jenkins-bot: Identify which page is no redirect
https://gerrit.wikimedia.org/r/171814
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
Fabian CommodoreFabianus@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|PATCH_TO_REVIEW |NEW CC| |CommodoreFabianus@gmx.de
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #3 from Fabian CommodoreFabianus@gmx.de --- Okay due to the patch we now know it's not that suddenly the page became a non-redirect:
https://travis-ci.org/wikimedia/pywikibot-core/jobs/40348621#L446
So there is something else wrong.
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #4 from Fabian CommodoreFabianus@gmx.de --- Maybe there is a side effect. I checked all four occurences listed here and for all of them the test before 'test_image_usage_in_redirects' failed. I also checked a some other successful tests and there 'test_image_usage_in_redirects' hasn't failed.
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #5 from John Mark Vandenberg jayvdb@gmail.com --- The four also are always python 3.3 builds.
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #6 from John Mark Vandenberg jayvdb@gmail.com --- Again .. a python 3.3 build, and the error occurs after 'test_image_usage_in_redirects' failed.
https://travis-ci.org/wikimedia/pywikibot-core/jobs/40715242
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #7 from John Mark Vandenberg jayvdb@gmail.com --- Same scenario: https://travis-ci.org/wikimedia/pywikibot-core/jobs/40988525
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #8 from Fabian CommodoreFabianus@gmx.de --- And again in both cases the test before that failed.
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #9 from Fabian CommodoreFabianus@gmx.de --- Again a failure and again the previous failed too: https://travis-ci.org/wikimedia/pywikibot-core/jobs/41080800#L483
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|Unprioritized |Normal Blocks| |58053 Severity|minor |major
--- Comment #10 from John Mark Vandenberg jayvdb@gmail.com --- And another https://travis-ci.org/wikimedia/pywikibot-core/jobs/41216356
they all match the same scenario - py3, incorrect data after an exception, so im making this block our py3 port bug and increasing the importance, as incorrect data leaking across page generators doesnt sound particularly good.
https://bugzilla.wikimedia.org/show_bug.cgi?id=73120
--- Comment #11 from Fabian CommodoreFabianus@gmx.de --- And another: https://travis-ci.org/wikimedia/pywikibot-core/jobs/41313071#L483
This issue is weird as I can't see how something could get stuck, except maybe in httplib so it returns the value on the next request. Unfortunately I don't know how I could disrupt it locally so that I get that error too. I tried throwing exceptions in the loop but it didn't care.
pywikipedia-bugs@lists.wikimedia.org