Bugs item #3594792, was opened at 2012-12-11 05:37 Message generated for change (Settings changed) made by amird You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=3594792...

Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: cosmetic changes Group: None

Status: Closed Resolution: Fixed

Priority: 5 Private: No Submitted By: reza (reza1615) Assigned to: Huji Lee (huji) Summary: cosmetic_changes.py bug in persian

Initial Comment: Hi, cosmetic_changes.py has bug in line 740 changes , to ٬ in some cases that text has Latin characters it shouldn't change it http://fa.wikipedia.org/w/index.php?title=%D8%A8%D9%87%D8%A7%D8%B1_%D8%B4%D8... it changed

Zaman Əsgərli, ''XIX əsr Azərbaycan şeri antologiyası'', Bakı, "Şərq-Qərb", 2005, p. 254, ISBN 9952-418-69-5 to Zaman Əsgərli، ''XIX əsr Azərbaycan şeri antologiyası''، Bakı، "Şərq-Qərb"، 2005، p. 254، ISBN 9952-418-69-5 which is not correct please solve it

----------------------------------------------------------------------

Comment By: Huji Lee (huji) Date: 2012-12-28 12:38

Message: Fine. I was trying to push for unit testing these before pushing them. Amird says that these tests have been done before. I assume good faith, and oblige. Amird has a new idea to implement.

----------------------------------------------------------------------

Comment By: xqt (xqt) Date: 2012-12-27 06:04

Message: This is not fixed but ignored

----------------------------------------------------------------------

Comment By: Huji Lee (huji) Date: 2012-12-25 12:34

Message: I meant to say https://www.mediawiki.org/wiki/Special:Code/pywikipedia/10832

----------------------------------------------------------------------

Comment By: Huji Lee (huji) Date: 2012-12-25 12:33

Message: With https://www.mediawiki.org/wiki/Special:Code/pywikipedia/10788 I completely removed the comma conversion. It appears that false positive rate is too high.

----------------------------------------------------------------------

Comment By: reza (reza1615) Date: 2012-12-24 05:33

Message: no it has other bug http://fa.wikipedia.org/w/index.php?title=%D8%A2%D9%84%DB%8C%D8%A7%DA%98%D9%... it changes , to ،

----------------------------------------------------------------------

Comment By: Amir (amird) Date: 2012-12-11 17:52

Message: Dear Reza, I made a change: https://www.mediawiki.org/wiki/Special:Code/pywikipedia/10788 Update your code and run it. is it working correctly?

----------------------------------------------------------------------

You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=3594792...