Bugs item #2876396, was opened at 2009-10-11 03:17 Message generated for change (Comment added) made by xqt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2876396...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: interwiki Group: None
Status: Closed Resolution: Fixed
Priority: 9 Private: No Submitted By: Nakor Wikipedia (nakor-wikipedia)
Assigned to: xqt (xqt)
Summary: interwiki.py is broken
Initial Comment: Pywikipedia [http] trunk/pywikipedia (r7423, 2009/10/10, 16:46:59) Python 2.6 (r26:66714, Jun 8 2009, 16:07:26) [GCC 4.4.0 20090506 (Red Hat 4.4.0-4)]
File "./interwiki.py", line 1746 if page.isTalkPage() ^ SyntaxError: invalid syntax
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2009-10-11 16:05
Message: done in r7427
----------------------------------------------------------------------
Comment By: Mikko Silvonen (silvonen) Date: 2009-10-11 06:35
Message: Yes, a colon seems to be missing. I can't attach files to this bug, but here's a patch:
Index: interwiki.py =================================================================== --- interwiki.py (revision 7423) +++ interwiki.py (working copy) @@ -1743,7 +1743,7 @@ # Only yield pages that have ( ) in titles if "(" not in page.title(): continue - if page.isTalkPage() + if page.isTalkPage(): wikipedia.output(u'Skipping: %s is a talk page' % page.title()) continue break
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2876396...
pywikipedia-bugs@lists.wikimedia.org