https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #1 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- - **summary**: settime for wikidata doesn't work! --> setitem for wikidata doesn't work!

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #3 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- Thank you now it works. please add these tree lines to setitem()

list=data.get() id=list['entity'].replace('q','') data = wikipedia.DataPage(site.data_repository(), "Q"+id)

now we should write these tree lines for every DataPage()

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #5 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- You don't need to create the DataPage a second time with the 'entity' item. Look at this sample which shows that data == d but they are different objects in this sample:

>>> import wikipedia as wp >>> s = wp.getSite() >>> p = wp.Page(s, 'Helium') >>> d = wp.DataPage(p) >>> i = d.get() >>> t = i['entity'].title() >>> data = wp.DataPage(s.data_repository(), t) >>> data DataPage{[[wikidata:Q560]]} >>> d DataPage{[[wikidata:Q560]]} >>> d is data False >>> d == data True >>>

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #7 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- This error looks like you haven't made a DataPage.get() before you tried to update the page. In this cas the title is None as shown. If you recreate the datapage with the entity id you make a explicit get call to retrieve the items data. But this will be enough to get the data's id i.e. the DataPage.title().

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #9 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- I tested it and it worked: http://www.wikidata.org/w/index.php?title=Q5058182&diff=prev&oldid=7... We have showing problem. the code works well I think xqt means if you run this way the showing problem will be solved. something like this notice i just add one line: #!/usr/bin/python # -*- coding: utf-8 -*- import wikipedia,login summary=u'test bot'

site=wikipedia.getSite('fa',fam='wikipedia') fapage=wikipedia.Page(site,u'آبشار_لاتون') data=wikipedia.DataPage(fapage) gett=data.get() data.setitem(summary,items={'type': u'item', 'label': 'glk', 'value':u'آبشار_لاتون'}) data.setitem(summary,items={'type': u'sitelink', 'site': 'glk', 'title':u'آبشار_لاتون_(بارزاو)'})

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #11 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- The line is not useless. If the item doesn't exist you will have an error instead of doing nothing

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #13 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- There are two ways doing that task creating an item; i'll explain it with a pseudocode:

1st: repo = repository(localpage) try: repo.createitem() except itemExistError: print repo.title(), 'already exist'

2st: repo = repository(localpage) if not repo.exists(): repo.createitem() else: print repo.title(), 'allready exits'

I prefer the last one. Look at this sample: >>> import wikipedia as wp >>> p = wp.Page('de', 'Helium') >>> d = wp.DataPage(p) >>> d DataPage{[[wikidata:None]]} >>> d.exists() True >>> d DataPage{[[wikidata:Q560]]} >>>

This means you does not need to call DataPage.get() you may also use DataPage.exists() for this test.

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #15 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- How could you update an item without knowing its content?

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #17 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- What does you meen with .get is not necessary? For getting a content, create an object and assign it to an alias:

# rewrite branch myPage = wikipedia.Page(wikipedia.getSite(), 'Helium') content = myPage.text myPage.text = u'This is a new content' myPage.put() # put it to the web

# trunk release myPage = wikipedia.Page(wikipedia.getSite(), 'Helium') content = myPage.get() content = u'This is a new content' myPage.put(content) # put it to the web

# wikidata myData = wikipedia.DataPage(1234) entity = myData.get() content = {...} myData.setitem('changing an item', content) # put it to the web

In all three samples you do not need to call the getter. But for that case you derived a DataPage from a Page object you have explicit to retrieve the data from the repository site before you can put any data back. Ok I guess you expect something like this should be possible:

myPage = wikipedia.Page(wikipedia.getSite(), 'Helium') myData = wikipedia.DataPage(myPage) content = {...} myData.setitem('changing an item', content) # put it to the web

Am I right?

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

--- Comment #19 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- Ok I agree. Sorry for misunderstanding you.

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://sourceforge.net/p/p | |ywikipediabot/bugs/1587

https://bugzilla.wikimedia.org/show_bug.cgi?id=55149

Amir Ladsgroup ladsgroup@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Priority|Unprioritized |Lowest CC| |ladsgroup@gmail.com, | |reza.energy@gmail.com Version|unspecified |compat (1.0) Summary|setitem for wikidata |DataPage should get the |doesn't work! |content once defined Severity|normal |enhancement

--- Comment #21 from Amir Ladsgroup ladsgroup@gmail.com --- After lots of discussions people agreed to add .get() once a person defines a DataPage. I strongly disagree and (we don't run get() once we define a Page).

Honestly I think we need to close this as WONTFIX