Patches item #2781280, was opened at 2009-04-25 21:38 Message generated for change (Settings changed) made by nicdumz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781280...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Tieum P (tieump) Assigned to: Nobody/Anonymous (nobody) Summary: Patch for incorrect interwikis removal (bug#2780256)
Initial Comment: Please find attached patch that solve problem in bug #2780256
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz) Date: 2009-04-26 04:54
Message: Yes! Correct!
Thanks for helping It came from r6992:
- if page in self.done: #XXX: Ugly bugfix - the following line has reportedly thrown "ValueError: list.remove(x): x not in list" - self.done.remove(page) + self.done = PageTree()
My tired eyes were reading "for page in self.done", which was... indeed a very Ugly bugfix. I applied a modified version of your patch in r6721. Thanks ;)
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781280...
pywikipedia-bugs@lists.wikimedia.org