jayvdb created this task. jayvdb added subscribers: jayvdb, Legoktm, hashar, Ricordisamoa. jayvdb added projects: Continuous-Integration, pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION Patches uploaded by developers with +2 rights are not being 'lint' -ed.
PS6 on https://gerrit.wikimedia.org/r/#/c/168948/ was uploaded by @Ricordisamoa , who has +2 rights, but only the 'noop' job was run by jenkins.
See T64429 and T87169 for other solutions, but this task is about whitelisting +2 'ers.
Can that whitelisting be done automatically? If not, someone needs to manually update the whitelist :/ .
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: pywikipedia-bugs, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg
Mpaa added a subscriber: Mpaa. Mpaa added a comment.
If someone can explain to me how to get the +2 list, I can submit the patch.
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Mpaa Cc: Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
Ricordisamoa added a comment.
In https://phabricator.wikimedia.org/T87413#993347, @Mpaa wrote:
If someone can explain to me how to get the +2 list, I can submit the patch.
https://gerrit.wikimedia.org/r/#/admin/groups/514,members
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 186611 had a related patch set uploaded (by Mpaa): Whitelist pywikibot people with 2 rights
https://gerrit.wikimedia.org/r/186611
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
XZise added a subscriber: XZise. XZise added a comment.
@Mpaa if you want to make it more automatic, you can query the members via SSH: `ssh -p 29418 gerrit.wikimedia.org gerrit ls-members pywikibot`.
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
Mpaa added a comment.
Can someone approve this?
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Mpaa Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
gerritbot added a comment.
Change 186611 merged by jenkins-bot: Whitelist pywikibot people with 2 rights
https://gerrit.wikimedia.org/r/186611
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
hashar closed this task as "Resolved". hashar claimed this task. hashar added a comment.
Should be good now :-)
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
Mpaa removed a project: Patch-For-Review. Mpaa set Security to none.
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar, Mpaa Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
jayvdb added a comment.
In https://phabricator.wikimedia.org/T87413#1011062, @hashar wrote:
Should be good now :-)
@mpaa uploaded a new PS, and only the noop test ran.
https://gerrit.wikimedia.org/r/#/c/171780/
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar, jayvdb Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
hashar added a comment.
The patchset uploaded by @Mpaa occurred BEFORE I got the change deployed. He can either comment 'recheck' or upload a new patchset and that should get the job to run.
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
Mpaa added a comment.
Rebased https://gerrit.wikimedia.org/r/#/c/89026/: and it looks OK. Thanks.
TASK DETAIL https://phabricator.wikimedia.org/T87413
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar, Mpaa Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
hashar moved this task to Done on the Continuous-Integration workboard.
TASK DETAIL https://phabricator.wikimedia.org/T87413
WORKBOARD https://phabricator.wikimedia.org/project/board/401/
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hashar Cc: XZise, gerritbot, Mpaa, Aklapper, Ricordisamoa, hashar, Legoktm, jayvdb, greg, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org