https://bugzilla.wikimedia.org/show_bug.cgi?id=73561
Bug ID: 73561 Summary: API incompatibility in Site.pagecategories and Page.categories: withSortKey not supported Product: Pywikibot Version: core-(2.0) Hardware: All OS: All Status: NEW Severity: major Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: jayvdb@gmail.com Web browser: --- Mobile Platform: ---
Site.pagecategories in core does not accept the parameter withSortKey which was present in compat, and no alternative implementation is available.
Page.categories in core even exposes a withSortKey parameter, which is passes to Site.pagecategories, only for it to be ignored.
https://bugzilla.wikimedia.org/show_bug.cgi?id=73561
--- Comment #1 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 148619 had a related patch set uploaded by John Vandenberg: Add param "from_raw_text", "props" to Page.categories()
https://gerrit.wikimedia.org/r/148619
https://bugzilla.wikimedia.org/show_bug.cgi?id=73561
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=73561
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |70936
https://bugzilla.wikimedia.org/show_bug.cgi?id=73561
--- Comment #2 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 174143 had a related patch set uploaded by John Vandenberg: Page.categories parameter withSortKey ignored
https://gerrit.wikimedia.org/r/174143
https://bugzilla.wikimedia.org/show_bug.cgi?id=73561
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|API incompatibility in |Page.categories withSortKey |Site.pagecategories and |ignored |Page.categories: | |withSortKey not supported |
--- Comment #3 from John Mark Vandenberg jayvdb@gmail.com --- (In reply to John Mark Vandenberg from comment #0)
Page.categories in core even exposes a withSortKey parameter
fwiw ... withSortKey parameter isnt in the compat method arguments. However the sort key is populated by getCategoryLinks , which is called by Page.categories if the site doesnt have an API.
https://bugzilla.wikimedia.org/show_bug.cgi?id=73561
--- Comment #4 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 174143 merged by jenkins-bot: Page.categories parameter withSortKey ignored
https://gerrit.wikimedia.org/r/174143
https://bugzilla.wikimedia.org/show_bug.cgi?id=73561
--- Comment #5 from John Mark Vandenberg jayvdb@gmail.com --- Now to work on merging the real fix...
https://gerrit.wikimedia.org/r/148619
pywikipedia-bugs@lists.wikimedia.org