jayvdb created this task. jayvdb claimed this task. jayvdb added subscribers: pywikipedia-bugs, valhallasw, siebrand, Nemo_bis, jayvdb. jayvdb added projects: Pywikibot-i18n, i18n.
TASK DESCRIPTION JSON files have been added to pywikibot/i18n, which now has python and JSON files with the same messages. The JSON files are not used yet, as the code changes to enable JSON have exposed packaging problems that are the subject of RFC https://www.mediawiki.org/wiki/Requests_for_comment/pywikibot_2.0_packaging
We need syntax validation of these JSON files for gerrit submissions, as message changes typically need to be approved quickly (and without errors) so they can be merged and the core & compat i18n submodule updated, before the messages can be used in code changes.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, valhallasw, siebrand, Nemo_bis, jayvdb, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
gerritbot added a project: Patch-For-Review. gerritbot added a comment.
Change 181370 had a related patch set uploaded (by John Vandenberg): Add grunt test to validate i18n JSON
https://gerrit.wikimedia.org/r/181370
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: Aklapper, valhallasw, siebrand, Nemo_bis, jayvdb, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
gerritbot added a comment.
Change 181370 merged by jenkins-bot: Add grunt test to validate i18n JSON
https://gerrit.wikimedia.org/r/181370
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: Aklapper, valhallasw, siebrand, Nemo_bis, jayvdb, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Xqt closed this task as "Resolved". Xqt added a subscriber: Xqt.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Xqt Cc: Aklapper, valhallasw, siebrand, Nemo_bis, jayvdb, Xqt, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
gerritbot added a comment.
Change 182775 had a related patch set uploaded (by Hashar): pywikibot-i18n-npm
https://gerrit.wikimedia.org/r/182775
https://phabricator.wikimedia.org/tag/patch-for-review/
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: Aklapper, valhallasw, siebrand, Nemo_bis, jayvdb, Xqt, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
gerritbot added a comment.
Change 182775 merged by jenkins-bot: pywikibot-i18n-npm
https://gerrit.wikimedia.org/r/182775
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: Aklapper, valhallasw, siebrand, Nemo_bis, jayvdb, Xqt, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
hashar added a subscriber: hashar. hashar added a comment.
i have pushed a npm based Jenkins job and update Zuul configuration. Confirmed it works using the dummy change https://gerrit.wikimedia.org/r/#/c/182778/
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, hashar Cc: Aklapper, valhallasw, siebrand, Nemo_bis, jayvdb, Xqt, hashar, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
jayvdb reopened this task as "Open". jayvdb added a subscriber: XZise. jayvdb added a comment.
@hashar , it doesnt appears to be working by default at https://gerrit.wikimedia.org/r/#/c/196706/ (see PS6) .
Maybe it isnt run because the patch uploader isnt on the whitelist. However it was +1'd by @xzise, so I would expect the test is run. It did run when I added a 'recheck' comment.
This test is a syntax check, not running any untrusted code, so I expect it should run always, irrespective of the uploader of the patch.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
jayvdb added a comment.
We also need to automatically add new JSON bundles to Gruntfile.js, otherwise the test success is misleading.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a comment.
Change 199559 had a related patch set uploaded (by Legoktm): Run jsonlint jobs on pywikibot/i18n patches
https://gerrit.wikimedia.org/r/199559
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
gerritbot added a comment.
Change 199559 merged by jenkins-bot: Run jsonlint jobs on pywikibot/i18n patches
https://gerrit.wikimedia.org/r/199559
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, gerritbot Cc: gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Ladsgroup closed this task as "Resolved". Ladsgroup set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Ladsgroup Cc: gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Ricordisamoa added a subscriber: Ricordisamoa.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Ricordisamoa Cc: Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
jayvdb reopened this task as "Open". jayvdb added a comment.
Re-opening __again__; my comments on mar 25 have not been addressed.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Nemo_bis added a project: Continuous-Integration.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Nemo_bis Cc: Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Legoktm added a subscriber: Legoktm. Legoktm added a comment.
What's still missing exactly? There's a jsonlint job that verifies all JSON files have valid syntax, and is run for all users, whitelisted or not.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Legoktm Cc: Legoktm, Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Legoktm added a subscriber: Jdforrester-WMF. Legoktm added a comment.
Oh, I read too fast. I think you're refering to.
In https://phabricator.wikimedia.org/T85335#1147403, @jayvdb wrote:
We also need to automatically add new JSON bundles to Gruntfile.js, otherwise the test success is misleading.
@Jdforrester-WMF said this should be possible to do with '*' wildcards or regex...?
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Legoktm Cc: Jdforrester-WMF, Legoktm, Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
jayvdb added a comment.
@legoktm, new JS files (e.g. https://gerrit.wikimedia.org/r/#/c/196706/) are not checked by banana whateveritis.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Jdforrester-WMF, Legoktm, Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Krinkle added a subscriber: Krinkle. Krinkle closed this task as "Declined". Krinkle added a comment.
In https://phabricator.wikimedia.org/T85335#1177020, @jayvdb wrote:
@legoktm, new JS files (e.g. https://gerrit.wikimedia.org/r/#/c/196706/) are not checked by banana whateveritis.
The jsonlint job validates syntax in all json files. Including new directories and files therein.
The npm job runs whatever framework you like to use. Bash, Grunt, Gulp, anything. So this task is closed. It's your responsibility (or that of other pywikibot maintainers) to come up with a test strategy and a viable way to maintain that.
For example, you can use Grunt and grunt-banana-checker to validate things specific to the "Banana" format that the Milkshake project https://www.mediawiki.org/wiki/Milkshake came up with. (E.g. the concept of "qqq" files, `@authors` properties and all that.)
Each directory is a separate localisation group with its own qqq file. As such, in order for Banana to be able to find missing qqq entries, it needs to know about each directory.
However, there should be no need to configure each directory by hand. Pywiki's structure looks quite simple. You can scan the top directory from Gruntfile.js and collect the relevant directory names in an array automatically. You can even provide the array in a single test:
initConfig({ banana: { all: [ 'foo/', 'bar/' ] // create this array programmatically after scanning the repo } });
If you prefer the results (and potential errors) to be grouped in the output separately, you'd build it more like the current structure:
var projects = ...; var bananaGroups = {}; projects.forEach( function (project) { bananaGroups[ project ] = project + '/'; } );
initConfig({ banana: bananaGroups });
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Krinkle Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Krinkle changed the task status from "Declined" to "Resolved". Krinkle removed a project: Patch-For-Review.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Krinkle Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Krinkle moved this task to In-progress on the Continuous-Integration workboard.
TASK DETAIL https://phabricator.wikimedia.org/T85335
WORKBOARD https://phabricator.wikimedia.org/project/board/401/
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Krinkle Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Krinkle moved this task to Done on the Continuous-Integration workboard.
TASK DETAIL https://phabricator.wikimedia.org/T85335
WORKBOARD https://phabricator.wikimedia.org/project/board/401/
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Krinkle Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
jayvdb reopened this task as "Open". jayvdb added a comment.
In https://phabricator.wikimedia.org/T85335#1203335, @Krinkle wrote:
However, there should be no need to configure each directory by hand. Pywiki's structure looks quite simple. You can scan the top directory from Gruntfile.js and collect the relevant directory names in an array automatically. You can even provide the array in a single test:
initConfig({ banana: { all: [ 'foo/', 'bar/' ] // create this array programmatically after scanning the repo } });
And this task is open until the check is dynamic , and new bundles in changesets for review are checked.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, gerritbot, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Krinkle removed a subscriber: gerritbot. Krinkle edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure.
TASK DETAIL https://phabricator.wikimedia.org/T85335
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Krinkle Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
Krinkle moved this task to Archive on the Continuous-Integration-Config workboard.
TASK DETAIL https://phabricator.wikimedia.org/T85335
WORKBOARD https://phabricator.wikimedia.org/project/board/1208/
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Krinkle Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, XZise, Xqt, siebrand, Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org