jayvdb created this task. jayvdb added subscribers: jayvdb, Qgil, mmodell. jayvdb added projects: Phabricator, pywikibot-core. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION WMF projects are moving from Gerrit to Differential. Pywikibot team should plan our migration, trialling the Differential code review, comparing it to other options, and feeding the trial results into the public RFC to help inform the broader Pywikibot community decision making.
https://www.mediawiki.org/wiki/Requests_for_comment/pywikibot_git_hosting
TASK DETAIL https://phabricator.wikimedia.org/T95526
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: mmodell, Qgil, jayvdb, Aklapper, jeremyb, pywikipedia-bugs
jayvdb added a blocked task: T560: Proof of concept of code review in Phabricator.
TASK DETAIL https://phabricator.wikimedia.org/T95526
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: mmodell, Qgil, jayvdb, Aklapper, jeremyb, pywikipedia-bugs
Qgil added a comment.
Also relevant: T94167: Opt-in Differential for projects needing code review but not Jenkins/Zuul for continuous integration https://phabricator.wikimedia.org/T94167. We are discussing about working on this at the https://phabricator.wikimedia.org/tag/wikimedia-hackathon-2015/.
TASK DETAIL https://phabricator.wikimedia.org/T95526
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Qgil Cc: mmodell, Qgil, jayvdb, Aklapper, jeremyb, pywikipedia-bugs
jayvdb added a comment.
I guess we can take it for granted that Differential will be easier to use than Gerrit.
One of the other main benefits I foresee is being able to use phab search to find design decisions made in review comments.
github search can do this; e.g. https://github.com/jcgregorio/httplib2/search?utf8=%E2%9C%93&q=Needs+uni...
gerrithub.io might do this, but I am guessing that it will be hard to use.
As a result, it would be a killer feature if we could import our old gerrit discussions into Differential. pywikibot has moved around quite a lot in recent years, making it quite hard to find relevant discussions about complex issues. Extracting the old gerrit discussions isnt too difficult using the Gerrit API; pushing them into Differential might be more difficult.
TASK DETAIL https://phabricator.wikimedia.org/T95526
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: mmodell, Qgil, jayvdb, Aklapper, jeremyb, pywikipedia-bugs
mmodell added a comment.
Importing gerrit comments into differential will be a huge ordeal. I'm not sure a final decision has been made on this. IMO we should not migrate gerrit review history in order to avoid a whole lot of migration hell.
It's not at all easy to migrate reviews and their comments into differential. It will take a dedicated team many many hours to pull it off, it's similar amount of work to the Bugzilla migration and very little of the work that went into that migration can be reused for differential.
TASK DETAIL https://phabricator.wikimedia.org/T95526
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: mmodell Cc: mmodell, Qgil, jayvdb, Aklapper, jeremyb, pywikipedia-bugs
jayvdb added a comment.
Has importing old reviews been attempted at all? I'd be happy to do all the work involved for pywikibot-core if given access or someone with access will review the import script and run it in if there are no issues with it.
TASK DETAIL https://phabricator.wikimedia.org/T95526
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: mmodell, Qgil, jayvdb, Aklapper, jeremyb, pywikipedia-bugs
Ricordisamoa added a subscriber: Ricordisamoa.
TASK DETAIL https://phabricator.wikimedia.org/T95526
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Ricordisamoa, mmodell, Qgil, jayvdb, Aklapper, jeremyb, greg, pywikipedia-bugs
jayvdb added a comment.
@Ricordisamoa , I saw you did a review ; could you add a link to it here?
TASK DETAIL https://phabricator.wikimedia.org/T95526
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ricordisamoa, mmodell, Qgil, jayvdb, Aklapper, jeremyb, greg, pywikipedia-bugs
Ricordisamoa added a comment.
In https://phabricator.wikimedia.org/T95526#1314372, @jayvdb wrote:
@Ricordisamoa , I saw you did a review ; could you add a link to it here?
Here it is: https://lists.wikimedia.org/pipermail/wikitech-l/2015-May/081800.html Whole thread: https://lists.wikimedia.org/pipermail/wikitech-l/2015-May/thread.html#81800
TASK DETAIL https://phabricator.wikimedia.org/T95526
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Ricordisamoa, mmodell, Qgil, jayvdb, Aklapper, jeremyb, greg, pywikipedia-bugs
Revi added a subscriber: Revi.
TASK DETAIL https://phabricator.wikimedia.org/T95526
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Revi Cc: Revi, Ricordisamoa, mmodell, Qgil, jayvdb, Aklapper, jeremyb, greg, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org