https://bugzilla.wikimedia.org/show_bug.cgi?id=70707
Bug ID: 70707 Summary: editEntity using site object depends on py2.7 Product: Pywikibot Version: core (2.0) Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: Wikidata Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: jayvdb@gmail.com Web browser: --- Mobile Platform: ---
WikibasePage.toJSON depends on collections.Counter, which is only available in pu2.7.
WikibasePage.editEntity with data=None uses is the only current caller of WikibasePage.toJSON. This is new functionality, unavailable in compat, so a py 2.7 requirement is not a breaking change.
https://bugzilla.wikimedia.org/show_bug.cgi?id=70707
--- Comment #1 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 159700 had a related patch set uploaded by John Vandenberg: Require 2.7+ for one wikibase test
https://gerrit.wikimedia.org/r/159700
https://bugzilla.wikimedia.org/show_bug.cgi?id=70707
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=70707
Fabian CommodoreFabianus@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |CommodoreFabianus@gmx.de
--- Comment #2 from Fabian CommodoreFabianus@gmx.de --- There is https://pypi.python.org/pypi/Counter/1.0.0 which could be used in 2.6 or we use the recipy directly http://code.activestate.com/recipes/576611-counter-class/
https://bugzilla.wikimedia.org/show_bug.cgi?id=70707
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|Unprioritized |Lowest Severity|normal |minor
--- Comment #3 from John Mark Vandenberg jayvdb@gmail.com --- Indeed. Whereas we knew we needed a backport of OrderedDict for non-Wikibase needs, collections.Counter is so far only needed for Wikibase functionality not available previously or in compat, so we dont need to maintain backwards compatibility. This bug is to ensure it can be found easily. If there are py2.6 users of `core` needing this, we need to know who they are and why.
https://bugzilla.wikimedia.org/show_bug.cgi?id=70707
--- Comment #4 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 159700 merged by jenkins-bot: Require 2.7+ for one wikibase test
https://gerrit.wikimedia.org/r/159700
https://bugzilla.wikimedia.org/show_bug.cgi?id=70707
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|PATCH_TO_REVIEW |NEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=70707
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |70987
pywikipedia-bugs@lists.wikimedia.org