Ricordisamoa created this task. Ricordisamoa added subscribers: Aklapper, pywikipedia-bugs, Ricordisamoa. Ricordisamoa added a project: Pywikibot-General. Ricordisamoa changed Security from none to none.
TASK DESCRIPTION Instead of filling it manually, as it is now.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Aklapper, Ricordisamoa, pywikipedia-bugs
Ricordisamoa edited the task description.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Aklapper, Ricordisamoa, pywikipedia-bugs
jayvdb added a blocking task: T85725: token methods should use the list of tokens in paraminfo.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Aklapper, Ricordisamoa, pywikipedia-bugs
jayvdb closed blocking task T85725: token methods should use the list of tokens in paraminfo as "Resolved".
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Ricordisamoa, Aklapper, pywikipedia-bugs
jayvdb added subscribers: XZise, jayvdb. jayvdb added a comment.
@Ricordisamoa, @xzise, is there anything more to do here now that https://phabricator.wikimedia.org/T85725 is merged?
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
Ricordisamoa added a comment.
In https://phabricator.wikimedia.org/T78393#1169002, @jayvdb wrote:
@Ricordisamoa, @xzise, is there anything more to do here now that https://phabricator.wikimedia.org/T85725 is merged?
https://phabricator.wikimedia.org/T85725 covers the list of valid token types, while this one aims to have the correct token type automatically added to every request. I'm not sure whether one of them blocks the other one.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
Ricordisamoa edited the task description.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
XZise added a comment.
I'm not sure about which tokens @Ricordisamoa is talking. All tokens accessible via `action=tokens`, `action=query&meta=tokens` and `action=query&prop=info&intoken=…` are now loaded initially. So if an extension is using something else it won't load its tokens but I think that is not feasible. But already before it has been loading all/almost all tokens at once, at least for the WMF wikis I think so maybe I'm missing something. Or it was specifically about that TOKENS_[123] are outdated but then it'd be a duplicate of T85725: token methods should use the list of tokens in paraminfo https://phabricator.wikimedia.org/T85725.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
Ricordisamoa added a comment.
@jayvdb more details in the task description.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
Ricordisamoa edited projects, added pywikibot-core, Pywikibot-network; removed Pywikibot-General.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
jayvdb added a comment.
Ah, so this task would be resolved if api.py automatically added the necessary token, using paraminfo. Then site.py wouldnt need to specify which token to use, and this may even mean site.py adapts better to older versions where the token name is different from the new simplified token system.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
XZise added a comment.
Well unfortunately it was added after 1.21.1: http://wiki.kerbalspaceprogram.com/w/api.php?action=paraminfo&modules=ed...
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise Cc: jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a comment.
Change 201159 had a related patch set uploaded (by Ricordisamoa): Detect and add the appropriate tokens to API requests
https://gerrit.wikimedia.org/r/201159
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
gerritbot added a project: Patch-For-Review.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
Ricordisamoa claimed this task. Ricordisamoa added a comment.
I figured out that this is much easier than I thought.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: gerritbot, jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
jayvdb added a comment.
That patch might demonstrate it is easy to do 1.21+, but the hard part (pre 1.21) is ignored. If we remove the token related code from site.py , that patch only supports 1.21. If we leave token related code in site.py API calls, then what benefit is there in this patch?
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa, jayvdb Cc: gerritbot, jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
Ricordisamoa added a comment.
In https://phabricator.wikimedia.org/T78393#1169904, @jayvdb wrote:
That patch might demonstrate it is easy to do 1.21+, but the hard part (pre 1.21) is ignored. If we remove the token related code from site.py , that patch only supports 1.21. If we leave token related code in site.py API calls, then what benefit is there in this patch?
We could remove the token-related code from site.py and add a fallback dict (API module, token types) for pre 1.21.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: gerritbot, jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
jayvdb added a comment.
In https://phabricator.wikimedia.org/T78393#1174600, @Ricordisamoa wrote:
In https://phabricator.wikimedia.org/T78393#1169904, @jayvdb wrote:
That patch might demonstrate it is easy to do 1.21+, but the hard part (pre 1.21) is ignored. If we remove the token related code from site.py , that patch only supports 1.21. If we leave token related code in site.py API calls, then what benefit is there in this patch?
We could remove the token-related code from site.py and add a fallback dict (API module, token types) for pre 1.21.
Sounds good.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa, jayvdb Cc: gerritbot, jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
Ricordisamoa triaged this task as "Low" priority.
TASK DETAIL https://phabricator.wikimedia.org/T78393
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: gerritbot, jayvdb, XZise, Ricordisamoa, Aklapper, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org