Ricordisamoa created this task. Ricordisamoa added subscribers: Ricordisamoa, jayvdb, XZise, valhallasw. Ricordisamoa added a project: Pywikibot-General. Ricordisamoa changed Security from none to none.
TASK DESCRIPTION The [[ //github.com/earwig/mwparserfromhell | mwparserfromhell ]] library allows bot developers to focus on actual code instead of regexes. It should probably be required for many features in pywikibot, not only on *nix.
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Aklapper, Ricordisamoa, jayvdb, XZise, valhallasw, pywikipedia-bugs
zhuyifei1999 added a subscriber: zhuyifei1999.
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999 Cc: Aklapper, Ricordisamoa, jayvdb, XZise, valhallasw, zhuyifei1999, pywikipedia-bugs
Ricordisamoa added a comment.
Any reasons why mwparserfromhell shouldn't be required?
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Aklapper, Ricordisamoa, jayvdb, XZise, valhallasw, zhuyifei1999, pywikipedia-bugs
valhallasw added a comment.
T68010: Windows users get error: Unable to find vcvarsall.bat when using setup.py due to mwparserfromhell https://phabricator.wikimedia.org/T68010
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Aklapper, Ricordisamoa, jayvdb, XZise, valhallasw, zhuyifei1999, pywikipedia-bugs
Ricordisamoa added a subscriber: Earwig. Ricordisamoa added a comment.
So we're waiting for @Earwig...
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: Aklapper, Ricordisamoa, jayvdb, XZise, valhallasw, zhuyifei1999, Earwig, pywikipedia-bugs
valhallasw edited projects, added pywikibot-core; removed Pywikibot-General.
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Aklapper, Ricordisamoa, jayvdb, XZise, valhallasw, zhuyifei1999, Earwig, pywikipedia-bugs
Earwig added a comment.
I thought that issue was caused by an incorrectly set-up Windows build environment, which @valhallasw and I resolved by distributing binaries with releases? I'm not clear on this since I haven't looked in a while, but it seems the underlying problem is https://github.com/earwig/mwparserfromhell/issues/78 blocking py3.3 and py3.4 builds. Would fixing that and releasing v0.4 along with the necessary binaries be sufficient to fix this?
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Earwig Cc: Aklapper, Ricordisamoa, jayvdb, XZise, valhallasw, zhuyifei1999, Earwig, pywikipedia-bugs
valhallasw added a comment.
I think so, yes, and then we (as pywikibot) need to make sure the wheels actually get used on windows (and, for example, figure out how to provide nightlies that include/install mwparserfromhell). But that should really be a more generic 'dependency management' task.
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Aklapper, Ricordisamoa, jayvdb, XZise, valhallasw, zhuyifei1999, Earwig, pywikipedia-bugs
valhallasw edited the task description. valhallasw changed the task status from "Open" to "Stalled". valhallasw triaged this task as "Normal" priority.
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw Cc: Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
jayvdb added a comment.
fwiw, mwparserfromhell 4.0 can now be released with py3.3 & py3.4 support using pure python mode, if nothing else works.
https://github.com/earwig/mwparserfromhell/pull/94
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
jayvdb added a comment.
In setup.py , we could use 'git+https://github.com/earwig/mwparserfromhell' as the dependency url , which will automatically fallback to pure python mode
TASK DETAIL https://phabricator.wikimedia.org/T78378
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
jayvdb added a comment.
yay, mwparserfromhell 4.0 is released.
One of the strongest outcomes of the python wiki library meeting yesterday was that the 'common library' needs to have only one dependency: requests. So if pywikibot is going to be the common library, we need to make mwparserfromhell optional on all platforms.
TASK DETAIL https://phabricator.wikimedia.org/T78378
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a comment.
Change 213480 had a related patch set uploaded (by John Vandenberg): Set mwparserfromhell as optional on all platforms
https://gerrit.wikimedia.org/r/213480
TASK DETAIL https://phabricator.wikimedia.org/T78378
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
gerritbot added a project: Patch-For-Review.
TASK DETAIL https://phabricator.wikimedia.org/T78378
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
Ricordisamoa changed the task status from "Stalled" to "Open". Ricordisamoa added a comment.
Not stalled anymore.
TASK DETAIL https://phabricator.wikimedia.org/T78378
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa Cc: gerritbot, Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
gerritbot added a comment.
Change 213480 merged by XZise: Set mwparserfromhell as optional on all platforms
https://gerrit.wikimedia.org/r/213480
TASK DETAIL https://phabricator.wikimedia.org/T78378
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
jayvdb closed this task as "Resolved". jayvdb claimed this task.
TASK DETAIL https://phabricator.wikimedia.org/T78378
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
Ricordisamoa removed a subscriber: gerritbot. Ricordisamoa removed a project: Patch-For-Review.
TASK DETAIL https://phabricator.wikimedia.org/T78378
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, Ricordisamoa Cc: Earwig, jayvdb, valhallasw, Ricordisamoa, Aklapper, XZise, zhuyifei1999, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org