https://bugzilla.wikimedia.org/show_bug.cgi?id=61310
Web browser: --- Bug ID: 61310 Summary: version.py does not recognize SVN checkout Product: Pywikibot Version: core (2.0) Hardware: All OS: All Status: NEW Severity: major Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: russblau@hotmail.com Mobile Platform: ---
The following block starts at line 48 of pywikibot/version.py:
_program_dir = _get_program_dir() if os.path.isdir(os.path.join(_program_dir, '.svn')): (tag, rev, date, hsh) = getversion_svn(_program_dir) else: (tag, rev, date, hsh) = getversion_git(_program_dir)
I ran this on a machine where I am still using the SVN mirror and haven't installed git. However, "os.path.join(_program_dir, '.svn')" does not suffice to locate my .svn directory, because I checked out the entire "core" project, including both trunk and branches. The ".svn" directory therefore is in the parent directory above _program_dir, not in _program_dir.
This causes my installation to be unable to import pywikibot.
https://bugzilla.wikimedia.org/show_bug.cgi?id=61310
Merlijn van Deen valhallasw@arctus.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |valhallasw@arctus.nl
--- Comment #1 from Merlijn van Deen valhallasw@arctus.nl --- https://gerrit.wikimedia.org/r/#/c/113185/ should at least provide a workaround for this (the version will not be detected, but the bot should not crash...)
https://bugzilla.wikimedia.org/show_bug.cgi?id=61310
Sorawee Porncharoenwase nullzero.free@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nullzero.free@gmail.com Resolution|--- |FIXED
--- Comment #2 from Sorawee Porncharoenwase nullzero.free@gmail.com --- It does not crash anymore. Thank you :))
https://bugzilla.wikimedia.org/show_bug.cgi?id=61310
Sorawee Porncharoenwase nullzero.free@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |---
--- Comment #3 from Sorawee Porncharoenwase nullzero.free@gmail.com --- Decide to open it again as the version is still not able to be detected although it does not crash anymore.
https://bugzilla.wikimedia.org/show_bug.cgi?id=61310
--- Comment #4 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 157808 had a related patch set uploaded by XZise: [FIX] Support branched svn directories
https://gerrit.wikimedia.org/r/157808
https://bugzilla.wikimedia.org/show_bug.cgi?id=61310
Gerrit Notification Bot gerritadmin@wikimedia.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |PATCH_TO_REVIEW
https://bugzilla.wikimedia.org/show_bug.cgi?id=61310
--- Comment #5 from Gerrit Notification Bot gerritadmin@wikimedia.org --- Change 157808 merged by jenkins-bot: [FIX] Support branched svn directories
https://gerrit.wikimedia.org/r/157808
https://bugzilla.wikimedia.org/show_bug.cgi?id=61310
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|PATCH_TO_REVIEW |RESOLVED CC| |jayvdb@gmail.com Resolution|--- |FIXED
pywikipedia-bugs@lists.wikimedia.org