jayvdb added a subscriber: jayvdb. jayvdb added a comment. See http://mapping.referata.com/w/api.php?action=query&format=jsonfm&me… { "query": { "repos": [ { "name": "shared", "displayname": "a shared repository", "rootUrl": "/w/images", "local": false, "apiurl": "http://commons.wikimedia.org/w/api.php", "articlepath": "/wiki/$1", "server": "//commons.wikimedia.org" }, { "name": "local", "displayname": null, "rootUrl": "/w/images", "local": true } ] } } vs http://en.wikipedia.org/w/api.php?action=query&meta=filerepoinfo&fr… { "warnings": { "filerepoinfo": { "*": "Unrecognized values for parameter 'friprop': apiurl, articlepath, server" }, "query": { "*": "Formatting of continuation data will be changing soon. To continue using the current formatting, use the 'rawcontinue' parameter. To begin using the new format, pass an empty string for 'continue' in the initial query." } }, "query": { "repos": [ { "name": "shared", "displayname": "Wikimedia Commons", "rootUrl": "//upload.wikimedia.org/wikipedia/commons", "local": false }, { "name": "local", "displayname": "Wikipedia", "rootUrl": "//upload.wikimedia.org/wikipedia/en", "local": true } ] } } Maybe it is something special about WMF projects that is causing filerepoinfo to not work correctly? TASK DETAIL https://phabricator.wikimedia.org/T85153 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, XZise, Anomie, jayvdb, Legoktm, pywikipedia-bugs

Anomie added a comment. In https://phabricator.wikimedia.org/T85153#940817, @jayvdb wrote: filerepoinfo is working correctly. The difference is that the referata.com site is using ForeignAPIRepo while WMF wikis use ForeignDBViaLBRepo, and the two classes supply different information. In https://phabricator.wikimedia.org/T85153#941093, @XZise wrote: That depends on how the repo is configured on each wiki. Presumably the "shared" repo there is using ForeignDBRepo or ForeignDBViaLBRepo, while the "wikimediacommons" repo is using ForeignAPIRepo. The name used also entirely depends on how the repos are configured on each wiki. Instead of focusing on the fact that things are different without any context, you'd probably be better served by trying to work out which bits of information are possible to standardize across the different FileRepo subclasses based on the configuration options each receives. TASK DETAIL https://phabricator.wikimedia.org/T85153 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Aklapper, XZise, Anomie, jayvdb, Legoktm, pywikipedia-bugs

XZise added a comment. Hmm okay from a bot standpoint it's pretty hard to determine the site a repo is actually using. And that would be helpful for example to determine a username and to get information about the file there. I know it's probably hard because how would you identify such a site, but that would save quite a bit of manual managing on our side (as we don't need to save that 'shared' on en.wikipedia.org is actually 'commons'). TASK DETAIL https://phabricator.wikimedia.org/T85153 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: Aklapper, XZise, Anomie, jayvdb, Legoktm, Tgr, pywikipedia-bugs

jayvdb added a comment. @Tgr, yes, that is about it. pywikibot currently has two main site concepts: 'BaseSite' and subclass 'APISite'. We have a FilePage class, and instances may be local or shared files. As an absolute minimum, we need to be able to: 1. determine if a FilePage is for a local or non-local file. and 2. get the URL of the original file, or at least fetch the original file However it would be much nicer if we could obtain an APISite object for the site which hosts the actual file and a FilePage. e.g. if the FilePage for a shared file needs to be edited, it likely needs to be edited on the shared host, not on the local site. So ideally we have a method like FilePage(enwp, 'File:Logo.png').get_shared() that returns a FilePage(commons, 'File:Logo.png'). And we need to do the same for any foreign repo. See https://phabricator.wikimedia.org/T74847 - fileIsShared only works with Wikimedia and Wikitravel shared repository and https://gerrit.wikimedia.org/r/#/c/181416/ - Get shared FilePage and make checks semi-dynamic TASK DETAIL https://phabricator.wikimedia.org/T85153 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Aklapper, XZise, Anomie, jayvdb, Tgr, Legoktm, pywikipedia-bugs

Anomie added a comment. In https://phabricator.wikimedia.org/T85153#943695, @XZise wrote: Theoretically yes, although I'm not aware of any implementations. All it would require would be someone implementing FileRepo and File subclasses that access the backend site via whatever interface it provides, following the model of ForeignAPIRepo and ForeignAPIFile. TASK DETAIL https://phabricator.wikimedia.org/T85153 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie Cc: Aklapper, XZise, Anomie, jayvdb, Tgr, Legoktm, pywikipedia-bugs

Gilles added a project: Multimedia. TASK DETAIL https://phabricator.wikimedia.org/T85153 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Gilles Cc: Aklapper, XZise, Anomie, jayvdb, Tgr, Fabrice_Florin, Gilles, Legoktm, pywikipedia-bugs

Tgr added a comment. In https://phabricator.wikimedia.org/T85153#963274, @XZise wrote: For local repos, you can use `articlepath` from the siteinfo API. For API-based foreign repos, `articlepath` and `server`is included in the filerepoinfo API output. For shared-DB foreign repos, you can use `descBaseUrl`. See http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&meta=filere… for an example which has all three kinds of repos and uses code from master. It would be nicer to have a property which has the same name and semantics for all three, not sure if that's important enough to create duplicate properties though. TASK DETAIL https://phabricator.wikimedia.org/T85153 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Aklapper, XZise, Anomie, jayvdb, Tgr, Fabrice_Florin, Gilles, Legoktm, pywikipedia-bugs