https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
Web browser: --- Bug ID: 54573 Summary: rvdiffto parameter implementation Product: Pywikibot Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: Unprioritized Component: General Assignee: Pywikipedia-bugs@lists.wikimedia.org Reporter: legoktm.wikipedia@gmail.com Classification: Unclassified Mobile Platform: ---
Originally from: http://sourceforge.net/p/pywikipediabot/patches/447/ Reported by: Anonymous user Created on: 2010-05-27 03:19:29 Subject: rvdiffto parameter implementation Original description: No revisions diff text loading function is implemented in the framework. Here is one:
Changelog: Modified site.loadrevisions() method to support rvdiffto parameter. Added a Page.Revision.Diff class for storing the diff text and revto id. Modified api.update_page() to save the new diff information.
A method from Page.py is still missing to get diffs just like you get a revision now. But you can get the diff text from page._revision[id].diff.text directly for now.
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
--- Comment #1 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- rvdiffto parameter implementation
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
--- Comment #2 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- Sorry for the slow slow slow sloooow response.
I think diffs are a useful thing to have, but I'm not quite sure what the goal here is - what is the advantage of using rvdiffto instead of getting both revisions and comparing them with a python diff function?
I can see the use case for, for instance, an antivandalism bot, but I'm not quite sure how you would use it with this.
Then on the implementation - I can imagine it makes sense to store diffs for a certain revision, but I'd expect, for instance, a dict with revid's such that
page, revid=10001 diffs = {10000: <diff object between 10000 and 10001>, 9000: <diff object between 9000 and 10001>}, and storing e.g. revision.prev = 10000.
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
--- Comment #3 from Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com --- housekeeper's note:the patch does not apply cleanly to r10035
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
Kunal Mehta (Legoktm) legoktm.wikipedia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://sourceforge.net/p/p | |ywikipediabot/patches/447
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
--- Comment #4 from Ricordisamoa ricordisamoa@live.it --- I do not think we should go with this.
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
Amir Ladsgroup ladsgroup@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|Unprioritized |Normal CC| |ladsgroup@gmail.com Summary|rvdiffto parameter |Add diff method for |implementation |revisions Severity|normal |enhancement
--- Comment #5 from Amir Ladsgroup ladsgroup@gmail.com --- Since the patch is really old and lots of changes made to base repo, the whole patch needs to be rewritten. Personally I think it's cool to have something like this
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |70936
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |CommodoreFabianus@gmx.de, | |jayvdb@gmail.com, | |mpaa.wiki@gmail.com, | |valhallasw@arctus.nl
--- Comment #6 from John Mark Vandenberg jayvdb@gmail.com --- Any idea who created this patch. sf.net just says 'Anonymous' ;-(
Related: we now have a module pywikibot.diff which could be used to do the diff client site.
https://bugzilla.wikimedia.org/show_bug.cgi?id=54573
John Mark Vandenberg jayvdb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.wikimedia. | |org/show_bug.cgi?id=58819
pywikipedia-bugs@lists.wikimedia.org