jayvdb created this task. jayvdb added a subscriber: jayvdb. jayvdb added projects: pywikibot-core, pywikibot-compat. Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION pywikibot has had special support for SVN version 1.6 and earlier, by manually parsing the SVN __undocumented__ `entries` file (version 11 or earlier).
getversion_svn in the first revision (82d7a63) of core's version.py parsed `entries` and returned a **formatted** `tag` using
``` tag = '[%s] %s' % (t[0], t[1]) ```
79843a6 then used this tag value in a URL to github.com to obtain a hash, resulting in an error from github, and an exception in Python. `tag` was updated for SVN v1.7+, but not v1.6 and earlier.
(after creating a .svn/entries in the version 10 file format) ``` core$ python pwb.py shell Welcome to the Pywikibot interactive shell!
import pywikibot pywikibot.version.getversion_svn()
WARNING: Http response status 400
Traceback (most recent call last): File "<console>", line 1, in <module> File ".../pywikibot/version.py", line 184, in getversion_svn hsh = github_svn_rev2hash(tag, rev) File ".../pywikibot/version.py", line 166, in github_svn_rev2hash dom = xml.dom.minidom.parse(StringIO(data)) File "/usr/lib64/python2.7/xml/dom/minidom.py", line 1921, in parse return expatbuilder.parse(file) File "/usr/lib64/python2.7/xml/dom/expatbuilder.py", line 928, in parse result = builder.parseFile(file) File "/usr/lib64/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile parser.Parse(buffer, 0) ExpatError: undefined entity: line 13, column 20 ```
(the same bug appears in compat.)
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: pywikipedia-bugs, jayvdb, Aklapper, Anshoe
jayvdb added subscribers: Xqt, Betacommand. jayvdb added a comment.
Do we need to maintain support for SVN 1.6? It is now unsupported according to http://subversion.apache.org/docs/release-notes/#supported-versions , and 1.7 was released October 11, 2011.
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
jayvdb added a comment.
Also worth noting that the entries parser tries to extract the tag (repo) by removing 'svn.wikimedia.org/svnroot/pywikipedia/' , which might be useful when the svn branch is 'trunk', but is not useful when the svn checkout was 'branches/rewrite'
https://svn.wikimedia.org/svnroot/pywikipedia/ https://svn.wikimedia.org/svnroot/pywikipedia/branches/rewrite/
And __nobody__ should be obtaining source code using svn.wikimedia.org ; we give directions for obtaining it via svn using github
https://www.mediawiki.org/wiki/Manual:Pywikibot/Installation#Download_Pywiki...
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
jayvdb added a comment.
Note that TortoiseSVN 1.6 does not include a svn binary (or any non-GUI binary), and 1.7 has a 'command line client tools' subpackage in the installer, but it is not installed by default.
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
jayvdb edited the task description. jayvdb set Security to None.
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
jayvdb added a comment.
I've raised removing support for SVN 1.6 on the mailing list https://lists.wikimedia.org/pipermail/pywikipedia-l/2015-April/009268.html.
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
gerritbot added a subscriber: gerritbot. gerritbot added a comment.
Change 201931 had a related patch set uploaded (by John Vandenberg): Use setuptools for SVN support
https://gerrit.wikimedia.org/r/201931
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
gerritbot added a project: Patch-For-Review.
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
jayvdb added a blocked task: T95140: svn.wikimedia.org links in pywikibot.
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
gerritbot added a comment.
Change 201931 merged by jenkins-bot: Use setuptools for SVN support
https://gerrit.wikimedia.org/r/201931
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: gerritbot Cc: gerritbot, Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
jayvdb closed this task as "Resolved". jayvdb claimed this task.
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb Cc: gerritbot, Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
XZise added a subscriber: XZise. XZise added a comment.
Technically it's only solved for https://phabricator.wikimedia.org/tag/pywikibot-core/ (yet).
TASK DETAIL https://phabricator.wikimedia.org/T95077
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, XZise Cc: XZise, gerritbot, Betacommand, Xqt, jayvdb, Aklapper, Anshoe, pywikipedia-bugs
pywikipedia-bugs@lists.wikimedia.org