Daviskr added a subscriber: Daviskr. Daviskr added a comment.
I am porting the code over and assuming `logpages()` changes to `logevents()` [site.py]. When adapting the arguments from `LogpagesPageGenerator`, I assumed that `number` changes to `total` but two other arguments (`namespace` and `repeat`) seem to not fit in.
The port of the generator below this (`NewpagesPageGenerator`) ended up deprecating the `repeat` argument all together and changing `namespace` to `namespaces` and passing it to the respective `recentchanges()` [site.py] and then to `_generator()` as an argument of `spaces`.
`logevents()` does not accept `namespaces` as an arguments. So, should I change `logevents()` to accept a `namespaces` argument?
TASK DETAIL https://phabricator.wikimedia.org/T76555
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: Daviskr Cc: Aklapper, jayvdb, Daviskr, pywikipedia-bugs